<i18n dev> RFR: 8372609: Bug4944439 does not enforce locale correctly
Chen Liang
liach at openjdk.org
Wed Nov 26 18:44:53 UTC 2025
On Wed, 26 Nov 2025 18:35:40 GMT, Justin Lu <jlu at openjdk.org> wrote:
> This PR fixes a test bug where a `DecimalFormat` is instantiated in a static field (with the current default locale) before the test updates the system default to `Locale.US`. As a result, it may fail under various other locales, since a `Locale.US` configured `DecimalFormat` is not actually retrieved and the test expects one.
>
> In general, the preservation and restoring of the system locale is an obsolete process. The test is instead updated to just retrieve a `DecimalFormat` using a locale accepting factory method.
>
> I have manually confirmed that the tests passes with `-Duser.language=en -Duser.country=NL` on my machine, (which is the locale used in the reproducer).
Marked as reviewed by liach (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/28514#pullrequestreview-3512304444
More information about the i18n-dev
mailing list