<i18n dev> RFR: 8367704: Fix minor documentation issues in java.time.** [v8]

Pavel Rappo prappo at openjdk.org
Wed Oct 1 13:26:52 UTC 2025


> Please review this documentation-only change, which I believe does **NOT** require CSR.
> 
> The change touches java.time.** classes that I happen to have been using a lot recently. While the diff is pretty self-describing, here's the summary of what I did:
> 
> * used a comma separator for some big integer values, to improve readability;
> * fixed a few typos and grammar.
> 
> While I'm open to discuss the change, I also have some questions. Note: I'm not attempting to address those questions in this PR.
> 
> * What's the significance of the second argument in Duration.between(Temporal, Temporal) being exclusive? For example, would the result of the following call be different if the second argument was inclusive?
> 
>         Duration.between(Instant.ofEpochSecond(1), Instant.ofEpochSecond(2))
> 
>   Are there any cases here where that distinction matters?
> 
> * In many cases, the following phrase is used throughout documentation:
> 
>     > positive or negative
> 
>     While the intent is clearly to stress the directed nature of values, shouldn't we -- for completeness -- also mention zero where applicable?
> 
> * What's the significance of title-case for Java Time-Scale? FWIW, the documentation also uses "Java time-scale".

Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:

 - Merge remote-tracking branch 'jdk/master' into java.time
 - Revert this tiny change
   
   "Should" still feels out of place, but it's the same text
   copied across multiple packages. So it's better to leave
   it as is.
 - Remove CSR-triggering changes
 - An empty commit to kick GHA
 - Update src/java.base/share/classes/java/time/temporal/ChronoField.java
   
   Co-authored-by: Justin Lu <Justin.lu at oracle.com>
 - Update copyright years
   
   Note: any commit hashes below might be outdated due to subsequent
   history rewriting (e.g. git rebase).
   
    + update src/java.base/share/classes/java/time/package-info.java due to e58c5a4c023
    + update src/java.base/share/classes/java/time/temporal/ChronoField.java due to 4d8aadf8754
 - A few more typos
 - Extra typos and decimal separator
 - Use comma as a decimal separator
 - Fix Duration.abs
 - ... and 1 more: https://git.openjdk.org/jdk/compare/6e4fc3db...47c0d45f

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/27296/files
  - new: https://git.openjdk.org/jdk/pull/27296/files/7c4cc716..47c0d45f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=27296&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27296&range=06-07

  Stats: 153876 lines in 1576 files changed: 128305 ins; 14999 del; 10572 mod
  Patch: https://git.openjdk.org/jdk/pull/27296.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27296/head:pull/27296

PR: https://git.openjdk.org/jdk/pull/27296


More information about the i18n-dev mailing list