<i18n dev> RFR: 8369050: DecimalFormat Rounding Errors for Fractional Ties Near Zero [v2]
Naoto Sato
naoto at openjdk.org
Wed Oct 8 18:26:25 UTC 2025
On Wed, 8 Oct 2025 18:10:31 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which corrects a rounding error for DecimalFormat on tie cases when the maximum fraction digits allowed is one less than the position of the first significant digit in the double rounded. For example, rounding a value such as 0.0005 to a maximum of 3 fractional digits. In order to get the correct `count` value, we must strip the trailing zeros prior to the check to ensure we have the correct value of `count` = 1 so that we can go down the _Rounding position is the last index_ case which properly checks if the String double was already rounded or is exact from its true decimal form.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> Naoto's review -> test file rename
Marked as reviewed by naoto (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/27681#pullrequestreview-3316021946
More information about the i18n-dev
mailing list