<i18n dev> RFR: 8369452: Locale.Builder.setLanguageTag(String) does not clear on empty or null String [v2]
Justin Lu
jlu at openjdk.org
Thu Oct 9 23:42:40 UTC 2025
On Thu, 9 Oct 2025 23:27:06 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Naoto's comment - improve err msg
>
> test/jdk/java/util/Locale/LocaleEnhanceTest.java line 779:
>
>> 777: bldr.setLanguageTag("en-US");
>> 778: assertDoesNotThrow(() -> bldr.setLanguageTag(tag));
>> 779: assertEquals(tag + " did not clear the builder", empty.build(), bldr.build());
>
> Should not happen, but if empty string caused an assertion failure, the error message starts with " did not clear..."
Good point, updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27734#discussion_r2418189274
More information about the i18n-dev
mailing list