<i18n dev> RFR: 8363925: Remove unused sun.nio.cs.ArrayEncoder::encode [v2]

[Volkan Yazici]

On Mon, 27 Oct 2025 23:02:44 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use `HexFormat`
>>   
>>   Co-authored-by: Roger Riggs <Roger.Riggs at Oracle.com>
>
> I recommend further refactors, at least turn the 3 default methods to abstract methods. After removal of ineffective CESU_8, we can make the default methods abstract to improve safety.
> 
> Down the road, we can remove the -1 handling at use site, and also pass in dp explicitly (I recall this being useful for optimizing Writer/OutputStream)

@liach, thanks so much for the review! 🙇

> I recommend further refactors, at least turn the 3 default methods to abstract methods.
> After removal of ineffective CESU_8, we can make the default methods abstract to improve safety.
> Down the road, we can remove the -1 handling at use site, and also pass in dp explicitly

All done in 7fc526759bf.

> I recall this [passing `dp` explicitly] being useful for optimizing Writer/OutputStream

Skimmed through `ArrayEncoder::encodeFrom*` call-sites, but could not spot anything particular that can quickly be addressed.

Please let me know if there are any changes I can carry out within the scope of this JBS/PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27999#issuecomment-3455507136