<i18n dev> RFR: 8367324: Avoid redundant parsing when formatting with DigitList [v2]

Justin Lu jlu at openjdk.org
Fri Sep 12 21:13:19 UTC 2025


On Wed, 10 Sep 2025 23:47:47 GMT, Johannes Graham <duke at openjdk.org> wrote:

>> When formatting doubles or BigDecimals, DigitList first formats them as a string and then parses the resultant string to extract the mantissa and the exponent. This can be done more directly. This allows removing some parsing code and removes a cached byte array.
>> 
>> This also facilitates potential cleanups in FloatingDecimal (removal of getChars method) but I've left that for later to minimize conflicts with other changes there.
>
> Johannes Graham has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - use Level.Invocation
>  - review fixes

test/micro/org/openjdk/bench/java/text/DefFormatterBench.java line 86:

> 84: 
> 85:     @Benchmark
> 86:     @OperationsPerInvocation(13)

Now that we are reusing 13 multiple times, we can replace such occurrences with a constant. `VALUES_SIZE`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27118#discussion_r2345116810


More information about the i18n-dev mailing list