<i18n dev> RFR: 8367704: Fix minor documentation issues in java.time.** [v2]

Pavel Rappo prappo at openjdk.org
Mon Sep 15 22:31:28 UTC 2025


> Please review this documentation-only change, which I believe does **NOT** require CSR.
> 
> The change touches java.time.** classes that I happen to have been using a lot recently. While the diff is pretty self-describing, here's the summary of what I did:
> 
> * used a comma separator for some big integer values, to improve readability;
> * fixed a few typos and grammar.
> 
> While I'm open to discuss the change, I also have some questions. Note: I'm not attempting to address those questions in this PR.
> 
> * What's the significance of the second argument in Duration.between(Temporal, Temporal) being exclusive? For example, would the result of the following call be different if the second argument was inclusive?
> 
>         Duration.between(Instant.ofEpochSecond(1), Instant.ofEpochSecond(2))
> 
>   Are there any cases here where that distinction matters?
> 
> * In many cases, the following phrase is used throughout documentation:
> 
>     > positive or negative
> 
>     While the intent is clearly to stress the directed nature of values, shouldn't we -- for completeness -- also mention zero where applicable?
> 
> * What's the significance of title-case for Java Time-Scale? FWIW, the documentation also uses "Java time-scale".
> ---------
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> 
> 
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/jdk.git pull/27296/head:pull/27296` \
> `$ git checkout pull/27296`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/27296` \
> `$ git pull https://git.openjdk.org/jdk.git pull/27296/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 27296`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 27296`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/jdk/pull/27296.diff">https://git.openjdk.org/jdk/pull/27296.diff</a>
> 
> </details>

Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:

  Extra typos and decimal separator

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/27296/files
  - new: https://git.openjdk.org/jdk/pull/27296/files/540e48e1..4d8aadf8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=27296&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27296&range=00-01

  Stats: 9 lines in 4 files changed: 0 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/27296.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27296/head:pull/27296

PR: https://git.openjdk.org/jdk/pull/27296


More information about the i18n-dev mailing list