From jonathan.gibbons at oracle.com Fri Oct 16 19:02:51 2020 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 16 Oct 2020 12:02:51 -0700 Subject: RFR 7902706: IntelliJ jtreg plugin crashes because of removal of deprecated icon In-Reply-To: <8a274892-d5b8-6be1-9488-d679ba65b9cb@oracle.com> References: <8a274892-d5b8-6be1-9488-d679ba65b9cb@oracle.com> Message-ID: <5f524615-a1af-4f66-2cdc-c324ecbc607a@oracle.com> I'm not an expert on this code, but the changes look reasonable to me. Given that this code has been in use for a while, you can consider this as an approval. -- Jon On 6/18/20 3:07 AM, Maurizio Cimadamore wrote: > Hi, > this is a path that fixes the crash in the intellij jtreg plugin which > started to occur in the latest version 2020.1. > > http://cr.openjdk.java.net/~mcimadamore/7902706/webrev/ > > This patch is based on some work submitted few weeks ago by John Rhee > [1]; I sprinkled the usual reflective goop on top to make sure that > the plugin keeps working against old versions too (as the new Target > icon is only defined for 2019.x). > > I've also added an overload for a method whose implementation is > deprecated, namely ConfigurationFactory::getId; this should keep > things from breaking in the medium run. > > As a general note, I see that the IDE is giving quite a bit of warning > around the plugin code - in many instances IntelliJ is trying to move > towards a lazier/more declarative way to register listener to events > [2]. But I think a point will come in which we won't be able to evolve > the plugin in a compatible way - so at some point in the future we > should probably start thinking about dropping support for older > version and start using 2019 as base. > > Cheers > Maurizio > > > [1] - > https://mail.openjdk.java.net/pipermail/jtreg-dev/2020-May/000826.html > [2] - > https://www.jetbrains.org/intellij/sdk/docs/basics/plugin_structure/plugin_listeners.html > From maurizio.cimadamore at oracle.com Fri Oct 16 20:28:50 2020 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Fri, 16 Oct 2020 21:28:50 +0100 Subject: RFR 7902706: IntelliJ jtreg plugin crashes because of removal of deprecated icon In-Reply-To: <5f524615-a1af-4f66-2cdc-c324ecbc607a@oracle.com> References: <8a274892-d5b8-6be1-9488-d679ba65b9cb@oracle.com> <5f524615-a1af-4f66-2cdc-c324ecbc607a@oracle.com> Message-ID: <593afbca-7306-8eb9-da72-52996160e5dd@oracle.com> Thanks Jon Maurizio On 16/10/2020 20:02, Jonathan Gibbons wrote: > I'm not an expert on this code, but the changes look reasonable to me. > > Given that this code has been in use for a while, you can consider > this as an approval. > > -- Jon > > On 6/18/20 3:07 AM, Maurizio Cimadamore wrote: >> Hi, >> this is a path that fixes the crash in the intellij jtreg plugin >> which started to occur in the latest version 2020.1. >> >> http://cr.openjdk.java.net/~mcimadamore/7902706/webrev/ >> >> This patch is based on some work submitted few weeks ago by John Rhee >> [1]; I sprinkled the usual reflective goop on top to make sure that >> the plugin keeps working against old versions too (as the new Target >> icon is only defined for 2019.x). >> >> I've also added an overload for a method whose implementation is >> deprecated, namely ConfigurationFactory::getId; this should keep >> things from breaking in the medium run. >> >> As a general note, I see that the IDE is giving quite a bit of >> warning around the plugin code - in many instances IntelliJ is trying >> to move towards a lazier/more declarative way to register listener to >> events [2]. But I think a point will come in which we won't be able >> to evolve the plugin in a compatible way - so at some point in the >> future we should probably start thinking about dropping support for >> older version and start using 2019 as base. >> >> Cheers >> Maurizio >> >> >> [1] - >> https://mail.openjdk.java.net/pipermail/jtreg-dev/2020-May/000826.html >> [2] - >> https://www.jetbrains.org/intellij/sdk/docs/basics/plugin_structure/plugin_listeners.html >>