From mcimadamore at openjdk.java.net Thu Jul 1 00:08:03 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Thu, 1 Jul 2021 00:08:03 GMT Subject: RFR: 8269700: source level for IntelliJ JDK project is set incorrectly In-Reply-To: References: Message-ID: On Wed, 30 Jun 2021 11:43:38 GMT, Sergei Ustimenko wrote: > After generating an Intellij project with the `idea.sh` script, IDEA might get confused > with the language level settings in generated .idea/misc.xml. This results in a problem > with modules discussed in https://mail.openjdk.java.net/pipermail/ide-support-dev/2021-June/000082.html. > To mitigate the problem changing the project's language level helps. > > This patch sets language level for jdk Intellij Project to [X (Experimental Features)](https://github.com/JetBrains/intellij-community/blob/master/jps/model-api/src/org/jetbrains/jps/model/java/LanguageLevel.java) to avoid such problems. > > As a side effect following term needs to be accepted in IDEA once opening the project for the first time: > > You must accept the terms of legal notice of the beta Java specification > to enable support for "X - Experimental features". The implementation > of an early-draft specification developed under the Java Community Process (JCP) > is made available for testing and evaluation purposes only and is not > compatible with any specification of the JCP. The change looks good to me! ------------- Marked as reviewed by mcimadamore (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4634 From jvernee at openjdk.java.net Thu Jul 1 14:49:10 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Thu, 1 Jul 2021 14:49:10 GMT Subject: RFR: 8269758: idea.sh doesn't work when there are multiple configurations available. Message-ID: <685DeZ2z-zd4XjPU_eDeBLtT35ZhQ8hp0-b7uhEXOa0=.ad312af0-52b4-42a8-b10a-c09b187f5efb@github.com> >From the JBS issue: The idea.sh script invokes `make`, but doesn't specify a configuration. So, when multiple configurations are present, this results in an error like this: $ bash bin/idea.sh java.base Error: No CONF given, but more than one configuration found. Available configurations in /mnt/c/jdk/build: * conf1 * conf2 * conf3 Please retry building with CONF= (or SPEC=). ------------- Commit messages: - Allow specifying conf to idea.sh Changes: https://git.openjdk.java.net/jdk/pull/4654/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4654&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269758 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/4654.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4654/head:pull/4654 PR: https://git.openjdk.java.net/jdk/pull/4654 From jvernee at openjdk.java.net Thu Jul 1 15:02:12 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Thu, 1 Jul 2021 15:02:12 GMT Subject: RFR: 8269760: idea.sh should not invoke cygpath directly Message-ID: >From the JBS issue: Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking `cygpath` directly. This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to something else, such as `wslpath`. Instead of invoking `cygpath` directly, the value of the `CYGPATH` variable should be used. ------------- Depends on: https://git.openjdk.java.net/jdk/pull/4654 Commit messages: - use CYGPATH variable instead of calling cygpath directly Changes: https://git.openjdk.java.net/jdk/pull/4655/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4655&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269760 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/jdk/pull/4655.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4655/head:pull/4655 PR: https://git.openjdk.java.net/jdk/pull/4655 From jvernee at openjdk.java.net Thu Jul 1 15:10:22 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Thu, 1 Jul 2021 15:10:22 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL Message-ID: >From the JBS issue: At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. ------------- Depends on: https://git.openjdk.java.net/jdk/pull/4655 Commit messages: - Add .exe suffix when invoking javac on WSL Changes: https://git.openjdk.java.net/jdk/pull/4656/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4656&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269761 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/4656.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4656/head:pull/4656 PR: https://git.openjdk.java.net/jdk/pull/4656 From mcimadamore at openjdk.java.net Thu Jul 1 16:09:04 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Thu, 1 Jul 2021 16:09:04 GMT Subject: RFR: 8269758: idea.sh doesn't work when there are multiple configurations available. In-Reply-To: <685DeZ2z-zd4XjPU_eDeBLtT35ZhQ8hp0-b7uhEXOa0=.ad312af0-52b4-42a8-b10a-c09b187f5efb@github.com> References: <685DeZ2z-zd4XjPU_eDeBLtT35ZhQ8hp0-b7uhEXOa0=.ad312af0-52b4-42a8-b10a-c09b187f5efb@github.com> Message-ID: On Thu, 1 Jul 2021 14:41:53 GMT, Jorn Vernee wrote: > From the JBS issue: > > The idea.sh script invokes `make`, but doesn't specify a configuration. So, when multiple configurations are present, this results in an error like this: > > > $ bash bin/idea.sh java.base > Error: No CONF given, but more than one configuration found. > Available configurations in /mnt/c/jdk/build: > * conf1 > * conf2 > * conf3 > Please retry building with CONF= (or SPEC=). Looks good! ------------- Marked as reviewed by mcimadamore (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4654 From mcimadamore at openjdk.java.net Thu Jul 1 16:10:10 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Thu, 1 Jul 2021 16:10:10 GMT Subject: RFR: 8269760: idea.sh should not invoke cygpath directly In-Reply-To: References: Message-ID: On Thu, 1 Jul 2021 14:54:04 GMT, Jorn Vernee wrote: > From the JBS issue: > > Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking `cygpath` directly. > > This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to something else, such as `wslpath`. > > Instead of invoking `cygpath` directly, the value of the `CYGPATH` variable should be used. Not an expert on the value of these variables, but the changes you have look consistent. ------------- Marked as reviewed by mcimadamore (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4655 From mcimadamore at openjdk.java.net Thu Jul 1 16:12:58 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Thu, 1 Jul 2021 16:12:58 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL In-Reply-To: References: Message-ID: On Thu, 1 Jul 2021 15:02:03 GMT, Jorn Vernee wrote: > From the JBS issue: > > At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: > > bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory > > Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. Nice! Thanks. Question though: with WSL, the boot JDK could also be a Linux JDK, no? If that's the case, then the .exe suffix would be bad? ------------- Marked as reviewed by mcimadamore (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4656 From jvernee at openjdk.java.net Thu Jul 1 16:22:06 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Thu, 1 Jul 2021 16:22:06 GMT Subject: RFR: 8269760: idea.sh should not invoke cygpath directly In-Reply-To: References: Message-ID: On Thu, 1 Jul 2021 16:06:47 GMT, Maurizio Cimadamore wrote: > Not an expert on the value of these variables My own line of thought is that it is reasonable to expect that anything found in the `CYGPATH` variable is fine to treat as if it were `cygpath` like this (this could be an alternative `cygpath` binary, or a substitutable implementation like `wslpath`) ------------- PR: https://git.openjdk.java.net/jdk/pull/4655 From erikj at openjdk.java.net Fri Jul 2 14:15:51 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Fri, 2 Jul 2021 14:15:51 GMT Subject: RFR: 8269758: idea.sh doesn't work when there are multiple configurations available. In-Reply-To: <685DeZ2z-zd4XjPU_eDeBLtT35ZhQ8hp0-b7uhEXOa0=.ad312af0-52b4-42a8-b10a-c09b187f5efb@github.com> References: <685DeZ2z-zd4XjPU_eDeBLtT35ZhQ8hp0-b7uhEXOa0=.ad312af0-52b4-42a8-b10a-c09b187f5efb@github.com> Message-ID: On Thu, 1 Jul 2021 14:41:53 GMT, Jorn Vernee wrote: > From the JBS issue: > > The idea.sh script invokes `make`, but doesn't specify a configuration. So, when multiple configurations are present, this results in an error like this: > > > $ bash bin/idea.sh java.base > Error: No CONF given, but more than one configuration found. > Available configurations in /mnt/c/jdk/build: > * conf1 > * conf2 > * conf3 > Please retry building with CONF= (or SPEC=). Marked as reviewed by erikj (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/4654 From erikj at openjdk.java.net Fri Jul 2 14:18:07 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Fri, 2 Jul 2021 14:18:07 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL In-Reply-To: References: Message-ID: On Thu, 1 Jul 2021 16:10:03 GMT, Maurizio Cimadamore wrote: > Question though: with WSL, the boot JDK could also be a Linux JDK, no? If that's the case, then the .exe suffix would be bad? That's a good point, maybe check if BOOT_JDK/bin/java.exe exists and have that as the condition? ------------- PR: https://git.openjdk.java.net/jdk/pull/4656 From erikj at openjdk.java.net Fri Jul 2 14:19:06 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Fri, 2 Jul 2021 14:19:06 GMT Subject: RFR: 8269760: idea.sh should not invoke cygpath directly In-Reply-To: References: Message-ID: On Thu, 1 Jul 2021 14:54:04 GMT, Jorn Vernee wrote: > From the JBS issue: > > Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking `cygpath` directly. > > This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to something else, such as `wslpath`. > > Instead of invoking `cygpath` directly, the value of the `CYGPATH` variable should be used. Marked as reviewed by erikj (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/4655 From github.com+5709644+fdesu at openjdk.java.net Mon Jul 5 08:40:52 2021 From: github.com+5709644+fdesu at openjdk.java.net (Sergei Ustimenko) Date: Mon, 5 Jul 2021 08:40:52 GMT Subject: RFR: 8269700: source level for IntelliJ JDK project is set incorrectly In-Reply-To: References: Message-ID: On Wed, 30 Jun 2021 11:43:38 GMT, Sergei Ustimenko wrote: > After generating an Intellij project with the `idea.sh` script, IDEA might get confused > with the language level settings in generated .idea/misc.xml. This results in a problem > with modules discussed in https://mail.openjdk.java.net/pipermail/ide-support-dev/2021-June/000082.html. > To mitigate the problem changing the project's language level helps. > > This patch sets language level for jdk Intellij Project to [X (Experimental Features)](https://github.com/JetBrains/intellij-community/blob/master/jps/model-api/src/org/jetbrains/jps/model/java/LanguageLevel.java) to avoid such problems. > > As a side effect following term needs to be accepted in IDEA once opening the project for the first time: > > You must accept the terms of legal notice of the beta Java specification > to enable support for "X - Experimental features". The implementation > of an early-draft specification developed under the Java Community Process (JCP) > is made available for testing and evaluation purposes only and is not > compatible with any specification of the JCP. I would really appreciate and it would be absolutely awesome if someone could sponsor this change or let me know if it needs some more polishing. Thanks! ------------- PR: https://git.openjdk.java.net/jdk/pull/4634 From github.com+5709644+fdesu at openjdk.java.net Mon Jul 5 09:12:52 2021 From: github.com+5709644+fdesu at openjdk.java.net (Sergei Ustimenko) Date: Mon, 5 Jul 2021 09:12:52 GMT Subject: Integrated: 8269700: source level for IntelliJ JDK project is set incorrectly In-Reply-To: References: Message-ID: On Wed, 30 Jun 2021 11:43:38 GMT, Sergei Ustimenko wrote: > After generating an Intellij project with the `idea.sh` script, IDEA might get confused > with the language level settings in generated .idea/misc.xml. This results in a problem > with modules discussed in https://mail.openjdk.java.net/pipermail/ide-support-dev/2021-June/000082.html. > To mitigate the problem changing the project's language level helps. > > This patch sets language level for jdk Intellij Project to [X (Experimental Features)](https://github.com/JetBrains/intellij-community/blob/master/jps/model-api/src/org/jetbrains/jps/model/java/LanguageLevel.java) to avoid such problems. > > As a side effect following term needs to be accepted in IDEA once opening the project for the first time: > > You must accept the terms of legal notice of the beta Java specification > to enable support for "X - Experimental features". The implementation > of an early-draft specification developed under the Java Community Process (JCP) > is made available for testing and evaluation purposes only and is not > compatible with any specification of the JCP. This pull request has now been integrated. Changeset: 371d996a Author: Sergei Ustimenko Committer: Maurizio Cimadamore URL: https://git.openjdk.java.net/jdk/commit/371d996a892fc6fbf82110a1ca5b3d64a801b6fc Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8269700: source level for IntelliJ JDK project is set incorrectly Reviewed-by: mcimadamore ------------- PR: https://git.openjdk.java.net/jdk/pull/4634 From jvernee at openjdk.java.net Mon Jul 5 10:20:53 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 5 Jul 2021 10:20:53 GMT Subject: Integrated: 8269758: idea.sh doesn't work when there are multiple configurations available. In-Reply-To: <685DeZ2z-zd4XjPU_eDeBLtT35ZhQ8hp0-b7uhEXOa0=.ad312af0-52b4-42a8-b10a-c09b187f5efb@github.com> References: <685DeZ2z-zd4XjPU_eDeBLtT35ZhQ8hp0-b7uhEXOa0=.ad312af0-52b4-42a8-b10a-c09b187f5efb@github.com> Message-ID: On Thu, 1 Jul 2021 14:41:53 GMT, Jorn Vernee wrote: > From the JBS issue: > > The idea.sh script invokes `make`, but doesn't specify a configuration. So, when multiple configurations are present, this results in an error like this: > > > $ bash bin/idea.sh java.base > Error: No CONF given, but more than one configuration found. > Available configurations in /mnt/c/jdk/build: > * conf1 > * conf2 > * conf3 > Please retry building with CONF= (or SPEC=). This pull request has now been integrated. Changeset: 73198968 Author: Jorn Vernee URL: https://git.openjdk.java.net/jdk/commit/73198968e245362607a8b2e4f80e261fc77d0441 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod 8269758: idea.sh doesn't work when there are multiple configurations available. Reviewed-by: mcimadamore, erikj ------------- PR: https://git.openjdk.java.net/jdk/pull/4654 From "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net Mon Jul 5 10:28:15 2021 From: "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net (openjdk-notifier [bot]) Date: Mon, 5 Jul 2021 10:28:15 GMT Subject: RFR: 8269760: idea.sh should not invoke cygpath directly In-Reply-To: References: Message-ID: <0CQ9wm59lhXRqrMqZXe2VbVRAxWgiGjw1SmYZPiNo2E=.b1446413-765f-4d34-812f-9c77f7112e28@github.com> On Thu, 1 Jul 2021 14:54:04 GMT, Jorn Vernee wrote: > From the JBS issue: > > Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking `cygpath` directly. > > This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to something else, such as `wslpath`. > > Instead of invoking `cygpath` directly, the value of the `CYGPATH` variable should be used. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout Idea_Conf git fetch https://git.openjdk.java.net/jdk master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk/pull/4655 From jvernee at openjdk.java.net Mon Jul 5 10:28:15 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 5 Jul 2021 10:28:15 GMT Subject: RFR: 8269760: idea.sh should not invoke cygpath directly [v2] In-Reply-To: References: Message-ID: > From the JBS issue: > > Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking `cygpath` directly. > > This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to something else, such as `wslpath`. > > Instead of invoking `cygpath` directly, the value of the `CYGPATH` variable should be used. Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/4655/files - new: https://git.openjdk.java.net/jdk/pull/4655/files/a95d4154..a95d4154 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4655&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4655&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/4655.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4655/head:pull/4655 PR: https://git.openjdk.java.net/jdk/pull/4655 From jvernee at openjdk.java.net Mon Jul 5 10:28:16 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 5 Jul 2021 10:28:16 GMT Subject: Integrated: 8269760: idea.sh should not invoke cygpath directly In-Reply-To: References: Message-ID: On Thu, 1 Jul 2021 14:54:04 GMT, Jorn Vernee wrote: > From the JBS issue: > > Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking `cygpath` directly. > > This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to something else, such as `wslpath`. > > Instead of invoking `cygpath` directly, the value of the `CYGPATH` variable should be used. This pull request has now been integrated. Changeset: 76783cd8 Author: Jorn Vernee URL: https://git.openjdk.java.net/jdk/commit/76783cd8cbb390dc9ac1da72962ce15e98ea5d3c Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod 8269760: idea.sh should not invoke cygpath directly Reviewed-by: mcimadamore, erikj ------------- PR: https://git.openjdk.java.net/jdk/pull/4655 From jvernee at openjdk.java.net Mon Jul 5 10:31:13 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 5 Jul 2021 10:31:13 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v2] In-Reply-To: References: Message-ID: > From the JBS issue: > > At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: > > bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory > > Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/4656/files - new: https://git.openjdk.java.net/jdk/pull/4656/files/9b0f6ba5..9b0f6ba5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4656&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4656&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/4656.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4656/head:pull/4656 PR: https://git.openjdk.java.net/jdk/pull/4656 From "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net Mon Jul 5 10:31:13 2021 From: "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net (openjdk-notifier [bot]) Date: Mon, 5 Jul 2021 10:31:13 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL In-Reply-To: References: Message-ID: On Thu, 1 Jul 2021 15:02:03 GMT, Jorn Vernee wrote: > From the JBS issue: > > At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: > > bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory > > Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout Idea_Cygpath git fetch https://git.openjdk.java.net/jdk master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push ------------- PR: https://git.openjdk.java.net/jdk/pull/4656 From jvernee at openjdk.java.net Mon Jul 5 10:40:17 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 5 Jul 2021 10:40:17 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v2] In-Reply-To: References: Message-ID: On Mon, 5 Jul 2021 10:31:13 GMT, Jorn Vernee wrote: >> From the JBS issue: >> >> At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: >> >> bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory >> >> Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. > > Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. I realized this as well, but it doesn't look like the script works when using a linux boot JDK any way currently. The source file that is passed to `javac` is a Windows path: JAVAC_SOURCE_FILE=`$CYGPATH -am $IDEA_OUTPUT/src/idea/IdeaLoggerWrapper.java` ... $BOOT_JDK/bin/$JAVAC$EXE_SUFFIX -d $JAVAC_CLASSES -sourcepath $JAVAC_SOURCE_PATH -cp $JAVAC_CP $JAVAC_SOURCE_FILE So, I could change the test to look for `BOOT_JDK/bin/java.exe`, but then the script fails with: error: file not found: H:/openjdk/git-jdk2/.idea/src/idea/IdeaLoggerWrapper.java The rest of the script checks for `"x$WSL_DISTRO_NAME" != "x"` and then uses Windows style paths. So, I'd rather leave the current check for adding the `.exe` suffix to do the same (consistent with the rest of the script), and leave adding support for running the script with a linux boot JDK on WSL for another time, since that doesn't seem to be a quick fix. ------------- PR: https://git.openjdk.java.net/jdk/pull/4656 From jvernee at openjdk.java.net Mon Jul 5 10:40:15 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 5 Jul 2021 10:40:15 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v3] In-Reply-To: References: Message-ID: > From the JBS issue: > > At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: > > bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory > > Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into Idea_Exe - Add .exe suffix when invoking javac on WSL - use CYGPATH variable instead of calling cygpath directly - Allow specifying conf to idea.sh ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/4656/files - new: https://git.openjdk.java.net/jdk/pull/4656/files/9b0f6ba5..cd925bbf Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4656&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4656&range=01-02 Stats: 2704 lines in 99 files changed: 1617 ins; 450 del; 637 mod Patch: https://git.openjdk.java.net/jdk/pull/4656.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4656/head:pull/4656 PR: https://git.openjdk.java.net/jdk/pull/4656 From jvernee at openjdk.java.net Mon Jul 5 11:00:54 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 5 Jul 2021 11:00:54 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v3] In-Reply-To: References: Message-ID: On Mon, 5 Jul 2021 10:40:15 GMT, Jorn Vernee wrote: >> From the JBS issue: >> >> At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: >> >> bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory >> >> Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. > > Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into Idea_Exe > - Add .exe suffix when invoking javac on WSL > - use CYGPATH variable instead of calling cygpath directly > - Allow specifying conf to idea.sh Hmm, now that I'm looking again, I see that an earlier block also tries to set `JAVAC` to `javac.exe` on WSL, but it never gets executed because `CYGPATH` is set in my environment: if [ "x$CYGPATH" != "x" ] ; then ## CYGPATH may be set in env.cfg ... JAVAC=javac elif [ "x$WSL_DISTRO_NAME" != "x" ]; then ... JAVAC=javac.exe else Of course, when I remove my fix, and move the `"x$WSL_DISTRO_NAME" != "x"` to the front, this also fails on a linux boot JDK because `javac.exe` doesn't exist. If I remove the `.exe` suffix then the usage of `realpath` in that same block makes the script work on a linux boot JDK, but fails again on a Windows boot JDK because of the missing .exe suffix. I'll try to see if I can make the existing logic work on both JDK types ------------- PR: https://git.openjdk.java.net/jdk/pull/4656 From jvernee at openjdk.java.net Mon Jul 5 18:05:19 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 5 Jul 2021 18:05:19 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v4] In-Reply-To: References: Message-ID: > From the JBS issue: > > At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: > > bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory > > Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: Make idea.sh work on WSL with a Linux boot JDK ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/4656/files - new: https://git.openjdk.java.net/jdk/pull/4656/files/cd925bbf..90909fda Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4656&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4656&range=02-03 Stats: 26 lines in 1 file changed: 12 ins; 7 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/4656.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4656/head:pull/4656 PR: https://git.openjdk.java.net/jdk/pull/4656 From mcimadamore at openjdk.java.net Mon Jul 5 20:13:52 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Mon, 5 Jul 2021 20:13:52 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v4] In-Reply-To: References: Message-ID: <5OujURN2_v0x8u0hecZYgv000-WKK4oJ3Z4PxZOQ7UY=.afc5bd5f-e5c2-45c3-8384-acf87325b5a0@github.com> On Mon, 5 Jul 2021 18:05:19 GMT, Jorn Vernee wrote: >> From the JBS issue: >> >> At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: >> >> bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory >> >> Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. > > Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: > > Make idea.sh work on WSL with a Linux boot JDK Looks good! ------------- Marked as reviewed by mcimadamore (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4656 From jvernee at openjdk.java.net Tue Jul 6 10:41:49 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Tue, 6 Jul 2021 10:41:49 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v4] In-Reply-To: References: Message-ID: On Mon, 5 Jul 2021 18:05:19 GMT, Jorn Vernee wrote: >> From the JBS issue: >> >> At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: >> >> bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory >> >> Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. > > Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: > > Make idea.sh work on WSL with a Linux boot JDK bin/idea.sh line 74: > 72: if [ -e $IDEA_OUTPUT ] ; then > 73: rm -r $IDEA_OUTPUT > 74: fi Was getting some weird errors when the `.idea` folder already existed when running the script, so I added this. It seems useful, so I've left it in. ------------- PR: https://git.openjdk.java.net/jdk/pull/4656 From mcimadamore at openjdk.java.net Tue Jul 6 10:48:51 2021 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Tue, 6 Jul 2021 10:48:51 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v4] In-Reply-To: References: Message-ID: On Tue, 6 Jul 2021 10:38:35 GMT, Jorn Vernee wrote: >> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: >> >> Make idea.sh work on WSL with a Linux boot JDK > > bin/idea.sh line 74: > >> 72: if [ -e $IDEA_OUTPUT ] ; then >> 73: rm -r $IDEA_OUTPUT >> 74: fi > > Was getting some weird errors when the `.idea` folder already existed when running the script, so I added this. It seems useful, so I've left it in. Yep - noticed that, it's good ------------- PR: https://git.openjdk.java.net/jdk/pull/4656 From erikj at openjdk.java.net Tue Jul 6 21:09:48 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Tue, 6 Jul 2021 21:09:48 GMT Subject: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v4] In-Reply-To: References: Message-ID: <9zsBR9BLVxDf3hl4QVxjEZVi3HnL43Unc-2Jd8bZLgQ=.d1f37fce-4b88-484b-a99f-1ece47840aa5@github.com> On Mon, 5 Jul 2021 18:05:19 GMT, Jorn Vernee wrote: >> From the JBS issue: >> >> At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: >> >> bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory >> >> Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. > > Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: > > Make idea.sh work on WSL with a Linux boot JDK Marked as reviewed by erikj (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/4656 From jvernee at openjdk.java.net Wed Jul 7 10:07:56 2021 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Wed, 7 Jul 2021 10:07:56 GMT Subject: Integrated: 8269761: idea.sh missing .exe suffix when invoking javac on WSL In-Reply-To: References: Message-ID: On Thu, 1 Jul 2021 15:02:03 GMT, Jorn Vernee wrote: > From the JBS issue: > > At the end, idea.sh tries to invoke javac, but when running on WSL this results in the following error: > > bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such file or directory > > Adding a .exe suffix to the javac path fixes this issue, which can be done just for WSL. This pull request has now been integrated. Changeset: 77a5b7b2 Author: Jorn Vernee URL: https://git.openjdk.java.net/jdk/commit/77a5b7b27e36457cf63be45b3e4f120abad57d4a Stats: 20 lines in 1 file changed: 12 ins; 2 del; 6 mod 8269761: idea.sh missing .exe suffix when invoking javac on WSL Reviewed-by: mcimadamore, erikj ------------- PR: https://git.openjdk.java.net/jdk/pull/4656