RFR: 8269760: idea.sh should not invoke cygpath directly

openjdk-notifier [bot] "github.com+73116608+openjdk-notifier[bot]" at openjdk.java.net
Mon Jul 5 10:28:15 UTC 2021


On Thu, 1 Jul 2021 14:54:04 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> From the JBS issue:
> 
> Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking `cygpath` directly.
> 
> This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to something else, such as `wslpath`.
> 
> Instead of invoking `cygpath` directly, the value of the `CYGPATH` variable should be used.

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:


git checkout Idea_Conf
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

-------------

PR: https://git.openjdk.java.net/jdk/pull/4655


More information about the ide-support-dev mailing list