From djelinski at openjdk.java.net Tue Apr 12 04:51:16 2022 From: djelinski at openjdk.java.net (Daniel =?UTF-8?B?SmVsacWEc2tp?=) Date: Tue, 12 Apr 2022 04:51:16 GMT Subject: RFR: 8284720: IntelliJ: JIRA integration Message-ID: This patch adds clickable link to commit messages in IntelliJ's git log. Example result: ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png) ------------- Commit messages: - JIRA integration Changes: https://git.openjdk.java.net/jdk/pull/8193/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8193&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8284720 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/8193.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8193/head:pull/8193 PR: https://git.openjdk.java.net/jdk/pull/8193 From duke at openjdk.java.net Tue Apr 12 07:10:39 2022 From: duke at openjdk.java.net (=?UTF-8?B?0KHQtdGA0LPQtdC5?= =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=) Date: Tue, 12 Apr 2022 07:10:39 GMT Subject: RFR: 8284720: IntelliJ: JIRA integration In-Reply-To: References: Message-ID: On Tue, 12 Apr 2022 04:44:15 GMT, Daniel Jeli?ski wrote: > This patch adds clickable link to commit messages in IntelliJ's git log. Example result: > ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png) Looks fine and useful! ------------- Marked as reviewed by stsypanov at github.com (no known OpenJDK username). PR: https://git.openjdk.java.net/jdk/pull/8193 From mcimadamore at openjdk.java.net Tue Apr 12 09:36:43 2022 From: mcimadamore at openjdk.java.net (Maurizio Cimadamore) Date: Tue, 12 Apr 2022 09:36:43 GMT Subject: RFR: 8284720: IntelliJ: JIRA integration In-Reply-To: References: Message-ID: On Tue, 12 Apr 2022 04:44:15 GMT, Daniel Jeli?ski wrote: > This patch adds clickable link to commit messages in IntelliJ's git log. Example result: > ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png) Very neat! ------------- Marked as reviewed by mcimadamore (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8193 From ihse at openjdk.java.net Tue Apr 12 10:12:37 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Tue, 12 Apr 2022 10:12:37 GMT Subject: RFR: 8284720: IntelliJ: JIRA integration In-Reply-To: References: Message-ID: On Tue, 12 Apr 2022 04:44:15 GMT, Daniel Jeli?ski wrote: > This patch adds clickable link to commit messages in IntelliJ's git log. Example result: > ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png) Clever idea. ------------- Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8193 From aturbanov at openjdk.java.net Wed Apr 13 08:39:17 2022 From: aturbanov at openjdk.java.net (Andrey Turbanov) Date: Wed, 13 Apr 2022 08:39:17 GMT Subject: RFR: 8284720: IntelliJ: JIRA integration In-Reply-To: References: Message-ID: On Tue, 12 Apr 2022 04:44:15 GMT, Daniel Jeli?ski wrote: > This patch adds clickable link to commit messages in IntelliJ's git log. Example result: > ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png) BTW, `\d` in regexps is a bit slower than `[0-9]`. It's because `[0-9]` matches only ASCII digits, while `\d` additional matches by extended unicode digits. ------------- PR: https://git.openjdk.java.net/jdk/pull/8193 From djelinski at openjdk.java.net Wed Apr 13 10:37:19 2022 From: djelinski at openjdk.java.net (Daniel =?UTF-8?B?SmVsacWEc2tp?=) Date: Wed, 13 Apr 2022 10:37:19 GMT Subject: Integrated: 8284720: IntelliJ: JIRA integration In-Reply-To: References: Message-ID: On Tue, 12 Apr 2022 04:44:15 GMT, Daniel Jeli?ski wrote: > This patch adds clickable link to commit messages in IntelliJ's git log. Example result: > ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png) This pull request has now been integrated. Changeset: 507dc41a Author: Daniel Jeli?ski URL: https://git.openjdk.java.net/jdk/commit/507dc41a53cdbaf60fdf5b198ffc19e767230823 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod 8284720: IntelliJ: JIRA integration Reviewed-by: mcimadamore, ihse ------------- PR: https://git.openjdk.java.net/jdk/pull/8193 From ihse at openjdk.java.net Thu Apr 14 16:12:27 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 14 Apr 2022 16:12:27 GMT Subject: RFR: 8284891: Fix typos in build system files Message-ID: <48sHX_PTeLN0flIYI_TiwTd3gsE3QGm3xw_iaoA6mTU=.2efe1eea-0398-43ca-ad71-3ce4671c0ffe@github.com> I ran `codespell` on the `make` directory, and accepted those changes where it indeed discovered real typos. (Due to false positives this can unfortunately not be run automatically) Most of the fixes are in comments. A few are in messages aimed at the user. ------------- Commit messages: - 8284891: Fix typos in build system files Changes: https://git.openjdk.java.net/jdk/pull/8246/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8246&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8284891 Stats: 72 lines in 46 files changed: 0 ins; 0 del; 72 mod Patch: https://git.openjdk.java.net/jdk/pull/8246.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8246/head:pull/8246 PR: https://git.openjdk.java.net/jdk/pull/8246 From erikj at openjdk.java.net Thu Apr 14 16:29:40 2022 From: erikj at openjdk.java.net (Erik Joelsson) Date: Thu, 14 Apr 2022 16:29:40 GMT Subject: RFR: 8284891: Fix typos in build system files In-Reply-To: <48sHX_PTeLN0flIYI_TiwTd3gsE3QGm3xw_iaoA6mTU=.2efe1eea-0398-43ca-ad71-3ce4671c0ffe@github.com> References: <48sHX_PTeLN0flIYI_TiwTd3gsE3QGm3xw_iaoA6mTU=.2efe1eea-0398-43ca-ad71-3ce4671c0ffe@github.com> Message-ID: On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on the `make` directory, and accepted those changes where it indeed discovered real typos. > > (Due to false positives this can unfortunately not be run automatically) > > Most of the fixes are in comments. A few are in messages aimed at the user. Marked as reviewed by erikj (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/8246 From ihse at openjdk.java.net Thu Apr 14 19:37:33 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 14 Apr 2022 19:37:33 GMT Subject: Integrated: 8284891: Fix typos in build system files In-Reply-To: <48sHX_PTeLN0flIYI_TiwTd3gsE3QGm3xw_iaoA6mTU=.2efe1eea-0398-43ca-ad71-3ce4671c0ffe@github.com> References: <48sHX_PTeLN0flIYI_TiwTd3gsE3QGm3xw_iaoA6mTU=.2efe1eea-0398-43ca-ad71-3ce4671c0ffe@github.com> Message-ID: <2mF5V7umZUZe-exsy8TAj69oQs5CZ1A41lGknDaoNVc=.bf65fd9f-8851-4626-8bd1-6f23fef1e945@github.com> On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on the `make` directory, and accepted those changes where it indeed discovered real typos. > > (Due to false positives this can unfortunately not be run automatically) > > Most of the fixes are in comments. A few are in messages aimed at the user. This pull request has now been integrated. Changeset: 160eb2bd Author: Magnus Ihse Bursie URL: https://git.openjdk.java.net/jdk/commit/160eb2bd392fea29dd690ee9781174d14dc0b659 Stats: 72 lines in 46 files changed: 0 ins; 0 del; 72 mod 8284891: Fix typos in build system files Reviewed-by: erikj ------------- PR: https://git.openjdk.java.net/jdk/pull/8246