From magnus.ihse.bursie at oracle.com Mon Aug 8 11:24:28 2022 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Mon, 8 Aug 2022 13:24:28 +0200 Subject: VS Code plugin for OpenJDK development In-Reply-To: References: <2abb3bc0-5f1e-4b66-3617-4e3672647a00@oracle.com> Message-ID: <93ce05f2-6e98-8e34-e929-5073af9c060d@oracle.com> On 2022-07-29 19:49, Guoxiong Li wrote: > Hi Magnus, > > I tried your plugin these?days. It is a good idea to integrate the > github/JBS events into the ide. > So I want to port the similar feature to the plugin of IntelliJ IDEA [1]. > What do you think about it? It is certainly nice to have access to github from the IDE. But this does not sound like it belongs in the jtreg plugin, so I think you'd better create a new plugin for this. And "porting" is perhaps being used very generously here, I assume you need to write a completely new plugin for IDEA, but with similar functionality. But go ahead and shamelessly copy all ideas you liked from my plugin! /Magnus > > [1] https://github.com/openjdk/jtreg/tree/master/plugins/idea > > Best Regards, > -- Guoxiong From lgxbslgx at gmail.com Mon Aug 8 20:41:39 2022 From: lgxbslgx at gmail.com (Guoxiong Li) Date: Tue, 9 Aug 2022 04:41:39 +0800 Subject: VS Code plugin for OpenJDK development In-Reply-To: <93ce05f2-6e98-8e34-e929-5073af9c060d@oracle.com> References: <2abb3bc0-5f1e-4b66-3617-4e3672647a00@oracle.com> <93ce05f2-6e98-8e34-e929-5073af9c060d@oracle.com> Message-ID: Hi Magnus, Thanks for your reply. It is certainly nice to have access to github from the IDE. But this > does not sound like it belongs in the jtreg plugin, so I think you'd > better create a new plugin for this. Considering the features don't belong to the jtreg plugin, my previous proposal is not good enough to start. And I don't want to create a new plugin for it now. > And "porting" is perhaps being used > very generously here, I assume you need to write a completely new plugin > for IDEA, but with similar functionality. But go ahead and shamelessly > copy all ideas you liked from my plugin! > I apologize if my previous proposal offended you. Best Regards, -- Guoxiong -------------- next part -------------- An HTML attachment was scrubbed... URL: From magnus.ihse.bursie at oracle.com Tue Aug 9 11:40:41 2022 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 9 Aug 2022 13:40:41 +0200 Subject: VS Code plugin for OpenJDK development In-Reply-To: References: <2abb3bc0-5f1e-4b66-3617-4e3672647a00@oracle.com> <93ce05f2-6e98-8e34-e929-5073af9c060d@oracle.com> Message-ID: On 2022-08-08 22:41, Guoxiong Li wrote: > Hi Magnus, > > Thanks for your reply. > > It is certainly nice to have access to github from the IDE. But this > does not sound like it belongs in the jtreg plugin, so I think you'd > better create a new plugin for this. > > > Considering the features don't belong to the jtreg plugin, my previous > proposal > is not good enough to start. And I don't want to create a new plugin > for it now. > > And "porting" is perhaps being used > very generously here, I assume you need to write a completely new > plugin > for IDEA, but with similar functionality. But go ahead and shamelessly > copy all ideas you liked from my plugin! > > > I apologize if my previous proposal offended you. I think there is some misunderstanding here. Your proposal do not offend me. In the end, the maintainers of the jtreg idea plugin will need to decide what functionality belongs there. I just said what I was thinking, but I don't have anything to do with the idea plugin. /Magnus > > Best Regards, > -- Guoxiong -------------- next part -------------- An HTML attachment was scrubbed... URL: