From duke at openjdk.java.net Fri Jan 14 13:51:42 2022 From: duke at openjdk.java.net (Daniel Jelinski) Date: Fri, 14 Jan 2022 13:51:42 GMT Subject: RFR: 8258240: make vscode-project on Windows generates jdk.code-workspace file with unescaped '\' in paths Message-ID: Backslashes in `sed` replacement string are interpreted by `sed`. In order to output the strings we want, the replacement text needs to be escaped again. See https://stackoverflow.com/a/2705678 Verified that with this patch VSCode is able to open the workspace, and all files are visible in "Explorer". ------------- Commit messages: - Escape SED replacement string Changes: https://git.openjdk.java.net/jdk/pull/7083/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7083&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258240 Stats: 15 lines in 1 file changed: 7 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk/pull/7083.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7083/head:pull/7083 PR: https://git.openjdk.java.net/jdk/pull/7083 From erikj at openjdk.java.net Fri Jan 14 14:35:28 2022 From: erikj at openjdk.java.net (Erik Joelsson) Date: Fri, 14 Jan 2022 14:35:28 GMT Subject: RFR: 8258240: make vscode-project on Windows generates jdk.code-workspace file with unescaped '\' in paths In-Reply-To: References: Message-ID: <_ChRC4LbPyh6n41HU6Wnz0oso7awQv-Iyh317MrOQ_I=.f418748d-b636-4186-b24e-7ab986496f07@github.com> On Fri, 14 Jan 2022 13:45:51 GMT, Daniel Jelinski wrote: > Backslashes in `sed` replacement string are interpreted by `sed`. In order to output the strings we want, the replacement text needs to be escaped again. See https://stackoverflow.com/a/2705678 > > Verified that with this patch VSCode is able to open the workspace, and all files are visible in "Explorer". Looks good! ------------- Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7083 From duke at openjdk.java.net Wed Jan 19 13:19:29 2022 From: duke at openjdk.java.net (Daniel Jelinski) Date: Wed, 19 Jan 2022 13:19:29 GMT Subject: RFR: 8258240: make vscode-project on Windows generates jdk.code-workspace file with unescaped '\' in paths In-Reply-To: <_ChRC4LbPyh6n41HU6Wnz0oso7awQv-Iyh317MrOQ_I=.f418748d-b636-4186-b24e-7ab986496f07@github.com> References: <_ChRC4LbPyh6n41HU6Wnz0oso7awQv-Iyh317MrOQ_I=.f418748d-b636-4186-b24e-7ab986496f07@github.com> Message-ID: <3kmMEJOmEEUUr6_nCqNK20xee4Z3eeofHd-AWsEkwjs=.0db9b1d1-3eba-4b0c-a2ff-dc354d281f39@github.com> On Fri, 14 Jan 2022 14:32:00 GMT, Erik Joelsson wrote: >> Backslashes in `sed` replacement string are interpreted by `sed`. In order to output the strings we want, the replacement text needs to be escaped again. See https://stackoverflow.com/a/2705678 >> >> Verified that with this patch VSCode is able to open the workspace, and all files are visible in "Explorer". > > Looks good! Thanks @erikj79 for reviewing this. Could you sponsor? ------------- PR: https://git.openjdk.java.net/jdk/pull/7083 From duke at openjdk.java.net Wed Jan 19 14:21:33 2022 From: duke at openjdk.java.net (Daniel Jelinski) Date: Wed, 19 Jan 2022 14:21:33 GMT Subject: Integrated: 8258240: make vscode-project on Windows generates jdk.code-workspace file with unescaped '\' in paths In-Reply-To: References: Message-ID: On Fri, 14 Jan 2022 13:45:51 GMT, Daniel Jelinski wrote: > Backslashes in `sed` replacement string are interpreted by `sed`. In order to output the strings we want, the replacement text needs to be escaped again. See https://stackoverflow.com/a/2705678 > > Verified that with this patch VSCode is able to open the workspace, and all files are visible in "Explorer". This pull request has now been integrated. Changeset: b20b11cf Author: Daniel Jelinski Committer: Erik Joelsson URL: https://git.openjdk.java.net/jdk/commit/b20b11cf8215238e5cd51a1d3a331d5cbfdad710 Stats: 15 lines in 1 file changed: 7 ins; 0 del; 8 mod 8258240: make vscode-project on Windows generates jdk.code-workspace file with unescaped '\' in paths Reviewed-by: erikj ------------- PR: https://git.openjdk.java.net/jdk/pull/7083