RFR: 8297041: Remove the last remnants of sjavac

Jonathan Gibbons jjg at openjdk.org
Wed Nov 16 17:56:13 UTC 2022


On Wed, 16 Nov 2022 13:22:43 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> The sjavac ("smart javac") was an ambitious project. It should parallelize java compilation, create a background daemon process that kept the JVM "hot" with the JITted javac code, define a public api so only noticeable changes in a class caused further dependency compilations, etc etc.
> 
> Some of this never came to fruition. Other were implemented differently, as the `depend` plugin. The only thing we're currently using (and have been for the last few years) is the "server" functionality, that is, the ability to keep a single JVM process alive, and reuse the JITted code.
> 
> This code does not belong in the jdk.compiler module. It is a buildtool, pure and simple. Let's move it to it's proper place.

make/langtools/tools/javacserver/comp/SjavacImpl.java line 36:

> 34: import java.io.PrintWriter;
> 35: import java.io.StringWriter;
> 36: import java.util.stream.Stream;

This is a build tool, so you get to set the guidelines, but generally, this is an unusual order for imports

make/langtools/tools/javacserver/comp/SjavacImpl.java line 47:

> 45:  *  deletion without notice.</b>
> 46:  */
> 47: public class SjavacImpl implements Sjavac {

... so it looks like there are still some vestiges of `Sjavac` ...

-------------

PR: https://git.openjdk.org/jdk/pull/11185


More information about the ide-support-dev mailing list