From kopp.dev at gmail.com Mon Oct 17 11:11:43 2022 From: kopp.dev at gmail.com (Oliver Kopp) Date: Mon, 17 Oct 2022 13:11:43 +0200 Subject: Configuration for IntelliJ - jdk.link Message-ID: Hey, Thank you for providing the "IDE Tooling & Support Group" ( https://wiki.openjdk.org/display/IDESupport/Main). I trying to finalize my first contribution on OpenJDK (https://github.com/openjdk/jdk/pull/10704) and I am struggling with the tests. I did not find much information on using IntelliJ with OpenJDK. I tried "bin/idea.sh -v jdk.link", restarted IntelliJ. However, "test/jdk/tools/jlink" doesn't seem to be marked as test sources. Is there anything more to do to get "jdk.link" being properly loadable in IntelliJ? Minor things: - Could you link https://github.com/openjdk/jdk/blob/master/doc/ide.md from https://wiki.openjdk.org/display/IDESupport/Main somehow? I found that page only by accident. - https://github.com/openjdk/jtreg/tree/master/plugins/idea should be linked from https://openjdk.org/jtreg/intellij-plugin.html as the former seems to be more recent. Cheers, Oliver -------------- next part -------------- An HTML attachment was scrubbed... URL: From jwaters at openjdk.org Tue Oct 25 14:09:27 2022 From: jwaters at openjdk.org (Julian Waters) Date: Tue, 25 Oct 2022 14:09:27 GMT Subject: RFR: 8295884: Support for development with the Eclipse IDE Message-ID: Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. Indexing capabilities utilizing the enhancement: java escape ------------- Commit messages: - Formatting - Whitespace - Carriage Returns - Documentation - Implement Eclipse support Changes: https://git.openjdk.org/jdk/pull/10853/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295884 Stats: 448 lines in 4 files changed: 448 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10853.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853 PR: https://git.openjdk.org/jdk/pull/10853 From erikj at openjdk.org Tue Oct 25 22:19:53 2022 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 25 Oct 2022 22:19:53 GMT Subject: RFR: 8295884: Support for development with the Eclipse IDE In-Reply-To: References: Message-ID: <-460jAwuO1LachCE8nAzm_UsCGX8gyEH5kiU9ZnYSF0=.48af2d71-7e11-4692-88b6-c3fc009df04e@github.com> On Tue, 25 Oct 2022 13:23:34 GMT, Julian Waters wrote: > Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. > > This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. > > Indexing capabilities utilizing the enhancement: > java > escape This looks like nice work. I'm curious how does this eclipse project figures out preprocessor settings like -D flags from the build to correctly setup the environment for the native code? I know this was a major deal when creating the compile-commands.json for other native IDE integrations. I've heard some IDEs just run the build once and inspect the command lines, but our default log level won't show that. I'm not familiar with eclipse project files, but I couldn't really see anything here that addressed this issue. Can you work with the native code in a meaningful way without it? make/ide/eclipse/CreateWorkspace.gmk line 79: > 77: $(patsubst $(TOPDIR)/%,%,$(call FindModuleNativeDirs, $(module))))) > 78: > 79: EmitEmptyLine = $(file >> $(1),) Note that using the file macro requires GNU make >=4.0. You probably want to document this requirement and add a fast fail if it's not fulfilled. ------------- PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Wed Oct 26 10:03:00 2022 From: jwaters at openjdk.org (Julian Waters) Date: Wed, 26 Oct 2022 10:03:00 GMT Subject: RFR: 8295884: Support for development with the Eclipse IDE In-Reply-To: <-460jAwuO1LachCE8nAzm_UsCGX8gyEH5kiU9ZnYSF0=.48af2d71-7e11-4692-88b6-c3fc009df04e@github.com> References: <-460jAwuO1LachCE8nAzm_UsCGX8gyEH5kiU9ZnYSF0=.48af2d71-7e11-4692-88b6-c3fc009df04e@github.com> Message-ID: On Tue, 25 Oct 2022 22:17:25 GMT, Erik Joelsson wrote: > This looks like nice work. > > I'm curious how does this eclipse project figures out preprocessor settings like -D flags from the build to correctly setup the environment for the native code? I know this was a major deal when creating the compile-commands.json for other native IDE integrations. I've heard some IDEs just run the build once and inspect the command lines, but our default log level won't show that. I'm not familiar with eclipse project files, but I couldn't really see anything here that addressed this issue. Can you work with the native code in a meaningful way without it? You're right, it seems I forgot to also include the preprocessor defines in the generated workspace :P I'll add them in the next commit, thanks for catching that. Eclipse does work very well with native code even without those defines and flags from the build for the most part though, just that utilities which require them (For instance something like PRODUCT_ONLY and NOT_PRODUCT in HotSpot) wouldn't properly work with the indexer, which would be annoying, but it's more of a mild inconvenience than anything. > make/ide/eclipse/CreateWorkspace.gmk line 79: > >> 77: $(patsubst $(TOPDIR)/%,%,$(call FindModuleNativeDirs, $(module))))) >> 78: >> 79: EmitEmptyLine = $(file >> $(1),) > > Note that using the file macro requires GNU make >=4.0. You probably want to document this requirement and add a fast fail if it's not fulfilled. I think it would be better if I looked for something that the make system already has and used that instead of something that's tied to a specific version and GNU specific now that I'm revisiting this, thanks for the catch ------------- PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Wed Oct 26 10:07:12 2022 From: jwaters at openjdk.org (Julian Waters) Date: Wed, 26 Oct 2022 10:07:12 GMT Subject: RFR: 8295884: Support for development with the Eclipse IDE [v2] In-Reply-To: References: Message-ID: > Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. > > This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. > > Indexing capabilities utilizing the enhancement: > java > escape Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge - Formatting - Whitespace - Carriage Returns - Documentation - Implement Eclipse support ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10853/files - new: https://git.openjdk.org/jdk/pull/10853/files/a1d02f78..839db0b3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=00-01 Stats: 24760 lines in 318 files changed: 1044 ins; 23454 del; 262 mod Patch: https://git.openjdk.org/jdk/pull/10853.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853 PR: https://git.openjdk.org/jdk/pull/10853 From stuefe at openjdk.org Wed Oct 26 10:17:24 2022 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 26 Oct 2022 10:17:24 GMT Subject: RFR: 8295884: Support for development with the Eclipse IDE [v2] In-Reply-To: References: Message-ID: On Wed, 26 Oct 2022 10:07:12 GMT, Julian Waters wrote: >> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. >> >> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. >> >> Indexing capabilities utilizing the enhancement: >> java >> escape > > Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge > - Formatting > - Whitespace > - Carriage Returns > - Documentation > - Implement Eclipse support Will this work with jtreg test sources too? At least on Intellij those require a brittle intellij plugin. ------------- PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Wed Oct 26 10:58:38 2022 From: jwaters at openjdk.org (Julian Waters) Date: Wed, 26 Oct 2022 10:58:38 GMT Subject: RFR: 8295884: Support for development with the Eclipse IDE [v3] In-Reply-To: References: Message-ID: > Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. > > This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. > > Indexing capabilities utilizing the enhancement: > java > escape Julian Waters has updated the pull request incrementally with one additional commit since the last revision: File operations should use MakeIO.gmk ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10853/files - new: https://git.openjdk.org/jdk/pull/10853/files/839db0b3..42278c7b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=01-02 Stats: 105 lines in 4 files changed: 1 ins; 0 del; 104 mod Patch: https://git.openjdk.org/jdk/pull/10853.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853 PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Wed Oct 26 11:13:29 2022 From: jwaters at openjdk.org (Julian Waters) Date: Wed, 26 Oct 2022 11:13:29 GMT Subject: RFR: 8295884: Support for development with the Eclipse IDE [v4] In-Reply-To: References: Message-ID: <4bGbNcXekWWFkvB0Or2sm87EWYQcLxE6H2IvgzZ6HEA=.18961eeb-3174-4966-95de-a75fc91832c9@github.com> > Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. > > This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. > > Indexing capabilities utilizing the enhancement: > java > escape Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Squash issue with commas ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10853/files - new: https://git.openjdk.org/jdk/pull/10853/files/42278c7b..58913981 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=02-03 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/10853.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853 PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Wed Oct 26 14:29:23 2022 From: jwaters at openjdk.org (Julian Waters) Date: Wed, 26 Oct 2022 14:29:23 GMT Subject: RFR: 8295884: Support for development with the Eclipse IDE [v2] In-Reply-To: References: Message-ID: On Wed, 26 Oct 2022 10:15:10 GMT, Thomas Stuefe wrote: > Will this work with jtreg test sources too? At least on Intellij those require a brittle intellij plugin. I didn't think of adding them to the indexing list if you're referring to the code in the /test/ directory, but I can do that if that's necessary. So long as they're able to be built using make (doesn't matter which Makefile they use), Eclipse shouldn't have much of an issue with them when it comes to compiling them, or require extra/special support to work properly ------------- PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Thu Oct 27 02:32:44 2022 From: jwaters at openjdk.org (Julian Waters) Date: Thu, 27 Oct 2022 02:32:44 GMT Subject: RFR: 8295884: Implement IDE support for Eclipse [v5] In-Reply-To: References: Message-ID: > Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. > > This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. > > Indexing capabilities utilizing the enhancement: > java > escape Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: - Merge - Squash issue with commas - File operations should use MakeIO.gmk - Merge - Formatting - Whitespace - Carriage Returns - Documentation - Implement Eclipse support ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10853/files - new: https://git.openjdk.org/jdk/pull/10853/files/58913981..d35062e1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=03-04 Stats: 580 lines in 31 files changed: 264 ins; 168 del; 148 mod Patch: https://git.openjdk.org/jdk/pull/10853.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853 PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Thu Oct 27 02:53:23 2022 From: jwaters at openjdk.org (Julian Waters) Date: Thu, 27 Oct 2022 02:53:23 GMT Subject: RFR: 8295884: Implement IDE support for Eclipse [v5] In-Reply-To: References: <-460jAwuO1LachCE8nAzm_UsCGX8gyEH5kiU9ZnYSF0=.48af2d71-7e11-4692-88b6-c3fc009df04e@github.com> Message-ID: On Wed, 26 Oct 2022 09:59:13 GMT, Julian Waters wrote: > I've heard some IDEs just run the build once and inspect the command lines, but our default log level won't show that. I also forgot to mention that CDT does come with an integrated Build Output Parser that can do just that, but I do want to avoid using it, if possible, since it's much more convenient to be able to start working on code the moment configure completes instead of having to wait for the build to finish once ------------- PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Thu Oct 27 03:34:45 2022 From: jwaters at openjdk.org (Julian Waters) Date: Thu, 27 Oct 2022 03:34:45 GMT Subject: RFR: 8295884: Implement IDE support for Eclipse [v6] In-Reply-To: References: Message-ID: > Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. > > This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. > > Indexing capabilities utilizing the enhancement: > java > escape Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Prevent Eclipse from automatically attaching binary parsers to workspaces including native code ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10853/files - new: https://git.openjdk.org/jdk/pull/10853/files/d35062e1..2dca7cae Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=04-05 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10853.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853 PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Thu Oct 27 05:13:36 2022 From: jwaters at openjdk.org (Julian Waters) Date: Thu, 27 Oct 2022 05:13:36 GMT Subject: RFR: 8295884: Implement IDE support for Eclipse [v7] In-Reply-To: References: Message-ID: > Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. > > This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. > > Indexing capabilities utilizing the enhancement: > java > escape Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Initial support for Language Settings Providers ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10853/files - new: https://git.openjdk.org/jdk/pull/10853/files/2dca7cae..8402431e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=05-06 Stats: 96 lines in 1 file changed: 85 ins; 3 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/10853.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853 PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Thu Oct 27 05:16:40 2022 From: jwaters at openjdk.org (Julian Waters) Date: Thu, 27 Oct 2022 05:16:40 GMT Subject: RFR: 8295884: Implement IDE support for Eclipse [v8] In-Reply-To: References: Message-ID: > Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. > > This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. > > Indexing capabilities utilizing the enhancement: > java > escape Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Nuke accidental comment not meant to be added ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10853/files - new: https://git.openjdk.org/jdk/pull/10853/files/8402431e..e6674919 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=07 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=06-07 Stats: 27 lines in 1 file changed: 0 ins; 27 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10853.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853 PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Thu Oct 27 05:28:44 2022 From: jwaters at openjdk.org (Julian Waters) Date: Thu, 27 Oct 2022 05:28:44 GMT Subject: RFR: 8295884: Implement IDE support for Eclipse [v9] In-Reply-To: References: Message-ID: > Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. > > This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. > > Indexing capabilities utilizing the enhancement: > java > escape Julian Waters has updated the pull request incrementally with one additional commit since the last revision: SINGLE_DOLLAR is not required ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10853/files - new: https://git.openjdk.org/jdk/pull/10853/files/e6674919..4e468aad Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=08 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=07-08 Stats: 10 lines in 1 file changed: 0 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/10853.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853 PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Thu Oct 27 06:59:31 2022 From: jwaters at openjdk.org (Julian Waters) Date: Thu, 27 Oct 2022 06:59:31 GMT Subject: RFR: 8295884: Implement IDE support for Eclipse [v10] In-Reply-To: References: Message-ID: > Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. > > This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. > > Indexing capabilities utilizing the enhancement: > java > escape Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Include extra directories required by HotSpot in HotSpot only workspaces ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10853/files - new: https://git.openjdk.org/jdk/pull/10853/files/4e468aad..2a591cb5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=09 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=08-09 Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/10853.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853 PR: https://git.openjdk.org/jdk/pull/10853 From jwaters at openjdk.org Sat Oct 29 07:37:38 2022 From: jwaters at openjdk.org (Julian Waters) Date: Sat, 29 Oct 2022 07:37:38 GMT Subject: RFR: 8295884: Implement IDE support for Eclipse [v11] In-Reply-To: References: Message-ID: > Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make and Ant integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK. > > This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the JVM's sources, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory. > > Indexing capabilities utilizing the enhancement: > java > escape Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision: - Merge remote-tracking branch 'upstream/master' into eclipse - Include extra directories required by HotSpot in HotSpot only workspaces - SINGLE_DOLLAR is not required - Nuke accidental comment not meant to be added - Initial support for Language Settings Providers - Prevent Eclipse from automatically attaching binary parsers to workspaces including native code - Merge - Squash issue with commas - File operations should use MakeIO.gmk - Merge - ... and 5 more: https://git.openjdk.org/jdk/compare/4732a8f7...90a7d061 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10853/files - new: https://git.openjdk.org/jdk/pull/10853/files/2a591cb5..90a7d061 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=10 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=09-10 Stats: 1353 lines in 72 files changed: 975 ins; 174 del; 204 mod Patch: https://git.openjdk.org/jdk/pull/10853.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853 PR: https://git.openjdk.org/jdk/pull/10853 From christianokafor247 at gmail.com Wed Oct 26 03:12:38 2022 From: christianokafor247 at gmail.com (Christian Okafor) Date: Wed, 26 Oct 2022 03:12:38 -0000 Subject: No subject Message-ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: