From jpai at openjdk.org  Fri Jul 14 07:41:38 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Fri, 14 Jul 2023 07:41:38 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option
Message-ID: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>

Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.

As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.

Additionally, this PR also cleans up one such usage that I found in the JDK code.

`tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.

-------------

Commit messages:
 - update copyright year
 - Remove reference from netbeans build.xml
 - deprecate for removal -Xnoagent

Changes: https://git.openjdk.org/jdk/pull/14882/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14882&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8312072
  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/14882.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14882/head:pull/14882

PR: https://git.openjdk.org/jdk/pull/14882

From alanb at openjdk.org  Fri Jul 14 08:23:25 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Fri, 14 Jul 2023 08:23:25 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option
In-Reply-To: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
Message-ID: <T9bgxFbncyMtTsVr-UGRmvWcXL-BFYMTgg94LNb8g80=.f30afc27-47ae-476b-a5a1-75306c9cf615@github.com>

On Fri, 14 Jul 2023 07:34:03 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
> 
> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
> 
> Additionally, this PR also cleans up one such usage that I found in the JDK code.
> 
> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.

The debugger agent in Classic VM was sun.tools.agent.Agent, pre-dates JPDA. I think -Xnoagent was the option to turn it off, like the equivalent of -Xdebugport=-1. Ancient history now, hasn't been needed in 20+ years. I suppose it is baked in some old scripts so printing a warning before its removal is good. We should be able to remove it from our tests too, looks like there are some left overs in test/hotspot/jtreg/vmTestbase/nsk/jdi.

The changes makes me wonder if we should do the same for -Xdebug.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14882#issuecomment-1635486207

From jpai at openjdk.org  Fri Jul 14 08:55:14 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Fri, 14 Jul 2023 08:55:14 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option
In-Reply-To: <T9bgxFbncyMtTsVr-UGRmvWcXL-BFYMTgg94LNb8g80=.f30afc27-47ae-476b-a5a1-75306c9cf615@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
 <T9bgxFbncyMtTsVr-UGRmvWcXL-BFYMTgg94LNb8g80=.f30afc27-47ae-476b-a5a1-75306c9cf615@github.com>
Message-ID: <o4zBykkuKR-PsnV5G4ZOi5dRbu3vVJi4V1sUns-P7rs=.3e54fa55-5cf6-4613-8ce0-705a33018bb7@github.com>

On Fri, 14 Jul 2023 08:19:54 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> We should be able to remove it from our tests too, looks like there are some left overs in test/hotspot/jtreg/vmTestbase/nsk/jdi.

I had noticed those but wasn't sure if they should be included in this change. I'll remove them and run some tests and see how it goes.

> The changes makes me wonder if we should do the same for -Xdebug.

I had a quick look now and it looks like it's just being set and then ignored if `-Xdebug` is passed. There's an accessor method to get the set value but I don't see it being used anywhere. Plus, the comment where `-Xdebug` is handled states:
>     } else if (match_option(option, "-Xdebug")) {
>      // note this flag has been used, then ignore

Would you want me to include the deprecation (for removal) for that option in this same PR or should we do that separately?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14882#issuecomment-1635527599

From alanb at openjdk.org  Fri Jul 14 10:20:10 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Fri, 14 Jul 2023 10:20:10 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option
In-Reply-To: <o4zBykkuKR-PsnV5G4ZOi5dRbu3vVJi4V1sUns-P7rs=.3e54fa55-5cf6-4613-8ce0-705a33018bb7@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
 <T9bgxFbncyMtTsVr-UGRmvWcXL-BFYMTgg94LNb8g80=.f30afc27-47ae-476b-a5a1-75306c9cf615@github.com>
 <o4zBykkuKR-PsnV5G4ZOi5dRbu3vVJi4V1sUns-P7rs=.3e54fa55-5cf6-4613-8ce0-705a33018bb7@github.com>
Message-ID: <ghJxkRjXpYngDxhPK6hU779miyWZHC5RqDgrhxdWuKg=.c7054395-5fc2-4e42-abb2-22e093740fed@github.com>

On Fri, 14 Jul 2023 08:52:06 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Would you want me to include the deprecation (for removal) for that option in this same PR or should we do that separately?

It can be looked at separately, my comment was just pointing out another legacy option that probably should have been removed a long time ago. It's probably hard to get data on usages in scripts but my guess is that -Xdebug is in a lot more scripts, even if it hasn't done anything for many years.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14882#issuecomment-1635640098

From jpai at openjdk.org  Sat Jul 15 00:58:02 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Sat, 15 Jul 2023 00:58:02 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option [v2]
In-Reply-To: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
Message-ID: <foeeIbyyrYi8o5Oe7baxm002tqtpoMS_nd8kag-NLxk=.fd312ebc-8697-4890-9e29-deab37f08eb3@github.com>

> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
> 
> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
> 
> Additionally, this PR also cleans up one such usage that I found in the JDK code.
> 
> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  Remove references to -Xnoagent from tests

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14882/files
  - new: https://git.openjdk.org/jdk/pull/14882/files/499e7061..71df3079

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14882&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14882&range=00-01

  Stats: 20 lines in 10 files changed: 0 ins; 0 del; 20 mod
  Patch: https://git.openjdk.org/jdk/pull/14882.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14882/head:pull/14882

PR: https://git.openjdk.org/jdk/pull/14882

From jpai at openjdk.org  Sat Jul 15 00:58:43 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Sat, 15 Jul 2023 00:58:43 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option
In-Reply-To: <o4zBykkuKR-PsnV5G4ZOi5dRbu3vVJi4V1sUns-P7rs=.3e54fa55-5cf6-4613-8ce0-705a33018bb7@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
 <T9bgxFbncyMtTsVr-UGRmvWcXL-BFYMTgg94LNb8g80=.f30afc27-47ae-476b-a5a1-75306c9cf615@github.com>
 <o4zBykkuKR-PsnV5G4ZOi5dRbu3vVJi4V1sUns-P7rs=.3e54fa55-5cf6-4613-8ce0-705a33018bb7@github.com>
Message-ID: <CZHHxLVrhkSptNynKqzG1Xg0oU3Ks5AdBIOOMHnQUnc=.d2195291-f3e9-452b-89ee-78605d794972@github.com>

On Fri, 14 Jul 2023 08:52:06 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> We should be able to remove it from our tests too, looks like there are some left overs in test/hotspot/jtreg/vmTestbase/nsk/jdi.

I've now updated the PR to remove references to `-Xnoagent` from these tests. 

There's a `TestNullTerminatedFlags` which uses this option. I haven't changed that test given the nature of that test and the fact that this `-Xnoagent` is currently still an accepted command line option.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14882#issuecomment-1636596306

From alanb at openjdk.org  Sun Jul 16 06:22:24 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Sun, 16 Jul 2023 06:22:24 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option [v2]
In-Reply-To: <foeeIbyyrYi8o5Oe7baxm002tqtpoMS_nd8kag-NLxk=.fd312ebc-8697-4890-9e29-deab37f08eb3@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
 <foeeIbyyrYi8o5Oe7baxm002tqtpoMS_nd8kag-NLxk=.fd312ebc-8697-4890-9e29-deab37f08eb3@github.com>
Message-ID: <w-NVcnxabjPk1ZAJ4x_vgKA1hB1CUuMuJyDyn60hLlQ=.321cafac-03ca-41ae-b06c-7801dd0e94c6@github.com>

On Sat, 15 Jul 2023 00:58:02 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
>> 
>> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
>> 
>> Additionally, this PR also cleans up one such usage that I found in the JDK code.
>> 
>> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove references to -Xnoagent from tests

Marked as reviewed by alanb (Reviewer).

make/ide/netbeans/langtools/build.xml line 245:

> 243:                 <property
> 244:                     name="@{jpda.jvmargs.property}"
> 245:                     value="-Xdebug -Djava.compiler=none -Xrunjdwp:transport=dt_socket,address=${jpda.address}"

Maybe -Djava.compiler=none should be removed too. I don't know if this project file is still used but I assume attempting to debug will print a warning due to this option.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14882#pullrequestreview-1531665623
PR Review Comment: https://git.openjdk.org/jdk/pull/14882#discussion_r1264615868

From jpai at openjdk.org  Sun Jul 16 06:34:46 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Sun, 16 Jul 2023 06:34:46 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option [v3]
In-Reply-To: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
Message-ID: <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>

> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
> 
> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
> 
> Additionally, this PR also cleans up one such usage that I found in the JDK code.
> 
> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  Remove -Djava.compiler=none

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14882/files
  - new: https://git.openjdk.org/jdk/pull/14882/files/71df3079..8254d8d8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14882&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14882&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14882.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14882/head:pull/14882

PR: https://git.openjdk.org/jdk/pull/14882

From cjplummer at openjdk.org  Sun Jul 16 21:25:16 2023
From: cjplummer at openjdk.org (Chris Plummer)
Date: Sun, 16 Jul 2023 21:25:16 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option [v3]
In-Reply-To: <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
 <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>
Message-ID: <t7sKcsaolD8vNfvUOmwwcTz32hlsXdYF2t9L_1Wz9os=.25596565-5f9a-452d-a63b-1fbbe181abcf@github.com>

On Sun, 16 Jul 2023 06:34:46 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
>> 
>> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
>> 
>> Additionally, this PR also cleans up one such usage that I found in the JDK code.
>> 
>> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove -Djava.compiler=none

I think `-Xdebug` is also a no-op now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14882#issuecomment-1637192959

From jpai at openjdk.org  Mon Jul 17 01:31:01 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Mon, 17 Jul 2023 01:31:01 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option [v3]
In-Reply-To: <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
 <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>
Message-ID: <-qikQHVPMvx70TXR2boxVjMamSNfK9_CRi9xQtwQ4_A=.316228b0-e925-4c2f-8b20-bfe95552d89c@github.com>

On Sun, 16 Jul 2023 06:34:46 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
>> 
>> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
>> 
>> Additionally, this PR also cleans up one such usage that I found in the JDK code.
>> 
>> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove -Djava.compiler=none

Hello Chris,

> I think `-Xdebug` is also a no-op now.

Yes, I'm preparing a separate JBS and PR to address that one.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14882#issuecomment-1637265830

From dholmes at openjdk.org  Mon Jul 17 02:51:22 2023
From: dholmes at openjdk.org (David Holmes)
Date: Mon, 17 Jul 2023 02:51:22 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option [v3]
In-Reply-To: <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
 <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>
Message-ID: <s6JT4UvCtzVlTQsVIB2YXoIRdIc4rwXF4mPNYZNfGTw=.bd5d30c1-679b-41be-a41b-eba9597e54a9@github.com>

On Sun, 16 Jul 2023 06:34:46 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
>> 
>> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
>> 
>> Additionally, this PR also cleans up one such usage that I found in the JDK code.
>> 
>> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove -Djava.compiler=none

This looks fine. What about all the ./src/demo/share/nbproject/jfc/*/nbproject/netbeans-targets.xml files? Will they get cleaned up when this option is actually removed?

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14882#pullrequestreview-1531867661

From dholmes at openjdk.org  Mon Jul 17 05:56:16 2023
From: dholmes at openjdk.org (David Holmes)
Date: Mon, 17 Jul 2023 05:56:16 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option [v3]
In-Reply-To: <s6JT4UvCtzVlTQsVIB2YXoIRdIc4rwXF4mPNYZNfGTw=.bd5d30c1-679b-41be-a41b-eba9597e54a9@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
 <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>
 <s6JT4UvCtzVlTQsVIB2YXoIRdIc4rwXF4mPNYZNfGTw=.bd5d30c1-679b-41be-a41b-eba9597e54a9@github.com>
Message-ID: <JbpCZ8MNoL_XRCIPPBCLLpQMwR5GmWU0TNH0Ns4J9lU=.c7bac51a-c133-4602-b509-633dd6a18639@github.com>

On Mon, 17 Jul 2023 02:47:55 GMT, David Holmes <dholmes at openjdk.org> wrote:

>  What about all the ./src/demo/share/nbproject/jfc/*/nbproject/netbeans-targets.xml files? 

Sorry @jaikiran  my repo branch was stale, these were actually cleanup just last week. :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14882#issuecomment-1637421321

From cjplummer at openjdk.org  Mon Jul 17 16:21:11 2023
From: cjplummer at openjdk.org (Chris Plummer)
Date: Mon, 17 Jul 2023 16:21:11 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option [v3]
In-Reply-To: <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
 <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>
Message-ID: <2hNtcPBGzTZH1BU0nHKSS2s4yF0Lz00egwbsW5OQ5oY=.436a9761-0ed5-4c31-ae60-949594691c08@github.com>

On Sun, 16 Jul 2023 06:34:46 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
>> 
>> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
>> 
>> Additionally, this PR also cleans up one such usage that I found in the JDK code.
>> 
>> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove -Djava.compiler=none

Marked as reviewed by cjplummer (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14882#pullrequestreview-1533170924

From jpai at openjdk.org  Tue Jul 18 01:42:13 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 18 Jul 2023 01:42:13 GMT
Subject: RFR: 8312072: Deprecate for removal the -Xnoagent option [v3]
In-Reply-To: <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
 <_E-NvG0IIDugT-fAj-Qctv9YQudrkEdLn305YMp7pik=.2f0bdeab-1a04-42d9-88d8-caa39ccdfc91@github.com>
Message-ID: <7HEEWh8V5_lb5xRfpXQ702sRWCIddmB9kuA_e4av9s8=.d3217be0-9416-4184-aea2-80ac4fa249f8@github.com>

On Sun, 16 Jul 2023 06:34:46 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
>> 
>> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
>> 
>> Additionally, this PR also cleans up one such usage that I found in the JDK code.
>> 
>> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove -Djava.compiler=none

Thank you everyone for the reviews. I think the current Reviews cover the necessary areas of hotspot-runtime and serviceability. So I'll go ahead with the integration later in the day today (3-4 hours from now).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14882#issuecomment-1639146443

From jpai at openjdk.org  Tue Jul 18 05:45:13 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 18 Jul 2023 05:45:13 GMT
Subject: Integrated: 8312072: Deprecate for removal the -Xnoagent option
In-Reply-To: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
References: <CB4SAmargCEJH52kV-wU6TRRkyOk0-QfnS8fNZXZFIM=.e78b138d-5f33-43b7-a538-1b1ebff4ecf5@github.com>
Message-ID: <-VOUWkpuX8BE5Ihh7ADsDtNGcrUt5MUEjhgyDHuJwu0=.feee33c7-c568-4023-bae3-3aad4b5cca13@github.com>

On Fri, 14 Jul 2023 07:34:03 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
> 
> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
> 
> Additionally, this PR also cleans up one such usage that I found in the JDK code.
> 
> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.

This pull request has now been integrated.

Changeset: 8ec136e6
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8ec136e6f0fa684255274181d09c86251ef5428f
Stats:     23 lines in 12 files changed: 0 ins; 0 del; 23 mod

8312072: Deprecate for removal the -Xnoagent option

Reviewed-by: alanb, dholmes, cjplummer

-------------

PR: https://git.openjdk.org/jdk/pull/14882

From jpai at openjdk.org  Tue Jul 18 07:06:30 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 18 Jul 2023 07:06:30 GMT
Subject: RFR: 8312151: Deprecate for removal the -Xdebug option
Message-ID: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>

Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312151?

As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.

A CSR has been drafted for this change https://bugs.openjdk.org/browse/JDK-8312216

-------------

Commit messages:
 - 8312151: Deprecate for removal the -Xdebug option

Changes: https://git.openjdk.org/jdk/pull/14918/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14918&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8312151
  Stats: 35 lines in 22 files changed: 0 ins; 8 del; 27 mod
  Patch: https://git.openjdk.org/jdk/pull/14918.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14918/head:pull/14918

PR: https://git.openjdk.org/jdk/pull/14918

From jpai at openjdk.org  Tue Jul 18 07:06:30 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 18 Jul 2023 07:06:30 GMT
Subject: RFR: 8312151: Deprecate for removal the -Xdebug option
In-Reply-To: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
Message-ID: <SHNFy0a2Vpx8Dehtonl37EhHjUwnITQ8a1OB9cleiqQ=.ce28a88c-931a-47a0-8ee0-4cbe898d5f22@github.com>

On Tue, 18 Jul 2023 06:59:52 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312151?
> 
> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
> 
> A CSR has been drafted for this change https://bugs.openjdk.org/browse/JDK-8312216

I would like inputs on the `test/hotspot/jtreg/runtime/6294277/SourceDebugExtension.java` test. That test launches `java` passing it the `-Xdebug` option and was introduced as part of https://bugs.openjdk.org/browse/JDK-6294277. `-Xdebug` has been a no-op for many releases now. Is this test still relevant and if not, should I go ahead and remove it as part of this change?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14918#issuecomment-1639615535

From jpai at openjdk.org  Tue Jul 18 07:36:12 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 18 Jul 2023 07:36:12 GMT
Subject: RFR: 8312151: Deprecate for removal the -Xdebug option [v2]
In-Reply-To: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
Message-ID: <z5LvzUYoNMyCK69hgJwPu3rauWolx3pfc4A8ZyE5mFk=.2c1fae6f-2fd3-4527-8398-9e45fe6eb68b@github.com>

> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312151?
> 
> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
> 
> A CSR has been drafted for this change https://bugs.openjdk.org/browse/JDK-8312216

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  update java man page for -Xdebug deprecation

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14918/files
  - new: https://git.openjdk.org/jdk/pull/14918/files/e165dc24..a8d472ad

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14918&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14918&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14918.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14918/head:pull/14918

PR: https://git.openjdk.org/jdk/pull/14918

From alanb at openjdk.org  Tue Jul 18 07:36:14 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Tue, 18 Jul 2023 07:36:14 GMT
Subject: RFR: 8312151: Deprecate for removal the -Xdebug option
In-Reply-To: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
Message-ID: <ot4CpQPVsamVaNUZE-zOheGbQNzyq64nsm3M-cj7i14=.d97d5f1b-e7b3-44f7-89a0-28c0b75ac0d8@github.com>

On Tue, 18 Jul 2023 06:59:52 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312151?
> 
> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
> 
> A CSR has been drafted for this change https://bugs.openjdk.org/browse/JDK-8312216

The launcher option -debug is an alias for -Xdebug so should be deprecated too. The history on these options goes back a long way, but obsolete since JDK 6 and the removal of JVMDI at least.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14918#issuecomment-1639660251

From jpai at openjdk.org  Tue Jul 18 07:58:58 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 18 Jul 2023 07:58:58 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v3]
In-Reply-To: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
Message-ID: <03lsUFJ5QhNnuzzLmwbwH0-nOhehHUQRWVxvRYwwCTs=.ab7157e2-b075-4a06-9a51-9d1484765995@github.com>

> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
> 
> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  include -debug (alias) option in the deprecated log message

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14918/files
  - new: https://git.openjdk.org/jdk/pull/14918/files/a8d472ad..e5472701

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14918&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14918&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14918.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14918/head:pull/14918

PR: https://git.openjdk.org/jdk/pull/14918

From jpai at openjdk.org  Tue Jul 18 08:11:04 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 18 Jul 2023 08:11:04 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v3]
In-Reply-To: <03lsUFJ5QhNnuzzLmwbwH0-nOhehHUQRWVxvRYwwCTs=.ab7157e2-b075-4a06-9a51-9d1484765995@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <03lsUFJ5QhNnuzzLmwbwH0-nOhehHUQRWVxvRYwwCTs=.ab7157e2-b075-4a06-9a51-9d1484765995@github.com>
Message-ID: <i2f3cbfD9csS_Vg4_N9zwsDHvaJtW_J8U1LZX0VFb-w=.2ec0daae-7d51-470c-8d34-32c41004b306@github.com>

On Tue, 18 Jul 2023 07:58:58 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>> 
>> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   include -debug (alias) option in the deprecated log message

Given that https://bugs.openjdk.org/browse/JDK-8227229 had more historical details about `-Xdebug` and `-debug`, I've updated this PR to link to that issue and also drafted CSR afresh https://bugs.openjdk.org/browse/JDK-8312220

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14918#issuecomment-1639725244

From alanb at openjdk.org  Tue Jul 18 11:04:18 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Tue, 18 Jul 2023 11:04:18 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v3]
In-Reply-To: <03lsUFJ5QhNnuzzLmwbwH0-nOhehHUQRWVxvRYwwCTs=.ab7157e2-b075-4a06-9a51-9d1484765995@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <03lsUFJ5QhNnuzzLmwbwH0-nOhehHUQRWVxvRYwwCTs=.ab7157e2-b075-4a06-9a51-9d1484765995@github.com>
Message-ID: <qyTiO48chZV5aiHXfyTfTvaTHpPZQzvLQlHpd05CF0w=.57037cf5-552b-448a-9ab4-f1a81f0d3881@github.com>

On Tue, 18 Jul 2023 07:58:58 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>> 
>> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   include -debug (alias) option in the deprecated log message

src/java.base/share/classes/sun/launcher/resources/launcher.properties line 137:

> 135: \    -Xcheck:jni       perform additional checks for JNI functions\n\
> 136: \    -Xcomp            forces compilation of methods on first invocation\n\
> 137: \    -Xdebug           deprecated and may be removed in a future release.\n\

This drops "does nothing" so no longer clear that the option doesn't do anything. It could be changed to "does nothing; deprecated for removal in a future release". Alternatively maybe it would be better to just remove it from the -X output.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14918#discussion_r1266609817

From jpai at openjdk.org  Tue Jul 18 12:41:32 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 18 Jul 2023 12:41:32 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v4]
In-Reply-To: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
Message-ID: <54o5-4Raq5oX93gQrI_hfTjwiLVJGWzSBmE8VtTvK9g=.cb4c9df8-6a17-473f-9f47-6747303ba8fe@github.com>

> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
> 
> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  Alan's suggestion for -Xdebug output

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14918/files
  - new: https://git.openjdk.org/jdk/pull/14918/files/e5472701..78498068

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14918&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14918&range=02-03

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/14918.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14918/head:pull/14918

PR: https://git.openjdk.org/jdk/pull/14918

From jpai at openjdk.org  Tue Jul 18 12:41:32 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Tue, 18 Jul 2023 12:41:32 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v3]
In-Reply-To: <qyTiO48chZV5aiHXfyTfTvaTHpPZQzvLQlHpd05CF0w=.57037cf5-552b-448a-9ab4-f1a81f0d3881@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <03lsUFJ5QhNnuzzLmwbwH0-nOhehHUQRWVxvRYwwCTs=.ab7157e2-b075-4a06-9a51-9d1484765995@github.com>
 <qyTiO48chZV5aiHXfyTfTvaTHpPZQzvLQlHpd05CF0w=.57037cf5-552b-448a-9ab4-f1a81f0d3881@github.com>
Message-ID: <U1FFkWs2jlPozd3MZqNkj8YRKD5HVP5dugcDK4M7hbk=.8445bbe0-fcb9-4586-8fbc-ab4197c66005@github.com>

On Tue, 18 Jul 2023 11:01:33 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   include -debug (alias) option in the deprecated log message
>
> src/java.base/share/classes/sun/launcher/resources/launcher.properties line 137:
> 
>> 135: \    -Xcheck:jni       perform additional checks for JNI functions\n\
>> 136: \    -Xcomp            forces compilation of methods on first invocation\n\
>> 137: \    -Xdebug           deprecated and may be removed in a future release.\n\
> 
> This drops "does nothing" so no longer clear that the option doesn't do anything. It could be changed to "does nothing; deprecated for removal in a future release". Alternatively maybe it would be better to just remove it from the -X output.

Hello Alan, I updated the PR to use your suggested wording. I thought it's of no harm to let it be present in the -X output until we actually remove it (soon).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14918#discussion_r1266705837

From alanb at openjdk.org  Tue Jul 18 16:56:15 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Tue, 18 Jul 2023 16:56:15 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v4]
In-Reply-To: <54o5-4Raq5oX93gQrI_hfTjwiLVJGWzSBmE8VtTvK9g=.cb4c9df8-6a17-473f-9f47-6747303ba8fe@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <54o5-4Raq5oX93gQrI_hfTjwiLVJGWzSBmE8VtTvK9g=.cb4c9df8-6a17-473f-9f47-6747303ba8fe@github.com>
Message-ID: <rUsdg41lf8zV6Xysblo1fq9RfMSHJKAFTy0mNq9GUUM=.fbb8e607-0959-4e21-8771-695a5a0bd320@github.com>

On Tue, 18 Jul 2023 12:41:32 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>> 
>> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alan's suggestion for -Xdebug output

I think ParseArguments (in libjli/java.c) could be changed so that it doesn't translate -debug to -Xdebug, instead it can print a warning, like it does for -Xfuture. The reason is -debug is a java launcher option, it's not known to the VM and means that Arguments::parse_each_vm_init_arg doesn't need to mention -debug when it warns about -Xdebug.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14918#issuecomment-1640592323

From jpai at openjdk.org  Wed Jul 19 07:05:51 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 19 Jul 2023 07:05:51 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v5]
In-Reply-To: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
Message-ID: <SgNncwcMVRq1Cl1SmXB4GHol_RBiGKixLy721Ro9gn8=.5778faa0-1738-456d-8144-e0b746b64240@github.com>

> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
> 
> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  Alan's suggestion - report -debug usage as a warning right in the java.c code

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14918/files
  - new: https://git.openjdk.org/jdk/pull/14918/files/78498068..b6c867b0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14918&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14918&range=03-04

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/14918.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14918/head:pull/14918

PR: https://git.openjdk.org/jdk/pull/14918

From jpai at openjdk.org  Wed Jul 19 07:10:42 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 19 Jul 2023 07:10:42 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v4]
In-Reply-To: <54o5-4Raq5oX93gQrI_hfTjwiLVJGWzSBmE8VtTvK9g=.cb4c9df8-6a17-473f-9f47-6747303ba8fe@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <54o5-4Raq5oX93gQrI_hfTjwiLVJGWzSBmE8VtTvK9g=.cb4c9df8-6a17-473f-9f47-6747303ba8fe@github.com>
Message-ID: <-J8iaBQKogoLygjEnE5-2C7ZOWtWvP6EVchg1gyEblQ=.a25ca7ca-edb6-43ea-9d99-fe647aaa51eb@github.com>

On Tue, 18 Jul 2023 12:41:32 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>> 
>> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alan's suggestion for -Xdebug output

Hello Alan,

> I think ParseArguments (in libjli/java.c) could be changed so that it doesn't translate -debug to -Xdebug, instead it can print a warning, like it does for -Xfuture. The reason is -debug is a java launcher option, it's not known to the VM and means that Arguments::parse_each_vm_init_arg doesn't need to mention -debug when it warns about -Xdebug.

I had initially considered that but had noticed that there's a small difference between the generic warning message "Warning: %s option is deprecated and may be removed in a future release." printed by the launcher and the one printed by the VM "OpenJDK 64-Bit Server VM warning: Option -Xdebug was deprecated in JDK 22 and will likely be removed in a future release." But I think that small difference in the warning messages is OK when considered against your stated reasoning that `-debug` isn't known to the VM. 

I've now updated the PR to implement your suggestion.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14918#issuecomment-1641532218

From jpai at openjdk.org  Wed Jul 19 07:10:44 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 19 Jul 2023 07:10:44 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v5]
In-Reply-To: <SgNncwcMVRq1Cl1SmXB4GHol_RBiGKixLy721Ro9gn8=.5778faa0-1738-456d-8144-e0b746b64240@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <SgNncwcMVRq1Cl1SmXB4GHol_RBiGKixLy721Ro9gn8=.5778faa0-1738-456d-8144-e0b746b64240@github.com>
Message-ID: <nzQSP-DkA4nlibzARWldxDK7QllfbCL6C4ZX-jDvPHQ=.fcd49b3a-bef5-4377-90cb-14bac1af11d3@github.com>

On Wed, 19 Jul 2023 07:05:51 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>> 
>> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alan's suggestion - report -debug usage as a warning right in the java.c code

Adding one of my previous comments again, because it's not easily visible among the bot generated comments in the GitHub UI:

> I would like inputs on the test/hotspot/jtreg/runtime/6294277/SourceDebugExtension.java test. That test launches java passing it the -Xdebug option and was introduced as part of https://bugs.openjdk.org/browse/JDK-6294277. -Xdebug has been a no-op for many releases now. Is this test still relevant and if not, should I go ahead and remove it as part of this change?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14918#issuecomment-1641534305

From alanb at openjdk.org  Wed Jul 19 08:00:43 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Wed, 19 Jul 2023 08:00:43 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v5]
In-Reply-To: <nzQSP-DkA4nlibzARWldxDK7QllfbCL6C4ZX-jDvPHQ=.fcd49b3a-bef5-4377-90cb-14bac1af11d3@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <SgNncwcMVRq1Cl1SmXB4GHol_RBiGKixLy721Ro9gn8=.5778faa0-1738-456d-8144-e0b746b64240@github.com>
 <nzQSP-DkA4nlibzARWldxDK7QllfbCL6C4ZX-jDvPHQ=.fcd49b3a-bef5-4377-90cb-14bac1af11d3@github.com>
Message-ID: <FSApUcdiXCc3va7p9cVph_ofa3caO04J7sqs6I0IKm4=.6025e81f-62b0-49c6-98d9-2558c176b78d@github.com>

On Wed, 19 Jul 2023 07:07:40 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> I would like inputs on the test/hotspot/jtreg/runtime/6294277/SourceDebugExtension.java test. That test launches java passing it the -Xdebug option and was introduced as part of https://bugs.openjdk.org/browse/JDK-6294277. -Xdebug has been a no-op for many releases now. Is this test still relevant and if not, should I go ahead and remove it as part of this change?

The SDE class file attribute supports debugging of other languages (see JSR-45). The VM usually skips it but it has to save the bytes when a JVMTI agent has the can_get_source_debug_extension capability enabled. The debugger agent enables this capability so running with -agentlib:jdwp is enough to ensure that it is read. The -Xdebug option can be dropped from the test but otherwise I think leave it in place as it exercises a SDE that is >64k.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14918#issuecomment-1641606804

From alanb at openjdk.org  Wed Jul 19 08:04:42 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Wed, 19 Jul 2023 08:04:42 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v5]
In-Reply-To: <SgNncwcMVRq1Cl1SmXB4GHol_RBiGKixLy721Ro9gn8=.5778faa0-1738-456d-8144-e0b746b64240@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <SgNncwcMVRq1Cl1SmXB4GHol_RBiGKixLy721Ro9gn8=.5778faa0-1738-456d-8144-e0b746b64240@github.com>
Message-ID: <LxXjq4Ktnn8F5QesEqWgDXd4YNetzREnpUR6l4rg_lg=.1e397b4f-3d39-465e-bd14-2d94b39a489b@github.com>

On Wed, 19 Jul 2023 07:05:51 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>> 
>> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alan's suggestion - report -debug usage as a warning right in the java.c code

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14918#pullrequestreview-1536495911

From alanb at openjdk.org  Wed Jul 19 08:04:44 2023
From: alanb at openjdk.org (Alan Bateman)
Date: Wed, 19 Jul 2023 08:04:44 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v4]
In-Reply-To: <-J8iaBQKogoLygjEnE5-2C7ZOWtWvP6EVchg1gyEblQ=.a25ca7ca-edb6-43ea-9d99-fe647aaa51eb@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <54o5-4Raq5oX93gQrI_hfTjwiLVJGWzSBmE8VtTvK9g=.cb4c9df8-6a17-473f-9f47-6747303ba8fe@github.com>
 <-J8iaBQKogoLygjEnE5-2C7ZOWtWvP6EVchg1gyEblQ=.a25ca7ca-edb6-43ea-9d99-fe647aaa51eb@github.com>
Message-ID: <xy8ZL0UL2omJWDg_0jRDjUtuRUvPLfLS8y9Ypi1-ipU=.f91a9dde-d9fe-4053-9d1a-09a9413ea529@github.com>

On Wed, 19 Jul 2023 07:05:45 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> I had initially considered that but had noticed that there's a small difference between the generic warning message "Warning: %s option is deprecated and may be removed in a future release." printed by the launcher and the one printed by the VM "OpenJDK 64-Bit Server VM warning: Option -Xdebug was deprecated in JDK 22 and will likely be removed in a future release." But I think that small difference in the warning messages is OK when considered against your stated reasoning that `-debug` isn't known to the VM.

The different deprecation messages is a bit annoying but I think it's better than the VM printing a warning for an option that was never possible to specify to JNI CreateJavaVM.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14918#issuecomment-1641612439

From jpai at openjdk.org  Wed Jul 19 10:58:58 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Wed, 19 Jul 2023 10:58:58 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v6]
In-Reply-To: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
Message-ID: <Cq7TUnTv1VVlbeQTY3OtZD7YRt2KqIRushB7TPVvKFc=.267974d1-df00-4559-86aa-f117db520f25@github.com>

> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
> 
> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  remove -Xdebug usage from SourceDebugExtension test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14918/files
  - new: https://git.openjdk.org/jdk/pull/14918/files/b6c867b0..79c48cb0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14918&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14918&range=04-05

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/14918.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14918/head:pull/14918

PR: https://git.openjdk.org/jdk/pull/14918

From cjplummer at openjdk.org  Wed Jul 19 19:23:05 2023
From: cjplummer at openjdk.org (Chris Plummer)
Date: Wed, 19 Jul 2023 19:23:05 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v6]
In-Reply-To: <Cq7TUnTv1VVlbeQTY3OtZD7YRt2KqIRushB7TPVvKFc=.267974d1-df00-4559-86aa-f117db520f25@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <Cq7TUnTv1VVlbeQTY3OtZD7YRt2KqIRushB7TPVvKFc=.267974d1-df00-4559-86aa-f117db520f25@github.com>
Message-ID: <Kz8KilPPiyVAlIGacLBDjgIDLpo-WxDpHGHpzpvMNCM=.197a85e9-f749-405d-9c1d-673df06b5870@github.com>

On Wed, 19 Jul 2023 10:58:58 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>> 
>> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove -Xdebug usage from SourceDebugExtension test

Nice cleanup! Changes look good.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14918#pullrequestreview-1537863690

From dholmes at openjdk.org  Thu Jul 20 02:52:43 2023
From: dholmes at openjdk.org (David Holmes)
Date: Thu, 20 Jul 2023 02:52:43 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v6]
In-Reply-To: <Cq7TUnTv1VVlbeQTY3OtZD7YRt2KqIRushB7TPVvKFc=.267974d1-df00-4559-86aa-f117db520f25@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <Cq7TUnTv1VVlbeQTY3OtZD7YRt2KqIRushB7TPVvKFc=.267974d1-df00-4559-86aa-f117db520f25@github.com>
Message-ID: <nPOpzq8JP78doLCFXm7rWLMpCMZCugbAxm8XUYoEJJU=.3522d26f-0331-4e3a-99b7-d297f4087197@github.com>

On Wed, 19 Jul 2023 10:58:58 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>> 
>> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove -Xdebug usage from SourceDebugExtension test

Sorry for being late to the party :) Looks good. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14918#pullrequestreview-1538335630

From jpai at openjdk.org  Fri Jul 21 13:01:49 2023
From: jpai at openjdk.org (Jaikiran Pai)
Date: Fri, 21 Jul 2023 13:01:49 GMT
Subject: Integrated: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6
In-Reply-To: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
Message-ID: <dB9wTBAqUFtMBk9-XtKa1-4UybsLh-KpW6CJuxhyDeY=.dadc980d-c9c6-4d2a-ac43-0d340733fbf9@github.com>

On Tue, 18 Jul 2023 06:59:52 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
> 
> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.

This pull request has now been integrated.

Changeset: 842d6329
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/842d6329cf5a3da8df7eddb195b5fcb7baadbdc3
Stats:     41 lines in 25 files changed: 0 ins; 9 del; 32 mod

8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6

Reviewed-by: alanb, cjplummer, dholmes

-------------

PR: https://git.openjdk.org/jdk/pull/14918

From dholmes at openjdk.org  Wed Jul 26 07:17:59 2023
From: dholmes at openjdk.org (David Holmes)
Date: Wed, 26 Jul 2023 07:17:59 GMT
Subject: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that
 have not done anything since Java 6 [v6]
In-Reply-To: <Cq7TUnTv1VVlbeQTY3OtZD7YRt2KqIRushB7TPVvKFc=.267974d1-df00-4559-86aa-f117db520f25@github.com>
References: <DBX8URjVSiAPULb1udGr9eyFOkx8K8nGADqrLTr-6ic=.3bb6a248-b889-4347-b39c-b164691d8f69@github.com>
 <Cq7TUnTv1VVlbeQTY3OtZD7YRt2KqIRushB7TPVvKFc=.267974d1-df00-4559-86aa-f117db520f25@github.com>
Message-ID: <7l5s1UCDgEt4c34NVusIhI9fdXsoJPhuUtdHV9FMnaM=.ee4b077d-ddd0-4430-8e1d-61379b46b239@github.com>

On Wed, 19 Jul 2023 10:58:58 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate for removal the  `-Xdebug` option and `-debug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>> 
>> As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible since even Java 8 days.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove -Xdebug usage from SourceDebugExtension test

Sorry wrong browser tab

-------------

PR Review: https://git.openjdk.org/jdk/pull/14918#pullrequestreview-1546982502