RFR: 8312072: Deprecate for removal the -Xnoagent option [v2]

[Alan Bateman]

On Sat, 15 Jul 2023 00:58:02 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
>> 
>> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
>> 
>> Additionally, this PR also cleans up one such usage that I found in the JDK code.
>> 
>> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove references to -Xnoagent from tests

Marked as reviewed by alanb (Reviewer).

make/ide/netbeans/langtools/build.xml line 245:

> 243:                 <property
> 244:                     name="@{jpda.jvmargs.property}"
> 245:                     value="-Xdebug -Djava.compiler=none -Xrunjdwp:transport=dt_socket,address=${jpda.address}"

Maybe -Djava.compiler=none should be removed too. I don't know if this project file is still used but I assume attempting to debug will print a warning due to this option.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14882#pullrequestreview-1531665623
PR Review Comment: https://git.openjdk.org/jdk/pull/14882#discussion_r1264615868