RFR: 8312072: Deprecate for removal the -Xnoagent option [v3]

[David Holmes]

On Sun, 16 Jul 2023 06:34:46 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to deprecate `-Xnoagent` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312072.
>> 
>> As noted in the JBS issue, this option currently is a no-op and provides no functionality. The commit in this PR logs a deprecation warning if this option is used when launching `java`.
>> 
>> Additionally, this PR also cleans up one such usage that I found in the JDK code.
>> 
>> `tier1`, `tier2` and `tier3` tests passed with this change. A CSR has been proposed for this deprecation https://bugs.openjdk.org/browse/JDK-8312073.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove -Djava.compiler=none

This looks fine. What about all the ./src/demo/share/nbproject/jfc/*/nbproject/netbeans-targets.xml files? Will they get cleaned up when this option is actually removed?

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14882#pullrequestreview-1531867661