From prappo at openjdk.org  Thu Mar  2 12:13:14 2023
From: prappo at openjdk.org (Pavel Rappo)
Date: Thu, 2 Mar 2023 12:13:14 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
Message-ID: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>

Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.

The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:


    diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
    --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
    +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
    @@ -17084,7 +17084,7 @@
                      throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
     <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
     <div class="block"><code>readObject</code> is called to restore the state of the
    - (@code BasicPermission} from a stream.</div>
    + <code>BasicPermission</code> from a stream.</div>
     <dl class="notes">
     <dt>Parameters:</dt>
     <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>

Notes
-----

* I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
* I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
* I will update copyright years after (and if) the fix had been approved, as required.

-------------

Commit messages:
 - Initial commit

Changes: https://git.openjdk.org/jdk/pull/12826/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12826&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8303480
  Stats: 75 lines in 39 files changed: 0 ins; 0 del; 75 mod
  Patch: https://git.openjdk.org/jdk/pull/12826.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12826/head:pull/12826

PR: https://git.openjdk.org/jdk/pull/12826

From mullan at openjdk.org  Thu Mar  2 13:24:07 2023
From: mullan at openjdk.org (Sean Mullan)
Date: Thu, 2 Mar 2023 13:24:07 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
In-Reply-To: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
Message-ID: <GCwAXDcnMpAJDHxB9QMEP9UmwTYemW62F7RUdNaEVk8=.8b73051d-d3a8-4fac-ac48-efc3864d33bc@github.com>

On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
> 
> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
> 
> 
>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>     @@ -17084,7 +17084,7 @@
>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>      <div class="block"><code>readObject</code> is called to restore the state of the
>     - (@code BasicPermission} from a stream.</div>
>     + <code>BasicPermission</code> from a stream.</div>
>      <dl class="notes">
>      <dt>Parameters:</dt>
>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
> 
> Notes
> -----
> 
> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
> * I will update copyright years after (and if) the fix had been approved, as required.

security related changes look fine.

-------------

Marked as reviewed by mullan (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12826

From jwaters at openjdk.org  Thu Mar  2 15:49:01 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 2 Mar 2023 15:49:01 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v33]
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <8EcCmqnO_MjwO3K13w7cTNsK38n7O6tGpJrQQVCm45Q=.ffb1a056-44d5-4953-9e7b-c1258c858e6a@github.com>

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 42 commits:

 - Workspace File
 - Merge remote-tracking branch 'upstream/master' into eclipse
 - classpaths now use templates
 - Register classpath and cproject
 - Merge remote-tracking branch 'upstream/master' into eclipse
 - Progress
 - Merge remote-tracking branch 'upstream/master' into eclipse
 - Formatting Cleanup
 - Proper Checks
 - Merge remote-tracking branch 'upstream/master' into eclipse
 - ... and 32 more: https://git.openjdk.org/jdk/compare/b51ea420...cbd0572f

-------------

Changes: https://git.openjdk.org/jdk/pull/10853/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=32
  Stats: 752 lines in 10 files changed: 750 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/10853.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853

PR: https://git.openjdk.org/jdk/pull/10853

From prr at openjdk.org  Thu Mar  2 21:29:04 2023
From: prr at openjdk.org (Phil Race)
Date: Thu, 2 Mar 2023 21:29:04 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
In-Reply-To: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
Message-ID: <LDJs1K7coRg4R4EWiETtoqjNIaZchHUjyKAg2madLSM=.11763787-9322-4863-8ca9-242447a9c6de@github.com>

On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
> 
> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
> 
> 
>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>     @@ -17084,7 +17084,7 @@
>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>      <div class="block"><code>readObject</code> is called to restore the state of the
>     - (@code BasicPermission} from a stream.</div>
>     + <code>BasicPermission</code> from a stream.</div>
>      <dl class="notes">
>      <dt>Parameters:</dt>
>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
> 
> Notes
> -----
> 
> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
> * I will update copyright years after (and if) the fix had been approved, as required.

java.desktop changes are fine

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12826

From cjplummer at openjdk.org  Thu Mar  2 22:18:08 2023
From: cjplummer at openjdk.org (Chris Plummer)
Date: Thu, 2 Mar 2023 22:18:08 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
In-Reply-To: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
Message-ID: <63UHTjtrUOVGBTwRt_M4QJ7aqBnuAGqekNTTTl3GM74=.ddedac04-ff87-40b9-9ea7-6b6d26d9d202@github.com>

On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
> 
> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
> 
> 
>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>     @@ -17084,7 +17084,7 @@
>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>      <div class="block"><code>readObject</code> is called to restore the state of the
>     - (@code BasicPermission} from a stream.</div>
>     + <code>BasicPermission</code> from a stream.</div>
>      <dl class="notes">
>      <dt>Parameters:</dt>
>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
> 
> Notes
> -----
> 
> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
> * I will update copyright years after (and if) the fix had been approved, as required.

The SA changes (jdk.hotspot.agent) look fine.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12826

From aivanov at openjdk.org  Fri Mar  3 08:28:19 2023
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 3 Mar 2023 08:28:19 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
In-Reply-To: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
Message-ID: <zGeNBZ-3vU9GABEYOeUorRTJAMzyQzN-97Rx6qKisaY=.87335367-efc7-4c48-b866-de39a9d9c9e2@github.com>

On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
> 
> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
> 
> 
>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>     @@ -17084,7 +17084,7 @@
>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>      <div class="block"><code>readObject</code> is called to restore the state of the
>     - (@code BasicPermission} from a stream.</div>
>     + <code>BasicPermission</code> from a stream.</div>
>      <dl class="notes">
>      <dt>Parameters:</dt>
>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
> 
> Notes
> -----
> 
> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
> * I will update copyright years after (and if) the fix had been approved, as required.

Looks good to me.

I looked through all the changes, paying more attention to the client area.

src/java.base/share/classes/java/lang/invoke/BootstrapMethodInvoker.java line 257:

> 255: 
> 256:     /**
> 257:      * @return true iff the BSM method type exactly matches

I assume ?iff? should ?if??

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 2866:

> 2864:      * Merge multiple abstract methods. The preferred method is a method that is a subsignature
> 2865:      * of all the other signatures and whose return type is more specific {@link MostSpecificReturnCheck}.
> 2866:      * The resulting preferred method has a thrown clause that is the intersection of the merged

Is it ??has a {@code throws} clause???

-------------

Marked as reviewed by aivanov (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12826

From prappo at openjdk.org  Fri Mar  3 09:41:06 2023
From: prappo at openjdk.org (Pavel Rappo)
Date: Fri, 3 Mar 2023 09:41:06 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
In-Reply-To: <zGeNBZ-3vU9GABEYOeUorRTJAMzyQzN-97Rx6qKisaY=.87335367-efc7-4c48-b866-de39a9d9c9e2@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
 <zGeNBZ-3vU9GABEYOeUorRTJAMzyQzN-97Rx6qKisaY=.87335367-efc7-4c48-b866-de39a9d9c9e2@github.com>
Message-ID: <Bzi35xfPH43Jupv65o86ErKvkPYaJdNV7cDIX7BBorc=.34e6522f-ec1e-41ee-b254-32713288bc79@github.com>

On Thu, 2 Mar 2023 16:23:17 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
>> 
>> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
>> 
>> 
>>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>>     @@ -17084,7 +17084,7 @@
>>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>>      <div class="block"><code>readObject</code> is called to restore the state of the
>>     - (@code BasicPermission} from a stream.</div>
>>     + <code>BasicPermission</code> from a stream.</div>
>>      <dl class="notes">
>>      <dt>Parameters:</dt>
>>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
>> 
>> Notes
>> -----
>> 
>> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
>> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
>> * I will update copyright years after (and if) the fix had been approved, as required.
>
> src/java.base/share/classes/java/lang/invoke/BootstrapMethodInvoker.java line 257:
> 
>> 255: 
>> 256:     /**
>> 257:      * @return true iff the BSM method type exactly matches
> 
> I assume ?iff? should ?if??

Here and elsewhere in this file "iff" might mean [if and only if](https://en.wikipedia.org/wiki/If_and_only_if), which would make sense. (FWIW, there are a few hundred occurrences of the word "iff" in src.)

@cl4es (Claes Redestad), as the author of those lines would you like to chime in?

Since Claes might read this, I note that when I changed unsupported `{@see}` to `{@link}` thoughtout this file, my IDE could not resolve one of the links: `java.lang.invoke.LambdaMetafactory#metafactory(MethodHandles.Lookup,String,Class,MethodType,MethodHandle,MethodType)`

While there's a similarly-name method with slightly different parameters, I refrained from using it:
`java.lang.invoke.LambdaMetafactory#metafactory(MethodHandles.Lookup,String,MethodType,MethodType,MethodHandle,MethodType)`.

-------------

PR: https://git.openjdk.org/jdk/pull/12826

From prappo at openjdk.org  Fri Mar  3 09:44:13 2023
From: prappo at openjdk.org (Pavel Rappo)
Date: Fri, 3 Mar 2023 09:44:13 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
In-Reply-To: <zGeNBZ-3vU9GABEYOeUorRTJAMzyQzN-97Rx6qKisaY=.87335367-efc7-4c48-b866-de39a9d9c9e2@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
 <zGeNBZ-3vU9GABEYOeUorRTJAMzyQzN-97Rx6qKisaY=.87335367-efc7-4c48-b866-de39a9d9c9e2@github.com>
Message-ID: <5TgKeBVz0u1hCa1qOiC7Y46DJvUtDIsDa1wv2I4tAX8=.8575f968-0685-450d-8d77-16523cd7531a@github.com>

On Fri, 3 Mar 2023 08:15:49 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
>> 
>> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
>> 
>> 
>>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>>     @@ -17084,7 +17084,7 @@
>>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>>      <div class="block"><code>readObject</code> is called to restore the state of the
>>     - (@code BasicPermission} from a stream.</div>
>>     + <code>BasicPermission</code> from a stream.</div>
>>      <dl class="notes">
>>      <dt>Parameters:</dt>
>>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
>> 
>> Notes
>> -----
>> 
>> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
>> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
>> * I will update copyright years after (and if) the fix had been approved, as required.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 2866:
> 
>> 2864:      * Merge multiple abstract methods. The preferred method is a method that is a subsignature
>> 2865:      * of all the other signatures and whose return type is more specific {@link MostSpecificReturnCheck}.
>> 2866:      * The resulting preferred method has a thrown clause that is the intersection of the merged
> 
> Is it ??has a {@code throws} clause???

Thanks! I'll add this to a separate PR.

-------------

PR: https://git.openjdk.org/jdk/pull/12826

From redestad at openjdk.org  Fri Mar  3 10:12:13 2023
From: redestad at openjdk.org (Claes Redestad)
Date: Fri, 3 Mar 2023 10:12:13 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
In-Reply-To: <Bzi35xfPH43Jupv65o86ErKvkPYaJdNV7cDIX7BBorc=.34e6522f-ec1e-41ee-b254-32713288bc79@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
 <zGeNBZ-3vU9GABEYOeUorRTJAMzyQzN-97Rx6qKisaY=.87335367-efc7-4c48-b866-de39a9d9c9e2@github.com>
 <Bzi35xfPH43Jupv65o86ErKvkPYaJdNV7cDIX7BBorc=.34e6522f-ec1e-41ee-b254-32713288bc79@github.com>
Message-ID: <-U8YFFuXm_hMf-bY1AVCRauRrE-fRYRxrx_yf38ZL1A=.d50884c5-cc4b-489a-b817-828faf876c76@github.com>

On Fri, 3 Mar 2023 09:38:13 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/invoke/BootstrapMethodInvoker.java line 257:
>> 
>>> 255: 
>>> 256:     /**
>>> 257:      * @return true iff the BSM method type exactly matches
>> 
>> I assume ?iff? should ?if??
>
> Here and elsewhere in this file "iff" might mean [if and only if](https://en.wikipedia.org/wiki/If_and_only_if), which would make sense. (FWIW, there are a few hundred occurrences of the word "iff" in src.)
> 
> @cl4es (Claes Redestad), as the author of those lines would you like to chime in?
> 
> Since Claes might read this, I note that when I changed unsupported `{@see}` to `{@link}` thoughtout this file, my IDE could not resolve one of the links: `java.lang.invoke.LambdaMetafactory#metafactory(MethodHandles.Lookup,String,Class,MethodType,MethodHandle,MethodType)`
> 
> While there's a similarly-name method with slightly different parameters, I refrained from using it:
> `java.lang.invoke.LambdaMetafactory#metafactory(MethodHandles.Lookup,String,MethodType,MethodType,MethodHandle,MethodType)`.

Yes, iff means if-and-only-if and is used for extra precision in formal logic, mathematics. As @pavelrappo points out it's a relatively common occurrence in the OpenJDK sources, though perhaps not in the public javadocs. Perhaps a bit pretentious, but mostly a terse way to say "return true if the BSM method type exactly matches X, otherwise false".

The broken link stems from the fact that the method I was targeting (a way to use condy for lambda proxy singletons rather than a `MethodHandle.constant`) was never integrated. We'll look at either getting that done (@briangoetz suggested the time might be ready for it) or remove this currently pointless static bootstrap specialization test.

-------------

PR: https://git.openjdk.org/jdk/pull/12826

From aivanov at openjdk.org  Fri Mar  3 11:34:16 2023
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 3 Mar 2023 11:34:16 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
In-Reply-To: <-U8YFFuXm_hMf-bY1AVCRauRrE-fRYRxrx_yf38ZL1A=.d50884c5-cc4b-489a-b817-828faf876c76@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
 <zGeNBZ-3vU9GABEYOeUorRTJAMzyQzN-97Rx6qKisaY=.87335367-efc7-4c48-b866-de39a9d9c9e2@github.com>
 <Bzi35xfPH43Jupv65o86ErKvkPYaJdNV7cDIX7BBorc=.34e6522f-ec1e-41ee-b254-32713288bc79@github.com>
 <-U8YFFuXm_hMf-bY1AVCRauRrE-fRYRxrx_yf38ZL1A=.d50884c5-cc4b-489a-b817-828faf876c76@github.com>
Message-ID: <GIf5QraCfE1MexPnWsXUMEWFPYoWpu-80I1N7bB6ffk=.728f82a3-fe8f-40d3-8dbd-c6a9fa5e031a@github.com>

On Fri, 3 Mar 2023 10:09:27 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> Yes, iff means if-and-only-if and is used for extra precision in formal logic, mathematics.

I've never come across it before. With your explanations, it makes perfect sense.

-------------

PR: https://git.openjdk.org/jdk/pull/12826

From jwaters at openjdk.org  Sat Mar  4 16:16:51 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Sat, 4 Mar 2023 16:16:51 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v34]
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <MbPMIdwH8z-l3gKuPOoCIdXmxzjaBdxCYISKX3VDNo4=.258fbce1-75b4-4ccd-8762-34f6dedf8d3a@github.com>

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Rework entirely to use templates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10853/files
  - new: https://git.openjdk.org/jdk/pull/10853/files/cbd0572f..49dbe3ea

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=33
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=32-33

  Stats: 465 lines in 9 files changed: 105 ins; 176 del; 184 mod
  Patch: https://git.openjdk.org/jdk/pull/10853.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Sat Mar  4 18:58:49 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Sat, 4 Mar 2023 18:58:49 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v35]
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <UiCZebnkiiZXWHFC9qyyrFIhdXaYgnZbpDFPYxIwOA8=.521b448e-f0a7-4211-a2da-634b553c176e@github.com>

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Cleanup

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10853/files
  - new: https://git.openjdk.org/jdk/pull/10853/files/49dbe3ea..5dd3f6cc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=34
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=33-34

  Stats: 25 lines in 1 file changed: 7 ins; 5 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/10853.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Sat Mar  4 18:58:52 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Sat, 4 Mar 2023 18:58:52 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v30]
In-Reply-To: <5EDBcRWu_c5-rjJ_lLC7Smh4cNiWBHOy8w6bCxgA5wE=.4bdaa92f-241b-41d8-9be7-45c1bf4bad55@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <Wc6sBtfThb2EwKwbIzeXNMgj_sROoixFlx-N4Ffoat8=.6d8011d5-32c8-4f1b-94a0-f82ec9e8594b@github.com>
 <UuR6qV3JkziB7TXII83o6Zm4RZfY_M6EinCzSDbAD6g=.2a8da51e-a49d-4936-a8b5-abb09737cc96@github.com>
 <5EDBcRWu_c5-rjJ_lLC7Smh4cNiWBHOy8w6bCxgA5wE=.4bdaa92f-241b-41d8-9be7-45c1bf4bad55@github.com>
Message-ID: <BiwLGFgtGZ9B_PIWDm6hVMTaXCnOTOYl8e5uWcRkBbg=.e37a8f62-ba34-479b-810e-fe3802f52826@github.com>

On Mon, 23 Jan 2023 15:11:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Oh my god, thanks so much for that pointer, this likely would've been so much easier to do, zzz
>> 
>> I'll do that after implementing extracting defines from the command line though, to make it less messy
>
> @TheShermanTanker If you intend to rewrite this using template files, maybe set the PR in Draft state?

@magicus Sorry for the bother, just a quick question, can `REPLACEMENTS` take a Makefile variable that has newlines in it? For instance

NATURES := \
    java \
    c \
    c++

REPLACEMENTS := \
    @@NATURES@@ => $(NATURES), \


(Not actual Eclipse xml format, the above is just for demonstration purposes)

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From ihse at openjdk.org  Sat Mar  4 18:58:53 2023
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Sat, 4 Mar 2023 18:58:53 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v30]
In-Reply-To: <BiwLGFgtGZ9B_PIWDm6hVMTaXCnOTOYl8e5uWcRkBbg=.e37a8f62-ba34-479b-810e-fe3802f52826@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <Wc6sBtfThb2EwKwbIzeXNMgj_sROoixFlx-N4Ffoat8=.6d8011d5-32c8-4f1b-94a0-f82ec9e8594b@github.com>
 <UuR6qV3JkziB7TXII83o6Zm4RZfY_M6EinCzSDbAD6g=.2a8da51e-a49d-4936-a8b5-abb09737cc96@github.com>
 <5EDBcRWu_c5-rjJ_lLC7Smh4cNiWBHOy8w6bCxgA5wE=.4bdaa92f-241b-41d8-9be7-45c1bf4bad55@github.com>
 <BiwLGFgtGZ9B_PIWDm6hVMTaXCnOTOYl8e5uWcRkBbg=.e37a8f62-ba34-479b-810e-fe3802f52826@github.com>
Message-ID: <MzwgxnPJWI5HMQUZMjRKIm6ioKisHs7W7UHNEv-LR6g=.2e8cb4b7-575e-440b-953a-c0385de20d10@github.com>

On Tue, 28 Feb 2023 13:06:19 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> can `REPLACEMENTS` take a Makefile variable that has newlines in it?

yes

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Sat Mar  4 18:58:54 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Sat, 4 Mar 2023 18:58:54 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v35]
In-Reply-To: <-460jAwuO1LachCE8nAzm_UsCGX8gyEH5kiU9ZnYSF0=.48af2d71-7e11-4692-88b6-c3fc009df04e@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <-460jAwuO1LachCE8nAzm_UsCGX8gyEH5kiU9ZnYSF0=.48af2d71-7e11-4692-88b6-c3fc009df04e@github.com>
Message-ID: <EexmGqJP8YDyhJ4zaFrpsQTo-5DgBPSliwjV2oizWmc=.3ffb3195-9634-4eb4-94a7-11b9fba415c4@github.com>

On Tue, 25 Oct 2022 22:17:25 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanup
>
> This looks like nice work.
> 
> I'm curious how does this eclipse project figures out preprocessor settings like -D flags from the build to correctly setup the environment for the native code? I know this was a major deal when creating the compile-commands.json for other native IDE integrations. I've heard some IDEs just run the build once and inspect the command lines, but our default log level won't show that. I'm not familiar with eclipse project files, but I couldn't really see anything here that addressed this issue. Can you work with the native code in a meaningful way without it?

@erikj79 @magicus Seems like this is the best I can do for now, baseline support for Eclipse should now be present with these final touchups (Environment setup is not fully complete yet, but Eclipse is flexible enough that for most development work, this should not be too problematic). I do plan to refine support for it in the future, since there are still areas for improvement, but at present I think this should be decent enough for the time being

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Sat Mar  4 19:09:50 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Sat, 4 Mar 2023 19:09:50 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v36]
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <k4iL5A7gHhXJkl-mYy8mOjR8wcSCRhckkM-0sZvBeuw=.f37edbbb-1fbe-4a68-9290-c080afd604f6@github.com>

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Explicitly forbid Visual C++

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10853/files
  - new: https://git.openjdk.org/jdk/pull/10853/files/5dd3f6cc..94493720

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=35
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=34-35

  Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/10853.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Sun Mar  5 15:36:34 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Sun, 5 Mar 2023 15:36:34 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v37]
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <50_JjOH183qASErG2jmJjTJ6PuwG5l7YZf45SqmjKoQ=.9c97d7e0-e790-4823-8504-7678dbe3e27d@github.com>

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Formatting

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10853/files
  - new: https://git.openjdk.org/jdk/pull/10853/files/94493720..85df2b7b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=36
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=35-36

  Stats: 15 lines in 3 files changed: 0 ins; 0 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/10853.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Mon Mar  6 13:08:57 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 6 Mar 2023 13:08:57 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v38]
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <7iVD6lAYx6MEVxeWBu5p3OMLcrRbWH15EaMD0XXzi9k=.3e75d853-49cf-43a5-ac26-3cfa7b2bb224@github.com>

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Wording

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10853/files
  - new: https://git.openjdk.org/jdk/pull/10853/files/85df2b7b..13c0b9b9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=37
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=36-37

  Stats: 10 lines in 5 files changed: 4 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/10853.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853

PR: https://git.openjdk.org/jdk/pull/10853

From prappo at openjdk.org  Mon Mar  6 20:22:48 2023
From: prappo at openjdk.org (Pavel Rappo)
Date: Mon, 6 Mar 2023 20:22:48 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
 [v2]
In-Reply-To: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
Message-ID: <cwRZFQxyddrtPWS__nVK0l1Lu-dL3lnlR3rODiLfncA=.2f5b214e-9ae7-492a-b09a-81ef4077a26e@github.com>

> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
> 
> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
> 
> 
>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>     @@ -17084,7 +17084,7 @@
>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>      <div class="block"><code>readObject</code> is called to restore the state of the
>     - (@code BasicPermission} from a stream.</div>
>     + <code>BasicPermission</code> from a stream.</div>
>      <dl class="notes">
>      <dt>Parameters:</dt>
>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
> 
> Notes
> -----
> 
> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
> * I will update copyright years after (and if) the fix had been approved, as required.

Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into 8303480
 - Initial commit

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12826/files
  - new: https://git.openjdk.org/jdk/pull/12826/files/d2f4a553..87166408

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12826&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12826&range=00-01

  Stats: 13433 lines in 415 files changed: 9003 ins; 2610 del; 1820 mod
  Patch: https://git.openjdk.org/jdk/pull/12826.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12826/head:pull/12826

PR: https://git.openjdk.org/jdk/pull/12826

From jjg at openjdk.org  Mon Mar  6 20:31:18 2023
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Mon, 6 Mar 2023 20:31:18 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
 [v2]
In-Reply-To: <GIf5QraCfE1MexPnWsXUMEWFPYoWpu-80I1N7bB6ffk=.728f82a3-fe8f-40d3-8dbd-c6a9fa5e031a@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
 <zGeNBZ-3vU9GABEYOeUorRTJAMzyQzN-97Rx6qKisaY=.87335367-efc7-4c48-b866-de39a9d9c9e2@github.com>
 <Bzi35xfPH43Jupv65o86ErKvkPYaJdNV7cDIX7BBorc=.34e6522f-ec1e-41ee-b254-32713288bc79@github.com>
 <-U8YFFuXm_hMf-bY1AVCRauRrE-fRYRxrx_yf38ZL1A=.d50884c5-cc4b-489a-b817-828faf876c76@github.com>
 <GIf5QraCfE1MexPnWsXUMEWFPYoWpu-80I1N7bB6ffk=.728f82a3-fe8f-40d3-8dbd-c6a9fa5e031a@github.com>
Message-ID: <ZXfrODW3U49MwVjsf7erqcN1x3lsi5dyU5SSaETKruY=.616faeb3-663f-4191-8bec-8fc0c9eba48d@github.com>

On Fri, 3 Mar 2023 11:31:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Yes, iff means if-and-only-if and is used for extra precision in formal logic, mathematics. As @pavelrappo points out it's a relatively common occurrence in the OpenJDK sources, though perhaps not in the public javadocs. Perhaps a bit pretentious, but mostly a terse way to say "return true if the BSM method type exactly matches X, otherwise false".
>> 
>> The broken link stems from the fact that the method I was targeting (a way to use condy for lambda proxy singletons rather than a `MethodHandle.constant`) was never integrated. We'll look at either getting that done (@briangoetz suggested the time might be ready for it) or remove this currently pointless static bootstrap specialization test.
>
>> Yes, iff means if-and-only-if and is used for extra precision in formal logic, mathematics.
> 
> I've never come across it before. With your explanations, it makes perfect sense.

I would recommend (separately) changing `iff` to the expanded form `if and only if`

-------------

PR: https://git.openjdk.org/jdk/pull/12826

From jjg at openjdk.org  Mon Mar  6 20:36:13 2023
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Mon, 6 Mar 2023 20:36:13 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
 [v2]
In-Reply-To: <cwRZFQxyddrtPWS__nVK0l1Lu-dL3lnlR3rODiLfncA=.2f5b214e-9ae7-492a-b09a-81ef4077a26e@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
 <cwRZFQxyddrtPWS__nVK0l1Lu-dL3lnlR3rODiLfncA=.2f5b214e-9ae7-492a-b09a-81ef4077a26e@github.com>
Message-ID: <ztCzFqlAYLpzLdZY0K_GgKPNNOvqF9FNTbDh5ZEg-lk=.3aa6a92b-a286-4760-bdc4-425f48e53a6f@github.com>

The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.

----------------------------------------------------------------------
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
>> 
>> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
>> 
>> 
>>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>>     @@ -17084,7 +17084,7 @@
>>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>>      <div class="block"><code>readObject</code> is called to restore the state of the
>>     - (@code BasicPermission} from a stream.</div>
>>     + <code>BasicPermission</code> from a stream.</div>
>>      <dl class="notes">
>>      <dt>Parameters:</dt>
>>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
>> 
>> Notes
>> -----
>> 
>> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
>> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
>> * I will update copyright years after (and if) the fix had been approved, as required.
>
> Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into 8303480
>  - Initial commit

Marked as reviewed by jjg (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/12826

From lancea at openjdk.org  Mon Mar  6 20:39:17 2023
From: lancea at openjdk.org (Lance Andersen)
Date: Mon, 6 Mar 2023 20:39:17 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
 [v2]
In-Reply-To: <cwRZFQxyddrtPWS__nVK0l1Lu-dL3lnlR3rODiLfncA=.2f5b214e-9ae7-492a-b09a-81ef4077a26e@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
 <cwRZFQxyddrtPWS__nVK0l1Lu-dL3lnlR3rODiLfncA=.2f5b214e-9ae7-492a-b09a-81ef4077a26e@github.com>
Message-ID: <RWgaYiwcqLzeKKbnHxAAnPlwk1ndum8VkwVOnvJAbMM=.e0a4507f-dd64-41c8-89c6-70ceb8d34995@github.com>

On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
>> 
>> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
>> 
>> 
>>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>>     @@ -17084,7 +17084,7 @@
>>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>>      <div class="block"><code>readObject</code> is called to restore the state of the
>>     - (@code BasicPermission} from a stream.</div>
>>     + <code>BasicPermission</code> from a stream.</div>
>>      <dl class="notes">
>>      <dt>Parameters:</dt>
>>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
>> 
>> Notes
>> -----
>> 
>> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
>> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
>> * I will update copyright years after (and if) the fix had been approved, as required.
>
> Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into 8303480
>  - Initial commit

Marked as reviewed by lancea (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/12826

From rriggs at openjdk.org  Mon Mar  6 21:29:08 2023
From: rriggs at openjdk.org (Roger Riggs)
Date: Mon, 6 Mar 2023 21:29:08 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
 [v2]
In-Reply-To: <cwRZFQxyddrtPWS__nVK0l1Lu-dL3lnlR3rODiLfncA=.2f5b214e-9ae7-492a-b09a-81ef4077a26e@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
 <cwRZFQxyddrtPWS__nVK0l1Lu-dL3lnlR3rODiLfncA=.2f5b214e-9ae7-492a-b09a-81ef4077a26e@github.com>
Message-ID: <xJn3JEoOJduXQZ9MF4uueB3KdIC4T_3roLNAWSQ8mZM=.4d80d353-a5e3-4cc4-87b3-320643f8cc36@github.com>

On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
>> 
>> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
>> 
>> 
>>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>>     @@ -17084,7 +17084,7 @@
>>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>>      <div class="block"><code>readObject</code> is called to restore the state of the
>>     - (@code BasicPermission} from a stream.</div>
>>     + <code>BasicPermission</code> from a stream.</div>
>>      <dl class="notes">
>>      <dt>Parameters:</dt>
>>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
>> 
>> Notes
>> -----
>> 
>> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
>> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
>> * I will update copyright years after (and if) the fix had been approved, as required.
>
> Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into 8303480
>  - Initial commit

Marked as reviewed by rriggs (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/12826

From ihse at openjdk.org  Tue Mar  7 11:19:08 2023
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 7 Mar 2023 11:19:08 GMT
Subject: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments
 [v2]
In-Reply-To: <cwRZFQxyddrtPWS__nVK0l1Lu-dL3lnlR3rODiLfncA=.2f5b214e-9ae7-492a-b09a-81ef4077a26e@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
 <cwRZFQxyddrtPWS__nVK0l1Lu-dL3lnlR3rODiLfncA=.2f5b214e-9ae7-492a-b09a-81ef4077a26e@github.com>
Message-ID: <jtMAFBGGsxnmsPk8rzwnle3YNCoW9AMBfy69IAW5jT0=.2980eb41-64af-4b4b-8826-86f5a6ea6477@github.com>

On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
>> 
>> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
>> 
>> 
>>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>>     @@ -17084,7 +17084,7 @@
>>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>>      <div class="block"><code>readObject</code> is called to restore the state of the
>>     - (@code BasicPermission} from a stream.</div>
>>     + <code>BasicPermission</code> from a stream.</div>
>>      <dl class="notes">
>>      <dt>Parameters:</dt>
>>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
>> 
>> Notes
>> -----
>> 
>> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
>> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
>> * I will update copyright years after (and if) the fix had been approved, as required.
>
> Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into 8303480
>  - Initial commit

Marked as reviewed by ihse (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/12826

From prappo at openjdk.org  Tue Mar  7 15:35:51 2023
From: prappo at openjdk.org (Pavel Rappo)
Date: Tue, 7 Mar 2023 15:35:51 GMT
Subject: Integrated: 8303480: Miscellaneous fixes to mostly invisible doc
 comments
In-Reply-To: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
References: <qBda_vNvFz2TKSb8wHPWmqAcdWIC3eao_UdPQkf0jro=.280c1677-def5-4c99-97c4-6bd30c8a9183@github.com>
Message-ID: <bX8VasBimwapkC8a4jdbxSSzCrgVWVZmukOp-odUBTs=.afe4dd0d-9ed0-4cd8-8b8d-92285c7d58bc@github.com>

On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this superficial documentation cleanup that was triggered by unrelated analysis of doc comments in JDK API.
> 
> The only effect that this multi-area PR has on the JDK API Documentation (i.e. the observable effect on the generated HTML pages) can be summarized as follows:
> 
> 
>     diff -ur build/macosx-aarch64/images/docs-before/api/serialized-form.html build/macosx-aarch64/images/docs-after/api/serialized-form.html
>     --- build/macosx-aarch64/images/docs-before/api/serialized-form.html	2023-03-02 11:47:44
>     +++ build/macosx-aarch64/images/docs-after/api/serialized-form.html	2023-03-02 11:48:45
>     @@ -17084,7 +17084,7 @@
>                       throws <span class="exceptions"><a href="java.base/java/io/IOException.html" title="class in java.io">IOException</a>,
>      <a href="java.base/java/lang/ClassNotFoundException.html" title="class in java.lang">ClassNotFoundException</a></span></div>
>      <div class="block"><code>readObject</code> is called to restore the state of the
>     - (@code BasicPermission} from a stream.</div>
>     + <code>BasicPermission</code> from a stream.</div>
>      <dl class="notes">
>      <dt>Parameters:</dt>
>      <dd><code>s</code> - the <code>ObjectInputStream</code> from which data is read</dd>
> 
> Notes
> -----
> 
> * I'm not an expert in any of the affected areas, except for jdk.javadoc, and I was merely after misused tags. Because of that, I would appreciate reviews from experts in other areas.
> * I discovered many more issues than I included in this PR. The excluded issues seem to occur in infrequently updated third-party code (e.g. javax.xml), which I assume we shouldn't touch unless necessary.
> * I will update copyright years after (and if) the fix had been approved, as required.

This pull request has now been integrated.

Changeset: 45a616a8
Author:    Pavel Rappo <prappo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/45a616a891e4a4b0e77b1f2fa040522f4a99d172
Stats:     75 lines in 39 files changed: 0 ins; 0 del; 75 mod

8303480: Miscellaneous fixes to mostly invisible doc comments

Reviewed-by: mullan, prr, cjplummer, aivanov, jjg, lancea, rriggs, ihse

-------------

PR: https://git.openjdk.org/jdk/pull/12826

From jwaters at openjdk.org  Tue Mar  7 15:59:33 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 7 Mar 2023 15:59:33 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v38]
In-Reply-To: <-460jAwuO1LachCE8nAzm_UsCGX8gyEH5kiU9ZnYSF0=.48af2d71-7e11-4692-88b6-c3fc009df04e@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <-460jAwuO1LachCE8nAzm_UsCGX8gyEH5kiU9ZnYSF0=.48af2d71-7e11-4692-88b6-c3fc009df04e@github.com>
Message-ID: <LEJn9mB93fQr74NyI4FsG2LlyKkB05SvXKL9cn5duso=.4d444299-7ee5-40ce-9b52-875c4623aa3a@github.com>

The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.

----------------------------------------------------------------------
On Tue, 25 Oct 2022 22:17:25 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wording
>
> This looks like nice work.
> 
> I'm curious how does this eclipse project figures out preprocessor settings like -D flags from the build to correctly setup the environment for the native code? I know this was a major deal when creating the compile-commands.json for other native IDE integrations. I've heard some IDEs just run the build once and inspect the command lines, but our default log level won't show that. I'm not familiar with eclipse project files, but I couldn't really see anything here that addressed this issue. Can you work with the native code in a meaningful way without it?

@erikj79 @magicus Seems like this is the best I can do for now, baseline support for Eclipse should now be present with these final touchups (Environment setup is not fully complete yet, but Eclipse is flexible enough that for most development work, this should not be too problematic). I do plan to refine support for it in the future, since there are still areas for improvement, but at present I think this should be decent enough for the time being

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From ihse at openjdk.org  Tue Mar  7 16:17:42 2023
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 7 Mar 2023 16:17:42 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v38]
In-Reply-To: <7iVD6lAYx6MEVxeWBu5p3OMLcrRbWH15EaMD0XXzi9k=.3e75d853-49cf-43a5-ac26-3cfa7b2bb224@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <7iVD6lAYx6MEVxeWBu5p3OMLcrRbWH15EaMD0XXzi9k=.3e75d853-49cf-43a5-ac26-3cfa7b2bb224@github.com>
Message-ID: <lCxTQR8e9TSYMIPWk_y5n6lI-NcBzmaD_HSx5wMzMfs=.4346b6be-4c59-47d3-96fa-bc226726a039@github.com>

On Mon, 6 Mar 2023 13:08:57 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
>> 
>> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
>> 
>> Indexing capabilities utilizing the enhancement:
>> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
>> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Wording

make/ide/eclipse/workspace.template line 4:

> 2: <projectDescription>
> 3:     <name>Java</name>
> 4:     <comment>The official Java HotSpot Virtual Machine, Runtime Environment, and Development Kit</comment>

Just call it OpenJDK; there is a legal trademark swamp associated with "Java".

make/ide/visualstudio/hotspot/CreateVSProject.gmk line 38:

> 36:   # able to extract flags, but we do not wish to execute the rules.
> 37: 
> 38:   # Use primary variant for defines and includes

This might be a correct fix but it is independent of this PR.

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Tue Mar  7 16:29:31 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 7 Mar 2023 16:29:31 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v38]
In-Reply-To: <lCxTQR8e9TSYMIPWk_y5n6lI-NcBzmaD_HSx5wMzMfs=.4346b6be-4c59-47d3-96fa-bc226726a039@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <7iVD6lAYx6MEVxeWBu5p3OMLcrRbWH15EaMD0XXzi9k=.3e75d853-49cf-43a5-ac26-3cfa7b2bb224@github.com>
 <lCxTQR8e9TSYMIPWk_y5n6lI-NcBzmaD_HSx5wMzMfs=.4346b6be-4c59-47d3-96fa-bc226726a039@github.com>
Message-ID: <d2NnVhILQoj_I1SUhmedvUAlsLsB9WAHFX-OIkaDwN0=.ca18c5e3-20a2-4a19-bcdd-fb7b320d9d2b@github.com>

On Tue, 7 Mar 2023 16:14:32 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wording
>
> make/ide/eclipse/workspace.template line 4:
> 
>> 2: <projectDescription>
>> 3:     <name>Java</name>
>> 4:     <comment>The official Java HotSpot Virtual Machine, Runtime Environment, and Development Kit</comment>
> 
> Just call it OpenJDK; there is a legal trademark swamp associated with "Java".

Got it, will also rename it to just jdk to match the cloned repository to be extra safe

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Tue Mar  7 16:44:26 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 7 Mar 2023 16:44:26 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v39]
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <GG3wzfnO74bwJAUcjyk6a-McPln3EshuEoME_ghrfvg=.ef80f435-01bf-49f2-808e-1de3d96327f7@github.com>

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Address Review and add extra comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10853/files
  - new: https://git.openjdk.org/jdk/pull/10853/files/13c0b9b9..2ceb46a0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=38
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=37-38

  Stats: 20 lines in 4 files changed: 13 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/10853.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Tue Mar  7 16:46:59 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 7 Mar 2023 16:46:59 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v38]
In-Reply-To: <lCxTQR8e9TSYMIPWk_y5n6lI-NcBzmaD_HSx5wMzMfs=.4346b6be-4c59-47d3-96fa-bc226726a039@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <7iVD6lAYx6MEVxeWBu5p3OMLcrRbWH15EaMD0XXzi9k=.3e75d853-49cf-43a5-ac26-3cfa7b2bb224@github.com>
 <lCxTQR8e9TSYMIPWk_y5n6lI-NcBzmaD_HSx5wMzMfs=.4346b6be-4c59-47d3-96fa-bc226726a039@github.com>
Message-ID: <ah86bMHv0SyzGU_LXS9Qo2OVewFLoWEzFeFJrgxx8eU=.5e27f132-8d1c-4fb3-bf08-c71ebaa5f672@github.com>

On Tue, 7 Mar 2023 16:14:57 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wording
>
> make/ide/visualstudio/hotspot/CreateVSProject.gmk line 38:
> 
>> 36:   # able to extract flags, but we do not wish to execute the rules.
>> 37: 
>> 38:   # Use primary variant for defines and includes
> 
> This might be a correct fix but it is independent of this PR.

Submitted https://bugs.openjdk.org/browse/JDK-8303760 and https://github.com/openjdk/jdk/pull/12906 to fix that issue separately

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Tue Mar  7 16:51:33 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 7 Mar 2023 16:51:33 GMT
Subject: RFR: 8303760: Visual Studio should use the primary variant in the IDE
Message-ID: <qDyUMQYDxJydaZzBQ0JiUF1GFmzcIR-Byi9zrxeIluk=.77a23db1-192d-4b40-be5e-c2eb35b39834@github.com>

Currently support for Visual Studio development always assumes server as the variant to use. More accurately this should instead be set to the primary variant instead

-------------

Commit messages:
 - Visual Studio should use the primary variant in the IDE

Changes: https://git.openjdk.org/jdk/pull/12906/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12906&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8303760
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/12906.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12906/head:pull/12906

PR: https://git.openjdk.org/jdk/pull/12906

From jwaters at openjdk.org  Thu Mar  9 08:28:17 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 9 Mar 2023 08:28:17 GMT
Subject: RFR: 8303760: Visual Studio should use the primary variant in the
 IDE
In-Reply-To: <qDyUMQYDxJydaZzBQ0JiUF1GFmzcIR-Byi9zrxeIluk=.77a23db1-192d-4b40-be5e-c2eb35b39834@github.com>
References: <qDyUMQYDxJydaZzBQ0JiUF1GFmzcIR-Byi9zrxeIluk=.77a23db1-192d-4b40-be5e-c2eb35b39834@github.com>
Message-ID: <QNCwEM2fMWHB0frRdjylniYInvxm_a1wY5tiyN7qvgg=.0ed32517-5980-40a1-9ef4-654c50b94b93@github.com>

On Tue, 7 Mar 2023 16:42:55 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Currently support for Visual Studio development always assumes server as the variant to use. More accurately this should instead be set to the primary variant instead

:(

-------------

PR: https://git.openjdk.org/jdk/pull/12906

From jwaters at openjdk.org  Thu Mar  9 08:28:21 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 9 Mar 2023 08:28:21 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v39]
In-Reply-To: <GG3wzfnO74bwJAUcjyk6a-McPln3EshuEoME_ghrfvg=.ef80f435-01bf-49f2-808e-1de3d96327f7@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <GG3wzfnO74bwJAUcjyk6a-McPln3EshuEoME_ghrfvg=.ef80f435-01bf-49f2-808e-1de3d96327f7@github.com>
Message-ID: <eNKkb3IpcKTEIDcxE9ZIZaknt1C5nJ37ILcYxgurQk4=.780cf1b5-2985-4092-834a-7f5fbce7acb1@github.com>

On Tue, 7 Mar 2023 16:44:26 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
>> 
>> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
>> 
>> Indexing capabilities utilizing the enhancement:
>> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
>> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address Review and add extra comments

:(

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Thu Mar  9 11:35:12 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 9 Mar 2023 11:35:12 GMT
Subject: RFR: 8303760: Visual Studio should use the primary variant in the
 IDE [v2]
In-Reply-To: <qDyUMQYDxJydaZzBQ0JiUF1GFmzcIR-Byi9zrxeIluk=.77a23db1-192d-4b40-be5e-c2eb35b39834@github.com>
References: <qDyUMQYDxJydaZzBQ0JiUF1GFmzcIR-Byi9zrxeIluk=.77a23db1-192d-4b40-be5e-c2eb35b39834@github.com>
Message-ID: <MNoZf7k5OXPSUqjd7CZ4CXi5_Hlb5ewAX236JaPWwz4=.71c6225e-b857-48f8-8546-401b1e81f8ff@github.com>

> Currently support for Visual Studio development always assumes server as the variant to use. More accurately this should instead be set to the primary variant instead

Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'openjdk:master' into patch-6
 - Visual Studio should use the primary variant in the IDE

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12906/files
  - new: https://git.openjdk.org/jdk/pull/12906/files/6ba7854d..a0d7b65d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12906&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12906&range=00-01

  Stats: 3507 lines in 138 files changed: 2500 ins; 563 del; 444 mod
  Patch: https://git.openjdk.org/jdk/pull/12906.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12906/head:pull/12906

PR: https://git.openjdk.org/jdk/pull/12906

From erikj at openjdk.org  Thu Mar  9 15:57:32 2023
From: erikj at openjdk.org (Erik Joelsson)
Date: Thu, 9 Mar 2023 15:57:32 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v39]
In-Reply-To: <GG3wzfnO74bwJAUcjyk6a-McPln3EshuEoME_ghrfvg=.ef80f435-01bf-49f2-808e-1de3d96327f7@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <GG3wzfnO74bwJAUcjyk6a-McPln3EshuEoME_ghrfvg=.ef80f435-01bf-49f2-808e-1de3d96327f7@github.com>
Message-ID: <BdAYeUNXi_U4xaHk7bJWS0kkPhIpm9byuv3_nHs5Hgc=.4c892355-87e2-45d3-8cc5-447f2f077fb7@github.com>

On Tue, 7 Mar 2023 16:44:26 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
>> 
>> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
>> 
>> Indexing capabilities utilizing the enhancement:
>> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
>> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address Review and add extra comments

Functionally this looks ok to me, just some comment on cosmetics.

doc/ide.md line 94:

> 92: indexing the Java sources in the JDK (see below), is to enable dark mode
> 93: before doing so. Trust us, it looks much better than Eclipse's default look
> 94: and feel. ;)

Does this change how Eclipse functions with our sources in any way, or is it just your opinion that it looks better? If the latter, then I don't think it really belongs in this document.

make/ide/eclipse/CreateWorkspace.gmk line 40:

> 38: include hotspot/lib/JvmFlags.gmk
> 39: 
> 40: # Warning: This file does not have the best formatting!

Is this still true? If so, we should fix that so the comment can be removed.

After having read through the file. I find quite a few places where broken up lines have 2 space indentation instead of 4. (See https://openjdk.org/groups/build/doc/code-conventions.html) Fixing this should be pretty quick and simple and will greatly improve readability at least for me and Magnus. I will mark some of the typical cases for you.

make/ide/eclipse/CreateWorkspace.gmk line 60:

> 58: # Taken from JdkNativeCompilation.gmk
> 59: FindJavaHeaderDir = \
> 60:   $(if $(strip $1),$(wildcard $(SUPPORT_OUTPUTDIR)/headers/$(strip $1)))

Indent 4.

make/ide/eclipse/CreateWorkspace.gmk line 64:

> 62: JAVA_DIRS := $(strip $(foreach module, $(call FindAllModules), \
> 63:   $(patsubst $(TOPDIR)/%,%,$(filter-out $(OUTPUTDIR)%, \
> 64:   $(call FindModuleSrcDirs, $(module))))))

Indent 4.

make/ide/eclipse/CreateWorkspace.gmk line 134:

> 132:     # This is an annoying bug that has not been fixed for some time now
> 133:     $1_CLASSPATH += $$(foreach src,$(JAVA_DIRS), \
> 134:       <classpathentry excluding="module-info.java|module-info.java.extra" kind="src" path="$$(src)"/>$$(NEWLINE))

Indent 4.

make/ide/eclipse/CreateWorkspace.gmk line 141:

> 139:       REPLACEMENTS := \
> 140:           @@CLASSPATH@@ => $$($1_CLASSPATH), \
> 141:     ))

Indent 4.

make/ide/eclipse/CreateWorkspace.gmk line 154:

> 152: 
> 153:     $1_BUILD_MANAGERS += \
> 154:       <buildCommand> \

Indent 4.

make/ide/eclipse/CreateWorkspace.gmk line 168:

> 166: 
> 167:     $1_NATURES += \
> 168:       <nature>org.eclipse.cdt.core.cnature</nature> \

Indent 4.

make/ide/eclipse/CreateWorkspace.gmk line 233:

> 231:           @@SRC@@ => $$($1_NATIVE_SRCS) ; \
> 232:           @@MAKE_TARGETS@@ => $$($1_MATCHING_MAKE_TARGETS), \
> 233:     ))

Suggestion:

    $$(eval $$(call SetupTextFileProcessing, $1_CREATE_NATIVE_FILE, \
        SOURCE_FILES := $(TOPDIR)/make/ide/eclipse/native.template, \
        OUTPUT_FILE := $$($1_NATIVE_FILE), \
        REPLACEMENTS := \
            @@DIR@@ => $$(call FixPath, $(TOPDIR)) ; \
            @@ENV@@ => $$($1_ENV) ; \
            @@WORKSPACE@@ => $$($1_WORKSPACE_MAJOR) ; \
            @@MINOR@@ =>  $$($1_WORKSPACE_MINOR) ; \
            @@MAKE@@ => $$($1_MAKE) ; \
            @@SRC@@ => $$($1_NATIVE_SRCS) ; \
            @@MAKE_TARGETS@@ => $$($1_MATCHING_MAKE_TARGETS), \
    ))

make/ide/eclipse/CreateWorkspace.gmk line 315:

> 313:           @@CSETTINGS@@ => $$($1_CSETTINGS) ; \
> 314:           @@CXXSETTINGS@@ => $$($1_CXXSETTINGS), \
> 315:     ))

Suggestion:

    $$(eval $$(call SetupTextFileProcessing, $1_CREATE_SETTINGS_FILE, \
        SOURCE_FILES := $(TOPDIR)/make/ide/eclipse/settings.template, \
        OUTPUT_FILE := $$($1_SETTINGS_FILE), \
        REPLACEMENTS := \
            @@WORKSPACE@@ => $$($1_WORKSPACE_MAJOR) ; \
            @@CSETTINGS@@ => $$($1_CSETTINGS) ; \
            @@CXXSETTINGS@@ => $$($1_CXXSETTINGS), \
    ))

make/ide/eclipse/CreateWorkspace.gmk line 364:

> 362:         @@NATURES@@ => $$($1_NATURES) ; \
> 363:         @@LINKED_RESOURCES@@ => $$($1_LINKED_RESOURCES), \
> 364:   ))

Suggestion:

  $$(eval $$(call SetupTextFileProcessing, $1_CREATE_WORKSPACE_FILE, \
      SOURCE_FILES := $(TOPDIR)/make/ide/eclipse/workspace.template, \
      OUTPUT_FILE := $$($1_WORKSPACE_FILE), \
      REPLACEMENTS := \
          @@BUILD_MANAGERS@@ => $$($1_BUILD_MANAGERS) ; \
          @@NATURES@@ => $$($1_NATURES) ; \
          @@LINKED_RESOURCES@@ => $$($1_LINKED_RESOURCES), \
  ))

make/ide/eclipse/CreateWorkspace.gmk line 390:

> 388:   SHARED := $(SHARED), \
> 389: ))
> 390: endif

The lack of indentation makes this hard to read. This is how I would like the first block to look:

ifeq ($(WORKSPACE), java)
  $(eval $(call SetupEclipseWorkspace, SETUP_WORKSPACE, \
      NATURE := JAVA, \
      SHARED := $(SHARED), \
  ))
else ...

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From erikj at openjdk.org  Thu Mar  9 16:01:22 2023
From: erikj at openjdk.org (Erik Joelsson)
Date: Thu, 9 Mar 2023 16:01:22 GMT
Subject: RFR: 8303760: Visual Studio should use the primary variant in the
 IDE [v2]
In-Reply-To: <MNoZf7k5OXPSUqjd7CZ4CXi5_Hlb5ewAX236JaPWwz4=.71c6225e-b857-48f8-8546-401b1e81f8ff@github.com>
References: <qDyUMQYDxJydaZzBQ0JiUF1GFmzcIR-Byi9zrxeIluk=.77a23db1-192d-4b40-be5e-c2eb35b39834@github.com>
 <MNoZf7k5OXPSUqjd7CZ4CXi5_Hlb5ewAX236JaPWwz4=.71c6225e-b857-48f8-8546-401b1e81f8ff@github.com>
Message-ID: <YJLOqgKXiXCtAYc0yPqyfd-sqDYdz5M_TtyOK4_C1jg=.ca5ba920-f92a-415d-bc33-e663a7e170dc@github.com>

On Thu, 9 Mar 2023 11:35:12 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Currently support for Visual Studio development always assumes server as the variant to use. More accurately this should instead be set to the primary variant instead
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-6
>  - Visual Studio should use the primary variant in the IDE

Marked as reviewed by erikj (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/12906

From jwaters at openjdk.org  Thu Mar  9 16:07:08 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 9 Mar 2023 16:07:08 GMT
Subject: RFR: 8303760: Visual Studio should use the primary variant in the
 IDE [v2]
In-Reply-To: <MNoZf7k5OXPSUqjd7CZ4CXi5_Hlb5ewAX236JaPWwz4=.71c6225e-b857-48f8-8546-401b1e81f8ff@github.com>
References: <qDyUMQYDxJydaZzBQ0JiUF1GFmzcIR-Byi9zrxeIluk=.77a23db1-192d-4b40-be5e-c2eb35b39834@github.com>
 <MNoZf7k5OXPSUqjd7CZ4CXi5_Hlb5ewAX236JaPWwz4=.71c6225e-b857-48f8-8546-401b1e81f8ff@github.com>
Message-ID: <UnwUfeYEIAHdpFL-Yro-PPjwrKAAQUv5DoavBN8yinI=.a76a7832-94ee-40e7-9530-c3d457c2c56c@github.com>

The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.

----------------------------------------------------------------------
On Thu, 9 Mar 2023 11:35:12 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Currently support for Visual Studio development always assumes server as the variant to use. More accurately this should instead be set to the primary variant instead
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-6
>  - Visual Studio should use the primary variant in the IDE

Thanks Erik!

-------------

PR: https://git.openjdk.org/jdk/pull/12906

From jwaters at openjdk.org  Thu Mar  9 16:10:50 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 9 Mar 2023 16:10:50 GMT
Subject: Integrated: 8303760: Visual Studio should use the primary variant in
 the IDE
In-Reply-To: <qDyUMQYDxJydaZzBQ0JiUF1GFmzcIR-Byi9zrxeIluk=.77a23db1-192d-4b40-be5e-c2eb35b39834@github.com>
References: <qDyUMQYDxJydaZzBQ0JiUF1GFmzcIR-Byi9zrxeIluk=.77a23db1-192d-4b40-be5e-c2eb35b39834@github.com>
Message-ID: <wkGDkNOcdas6oWUTY_XzpInl7YIYlWnrCIyqH-2g4gc=.039cd1e4-d952-4743-a909-5e3e989325d6@github.com>

On Tue, 7 Mar 2023 16:42:55 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Currently support for Visual Studio development always assumes server as the variant to use. More accurately this should instead be set to the primary variant instead

This pull request has now been integrated.

Changeset: 3227b49a
Author:    Julian Waters <jwaters at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3227b49a7ab5c7a71b5c0a87f3a6984d4b528589
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8303760: Visual Studio should use the primary variant in the IDE

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/jdk/pull/12906

From jwaters at openjdk.org  Thu Mar  9 18:13:54 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 9 Mar 2023 18:13:54 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v40]
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <CNOb_RHhpzln6IxL_1uHeWZbUosLJvsOno6YddbDaBs=.dbf2b44f-07f0-48ae-b7f3-e24b1658aa99@github.com>

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

Julian Waters has updated the pull request incrementally with three additional commits since the last revision:

 - make/ide/eclipse/CreateWorkspace.gmk
   
   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
 - make/ide/eclipse/CreateWorkspace.gmk
   
   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
 - make/ide/eclipse/CreateWorkspace.gmk
   
   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10853/files
  - new: https://git.openjdk.org/jdk/pull/10853/files/2ceb46a0..61a97a24

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=39
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=38-39

  Stats: 22 lines in 1 file changed: 0 ins; 0 del; 22 mod
  Patch: https://git.openjdk.org/jdk/pull/10853.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Fri Mar 10 15:02:13 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Fri, 10 Mar 2023 15:02:13 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v41]
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <zS1J2q4E0I8wIXqQ7ks_IrWpWjkjCHoeFVEEma3n6iM=.b4a0c649-ad67-47c5-9e02-f6abe352d23e@github.com>

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Indents

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10853/files
  - new: https://git.openjdk.org/jdk/pull/10853/files/61a97a24..f3dd3795

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=40
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=39-40

  Stats: 55 lines in 1 file changed: 0 ins; 0 del; 55 mod
  Patch: https://git.openjdk.org/jdk/pull/10853.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Fri Mar 10 15:09:06 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Fri, 10 Mar 2023 15:09:06 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v42]
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <d4gludjGOnvut4Oyp4Sif1qT3eXPn6LeTFTVvvj9RYQ=.8e3e8735-1755-41e9-a6c9-1ec7bb9405d9@github.com>

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  More Indents

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10853/files
  - new: https://git.openjdk.org/jdk/pull/10853/files/f3dd3795..85931832

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=41
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=40-41

  Stats: 43 lines in 1 file changed: 0 ins; 0 del; 43 mod
  Patch: https://git.openjdk.org/jdk/pull/10853.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Fri Mar 10 15:09:09 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Fri, 10 Mar 2023 15:09:09 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v41]
In-Reply-To: <zS1J2q4E0I8wIXqQ7ks_IrWpWjkjCHoeFVEEma3n6iM=.b4a0c649-ad67-47c5-9e02-f6abe352d23e@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <zS1J2q4E0I8wIXqQ7ks_IrWpWjkjCHoeFVEEma3n6iM=.b4a0c649-ad67-47c5-9e02-f6abe352d23e@github.com>
Message-ID: <5PV1SqtmayZ63RBhyaEDvVsOh6bi8YNO-mwBNdV5xHQ=.583822bc-51ab-4ef3-84ce-46fa46dfb4f0@github.com>

On Fri, 10 Mar 2023 15:02:13 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
>> 
>> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
>> 
>> Indexing capabilities utilizing the enhancement:
>> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
>> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Indents

Alright, that should be all of them

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Fri Mar 10 15:12:15 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Fri, 10 Mar 2023 15:12:15 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v39]
In-Reply-To: <BdAYeUNXi_U4xaHk7bJWS0kkPhIpm9byuv3_nHs5Hgc=.4c892355-87e2-45d3-8cc5-447f2f077fb7@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <GG3wzfnO74bwJAUcjyk6a-McPln3EshuEoME_ghrfvg=.ef80f435-01bf-49f2-808e-1de3d96327f7@github.com>
 <BdAYeUNXi_U4xaHk7bJWS0kkPhIpm9byuv3_nHs5Hgc=.4c892355-87e2-45d3-8cc5-447f2f077fb7@github.com>
Message-ID: <LgEm2xFb_qpUbLwpMZVpjNfsZcAiAhYdtKav1wjSzSo=.dfcece62-4a1b-4963-a2e9-43b8d583b8dc@github.com>

On Thu, 9 Mar 2023 15:31:51 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address Review and add extra comments
>
> doc/ide.md line 94:
> 
>> 92: indexing the Java sources in the JDK (see below), is to enable dark mode
>> 93: before doing so. Trust us, it looks much better than Eclipse's default look
>> 94: and feel. ;)
> 
> Does this change how Eclipse functions with our sources in any way, or is it just your opinion that it looks better? If the latter, then I don't think it really belongs in this document.

Ah, was hoping that I could leave a personal touch in there. No matter, I'll remove it if required

> make/ide/eclipse/CreateWorkspace.gmk line 40:
> 
>> 38: include hotspot/lib/JvmFlags.gmk
>> 39: 
>> 40: # Warning: This file does not have the best formatting!
> 
> Is this still true? If so, we should fix that so the comment can be removed.
> 
> After having read through the file. I find quite a few places where broken up lines have 2 space indentation instead of 4. (See https://openjdk.org/groups/build/doc/code-conventions.html) Fixing this should be pretty quick and simple and will greatly improve readability at least for me and Magnus. I will mark some of the typical cases for you.

Not anymore, at least I would hope not. This was back when everything in the file was completely generated by handwritten printing and is not up to date any longer

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From erikj at openjdk.org  Mon Mar 13 13:34:05 2023
From: erikj at openjdk.org (Erik Joelsson)
Date: Mon, 13 Mar 2023 13:34:05 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v39]
In-Reply-To: <LgEm2xFb_qpUbLwpMZVpjNfsZcAiAhYdtKav1wjSzSo=.dfcece62-4a1b-4963-a2e9-43b8d583b8dc@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <GG3wzfnO74bwJAUcjyk6a-McPln3EshuEoME_ghrfvg=.ef80f435-01bf-49f2-808e-1de3d96327f7@github.com>
 <BdAYeUNXi_U4xaHk7bJWS0kkPhIpm9byuv3_nHs5Hgc=.4c892355-87e2-45d3-8cc5-447f2f077fb7@github.com>
 <LgEm2xFb_qpUbLwpMZVpjNfsZcAiAhYdtKav1wjSzSo=.dfcece62-4a1b-4963-a2e9-43b8d583b8dc@github.com>
Message-ID: <EJR57XWtScvc4tZzdAQeTDCR-gChtx42L5rUXzu0Gy0=.b26629ab-15a0-47ab-a198-d946b9e60b73@github.com>

On Fri, 10 Mar 2023 15:08:55 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> doc/ide.md line 94:
>> 
>>> 92: indexing the Java sources in the JDK (see below), is to enable dark mode
>>> 93: before doing so. Trust us, it looks much better than Eclipse's default look
>>> 94: and feel. ;)
>> 
>> Does this change how Eclipse functions with our sources in any way, or is it just your opinion that it looks better? If the latter, then I don't think it really belongs in this document.
>
> Ah, was hoping that I could leave a personal touch in there. No matter, I'll remove it if required

Please remove it.

>> make/ide/eclipse/CreateWorkspace.gmk line 40:
>> 
>>> 38: include hotspot/lib/JvmFlags.gmk
>>> 39: 
>>> 40: # Warning: This file does not have the best formatting!
>> 
>> Is this still true? If so, we should fix that so the comment can be removed.
>> 
>> After having read through the file. I find quite a few places where broken up lines have 2 space indentation instead of 4. (See https://openjdk.org/groups/build/doc/code-conventions.html) Fixing this should be pretty quick and simple and will greatly improve readability at least for me and Magnus. I will mark some of the typical cases for you.
>
> Not anymore, at least I would hope not. This was back when everything in the file was completely generated by handwritten printing and is not up to date any longer

I found just one more missed indentation. It looks much better to me now. Could you also remove this comment, as it's not relevant anymore.

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From erikj at openjdk.org  Mon Mar 13 13:34:08 2023
From: erikj at openjdk.org (Erik Joelsson)
Date: Mon, 13 Mar 2023 13:34:08 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v42]
In-Reply-To: <d4gludjGOnvut4Oyp4Sif1qT3eXPn6LeTFTVvvj9RYQ=.8e3e8735-1755-41e9-a6c9-1ec7bb9405d9@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <d4gludjGOnvut4Oyp4Sif1qT3eXPn6LeTFTVvvj9RYQ=.8e3e8735-1755-41e9-a6c9-1ec7bb9405d9@github.com>
Message-ID: <Np109ZRu64QKQGLwo1h0nS9zBiaMu7nxZF-DFZ3AKHM=.c0b11934-023e-4f38-9e1a-9ef6a60968db@github.com>

On Fri, 10 Mar 2023 15:09:06 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
>> 
>> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
>> 
>> Indexing capabilities utilizing the enhancement:
>> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
>> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More Indents

make/ide/eclipse/CreateWorkspace.gmk line 269:

> 267:     ifeq ($$($1_NATURE), HOTSPOT)
> 268:       $1_CXXSETTINGS += $$(foreach src, $$(strip $$(patsubst %,%/include,$$(call FindModuleNativeDirs, java.base))), \
> 269:         $(X)    $(X)<entry flags="LOCAL" kind="includePath" name="$$(call FixPath, $$(src))"/>$$(NEWLINE))

Indent 4.

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Mon Mar 13 14:24:49 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 13 Mar 2023 14:24:49 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v43]
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <cBIJlU-PeBvecVTso3HXujntstGj7UbMyNNQOrPOQdg=.f9d9152b-4b7a-4794-814b-0f1d84e9b42b@github.com>

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10853/files
  - new: https://git.openjdk.org/jdk/pull/10853/files/85931832..99ea34d8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=42
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10853&range=41-42

  Stats: 12 lines in 3 files changed: 0 ins; 11 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/10853.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10853/head:pull/10853

PR: https://git.openjdk.org/jdk/pull/10853

From erikj at openjdk.org  Tue Mar 14 13:11:06 2023
From: erikj at openjdk.org (Erik Joelsson)
Date: Tue, 14 Mar 2023 13:11:06 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v43]
In-Reply-To: <cBIJlU-PeBvecVTso3HXujntstGj7UbMyNNQOrPOQdg=.f9d9152b-4b7a-4794-814b-0f1d84e9b42b@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <cBIJlU-PeBvecVTso3HXujntstGj7UbMyNNQOrPOQdg=.f9d9152b-4b7a-4794-814b-0f1d84e9b42b@github.com>
Message-ID: <3SFqr1pgKem4-KqUeeAyfclwuh7kmySQhkNvP4o7h2E=.99b8e7c3-991b-4f63-9af6-1a79585b17b5@github.com>

On Mon, 13 Mar 2023 14:24:49 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
>> 
>> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
>> 
>> Indexing capabilities utilizing the enhancement:
>> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
>> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review

Marked as reviewed by erikj (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Tue Mar 14 14:26:03 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 14 Mar 2023 14:26:03 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v43]
In-Reply-To: <cBIJlU-PeBvecVTso3HXujntstGj7UbMyNNQOrPOQdg=.f9d9152b-4b7a-4794-814b-0f1d84e9b42b@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <cBIJlU-PeBvecVTso3HXujntstGj7UbMyNNQOrPOQdg=.f9d9152b-4b7a-4794-814b-0f1d84e9b42b@github.com>
Message-ID: <SVCKIiG8pHo6ytIPxT_Az-7KxITRs-5HXmEcmeu6MCw=.95e9e293-cab4-440a-bed7-0be945cb307e@github.com>

On Mon, 13 Mar 2023 14:24:49 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
>> 
>> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
>> 
>> Indexing capabilities utilizing the enhancement:
>> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
>> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review

Thanks Erik!

@magicus is this final revision ok with you?

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Tue Mar 14 17:36:11 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 14 Mar 2023 17:36:11 GMT
Subject: RFR: 8295884: Implement IDE support for Eclipse [v43]
In-Reply-To: <cBIJlU-PeBvecVTso3HXujntstGj7UbMyNNQOrPOQdg=.f9d9152b-4b7a-4794-814b-0f1d84e9b42b@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
 <cBIJlU-PeBvecVTso3HXujntstGj7UbMyNNQOrPOQdg=.f9d9152b-4b7a-4794-814b-0f1d84e9b42b@github.com>
Message-ID: <bZZ4ltn3BFvWRUJuUy2MIXDM7bELCYzXyzYG2PqCSIE=.ce779f68-4dfb-4ed7-884b-9ff58b205ccb@github.com>

On Mon, 13 Mar 2023 14:24:49 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
>> 
>> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
>> 
>> Indexing capabilities utilizing the enhancement:
>> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
>> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review

Sorry this took so long, for everyone that was waiting for this. Do note that C support may still be a little wonky in some cases, if there are any bugs do feel free to send me a message in this Pull Request (doesn't matter that it's already been integrated)

-------------

PR: https://git.openjdk.org/jdk/pull/10853

From jwaters at openjdk.org  Tue Mar 14 17:36:14 2023
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 14 Mar 2023 17:36:14 GMT
Subject: Integrated: 8295884: Implement IDE support for Eclipse
In-Reply-To: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
References: <zGkxT4ajd4aCpTWZw3uXY5VHMAoBjEc7UBInHd_mAA0=.32e6143f-c24d-464f-ab28-0dbc84b08c30@github.com>
Message-ID: <OD2lSOxyjZRTkegx4iiqn8CJNFxDk-WmB4gtkryzk-Y=.6f020672-5375-4e88-8296-f2dc6111a53e@github.com>

On Tue, 25 Oct 2022 13:23:34 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, among which are make integration. While the tools it provides are not always as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as one such competitor), the simplicity of using it, as well as the reliability of this rugged IDE makes up greatly for the slightly less advanced tooling. Eclipse requires very little starting infrastructure in the workspace for all these features and indexing support as well, which makes it a good candidate for developing on the JDK.
> 
> This enhancement adds 4 extra targets to the make system for generating a basic Eclipse Workspace that provides almost full indexing support for the JDK, with varying levels as desired, from a minimalistic option only including the Java Virtual Machine's source code, to generating a workspace with both Java and C/C++ natures included, which allows for using Eclipse's unique ability to quickly swap between Java and C/C++ mode to work on both native and Java sources at the same time. Cross Compiling support is available, and in its entirety the change touches very little of the existing make system, barring its own Makefile within the ide subdirectory.
> 
> Indexing capabilities utilizing the enhancement:
> <img width="960" alt="java" src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG">
> <img width="787" alt="escape" src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG">

This pull request has now been integrated.

Changeset: 45809fd0
Author:    Julian Waters <jwaters at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/45809fd0c026dfab2aa004ca425017ec7891d2e6
Stats:     687 lines in 9 files changed: 687 ins; 0 del; 0 mod

8295884: Implement IDE support for Eclipse

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/jdk/pull/10853