From jwaters at openjdk.org  Tue Apr 29 15:41:02 2025
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 29 Apr 2025 15:41:02 GMT
Subject: RFR: 8354919: Move HotSpot .editorconfig into the global
 .editorconfig
In-Reply-To: <YNeNhtX_fr-N8nEfdMV0tNc_IAwTCU_ypvXYX_vZyec=.2a0f4858-cfce-4350-950c-436248cad08c@github.com>
References: <YNeNhtX_fr-N8nEfdMV0tNc_IAwTCU_ypvXYX_vZyec=.2a0f4858-cfce-4350-950c-436248cad08c@github.com>
Message-ID: <J9PeKoaqBDZCnarUN_ikXoY_L5bNI_OZZlXzkhU7xpw=.037c7439-3edf-4755-91b5-904748190f5b@github.com>

On Thu, 17 Apr 2025 07:28:03 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> The src/hotspot directory should ideally only be used for HotSpot source files, and we should avoid polluting it with an .editorconfig. A cleaner solution exists since we can just specify the desired code formatting for HotSpot as an override in the root .editorconfig

To address Sergey's concerns, testing on my end _seems_ to indicate that it does inherit the whitespace option. Since this is not a serious breaking change, I'm going to integrate it. If it turns out to break editor formatting for someone somewhere, we can easily back this out later

Oops, before I integrate, this should have the ide-support flag too

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24714#issuecomment-2839366874
PR Comment: https://git.openjdk.org/jdk/pull/24714#issuecomment-2839369944

From jwaters at openjdk.org  Tue Apr 29 15:41:02 2025
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 29 Apr 2025 15:41:02 GMT
Subject: Integrated: 8354919: Move HotSpot .editorconfig into the global
 .editorconfig
In-Reply-To: <YNeNhtX_fr-N8nEfdMV0tNc_IAwTCU_ypvXYX_vZyec=.2a0f4858-cfce-4350-950c-436248cad08c@github.com>
References: <YNeNhtX_fr-N8nEfdMV0tNc_IAwTCU_ypvXYX_vZyec=.2a0f4858-cfce-4350-950c-436248cad08c@github.com>
Message-ID: <3DviS8uB6Ob0amR92RBdjORmWGngsT61iUeGt640tWY=.26ba3aa3-9aa5-4c52-b6a8-e412a96371e9@github.com>

On Thu, 17 Apr 2025 07:28:03 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> The src/hotspot directory should ideally only be used for HotSpot source files, and we should avoid polluting it with an .editorconfig. A cleaner solution exists since we can just specify the desired code formatting for HotSpot as an override in the root .editorconfig

This pull request has now been integrated.

Changeset: fa2a9d1e
Author:    Julian Waters <jwaters at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fa2a9d1e10679aad270f4641f43595b36fe8e04c
Stats:     7 lines in 2 files changed: 4 ins; 3 del; 0 mod

8354919: Move HotSpot .editorconfig into the global .editorconfig

Reviewed-by: erikj, ihse

-------------

PR: https://git.openjdk.org/jdk/pull/24714