From mhaessig at openjdk.org Wed Aug 13 13:30:47 2025 From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=) Date: Wed, 13 Aug 2025 13:30:47 GMT Subject: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension Message-ID: This PR adds a basic configuration for the [Oracle Java VSCode extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) to the `vscode-project-*` targets. ------------- Commit messages: - make/ide/vscode: add basic configuration for Oracle Java extension Changes: https://git.openjdk.org/jdk/pull/26759/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26759&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8365491 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/26759.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26759/head:pull/26759 PR: https://git.openjdk.org/jdk/pull/26759 From jlahoda at openjdk.org Wed Aug 13 14:11:10 2025 From: jlahoda at openjdk.org (Jan Lahoda) Date: Wed, 13 Aug 2025 14:11:10 GMT Subject: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension In-Reply-To: References: Message-ID: <99y0kw0loER23cXnLl2k88BEVY7XorBViF6SGADgNRY=.09ee46af-2a6b-4c95-8d26-f76117bb1f7f@github.com> On Wed, 13 Aug 2025 13:22:21 GMT, Manuel H?ssig wrote: > This PR adds a basic configuration for the [Oracle Java VSCode extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) to the `vscode-project-*` targets. Looks like a reasonable direction to me. I would suggest to drop: "jdk.advanced.disable.nbjavac": true, while it may be good for some, it may lead to surprising effects for others people that don't know about this setting. Also, including: "jdk.java.onSave.organizeImports": false might make sense. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26759#issuecomment-3184094444 From mhaessig at openjdk.org Wed Aug 13 14:23:37 2025 From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=) Date: Wed, 13 Aug 2025 14:23:37 GMT Subject: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v2] In-Reply-To: References: Message-ID: <_HedHy5F966CKB-J_xRbvt_gLfCk9BIlNvk5H5WpwHc=.2b9e787f-64be-4cb5-9ce4-5c6907ac4b28@github.com> > This PR adds a basic configuration for the [Oracle Java VSCode extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) to the `vscode-project-*` targets. Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision: Prevent organizing imports ------------- Changes: - all: https://git.openjdk.org/jdk/pull/26759/files - new: https://git.openjdk.org/jdk/pull/26759/files/6a4d9efb..277a590d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=26759&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26759&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/26759.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26759/head:pull/26759 PR: https://git.openjdk.org/jdk/pull/26759 From mhaessig at openjdk.org Wed Aug 13 14:27:12 2025 From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=) Date: Wed, 13 Aug 2025 14:27:12 GMT Subject: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension In-Reply-To: <99y0kw0loER23cXnLl2k88BEVY7XorBViF6SGADgNRY=.09ee46af-2a6b-4c95-8d26-f76117bb1f7f@github.com> References: <99y0kw0loER23cXnLl2k88BEVY7XorBViF6SGADgNRY=.09ee46af-2a6b-4c95-8d26-f76117bb1f7f@github.com> Message-ID: On Wed, 13 Aug 2025 14:08:56 GMT, Jan Lahoda wrote: > I would suggest to drop: `"jdk.advanced.disable.nbjavac": true,` Can you elaborate on the surprising results? When developing the JDK we will most probably use features not supported by the `nbjavac`. > Also, including:`"jdk.java.onSave.organizeImports": false` might make sense. Good point. That will lead to unwanted changes if true. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26759#issuecomment-3184151430 From duke at openjdk.org Thu Aug 14 11:25:00 2025 From: duke at openjdk.org (David Beaumont) Date: Thu, 14 Aug 2025 11:25:00 GMT Subject: RFR: 8365048: idea.sh script does not correctly detect/handle git worktrees Message-ID: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> Allows files or directories called .git to indicate likely use of Git for VCS in IntelliJ. Tested locally in a worktree and normal repository. It produces: in both cases, as expected. ------------- Commit messages: - Simple fix (just checking file) Changes: https://git.openjdk.org/jdk/pull/26777/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26777&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8365048 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/26777.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26777/head:pull/26777 PR: https://git.openjdk.org/jdk/pull/26777 From vyazici at openjdk.org Thu Aug 14 12:03:12 2025 From: vyazici at openjdk.org (Volkan Yazici) Date: Thu, 14 Aug 2025 12:03:12 GMT Subject: RFR: 8365048: idea.sh script does not correctly detect/handle git worktrees In-Reply-To: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> References: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> Message-ID: On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote: > Allows files or directories called .git to indicate likely use of Git for VCS in IntelliJ. > Tested locally in a worktree and normal repository. It produces: > > > > > > > in both cases, as expected. Marked as reviewed by vyazici (Committer). ------------- PR Review: https://git.openjdk.org/jdk/pull/26777#pullrequestreview-3120319106 From erikj at openjdk.org Thu Aug 14 12:57:12 2025 From: erikj at openjdk.org (Erik Joelsson) Date: Thu, 14 Aug 2025 12:57:12 GMT Subject: RFR: 8365048: idea.sh script does not correctly detect/handle git worktrees In-Reply-To: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> References: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> Message-ID: On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote: > Allows files or directories called .git to indicate likely use of Git for VCS in IntelliJ. > Tested locally in a worktree and normal repository. It produces: > > > > > > > in both cases, as expected. Marked as reviewed by erikj (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/26777#pullrequestreview-3120484397 From mcimadamore at openjdk.org Thu Aug 14 14:09:15 2025 From: mcimadamore at openjdk.org (Maurizio Cimadamore) Date: Thu, 14 Aug 2025 14:09:15 GMT Subject: RFR: 8365048: idea.sh script does not correctly detect/handle git worktrees In-Reply-To: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> References: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> Message-ID: On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote: > Allows files or directories called .git to indicate likely use of Git for VCS in IntelliJ. > Tested locally in a worktree and normal repository. It produces: > > > > > > > in both cases, as expected. Marked as reviewed by mcimadamore (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/26777#pullrequestreview-3120743925 From shade at openjdk.org Thu Aug 14 14:57:14 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 14 Aug 2025 14:57:14 GMT Subject: RFR: 8365048: idea.sh script does not correctly detect/handle git worktrees In-Reply-To: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> References: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> Message-ID: On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote: > Allows files or directories called .git to indicate likely use of Git for VCS in IntelliJ. > Tested locally in a worktree and normal repository. It produces: > > > > > > > in both cases, as expected. bin/idea.sh line 128: > 126: fi > 127: > 128: # Git workstrees use a '.git' file rather than directory, so test both. Suggestion: # Git worktrees use a '.git' file rather than directory, so test both. Right? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26777#discussion_r2276874741 From ihse at openjdk.org Thu Aug 14 15:10:14 2025 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Thu, 14 Aug 2025 15:10:14 GMT Subject: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v2] In-Reply-To: <_HedHy5F966CKB-J_xRbvt_gLfCk9BIlNvk5H5WpwHc=.2b9e787f-64be-4cb5-9ce4-5c6907ac4b28@github.com> References: <_HedHy5F966CKB-J_xRbvt_gLfCk9BIlNvk5H5WpwHc=.2b9e787f-64be-4cb5-9ce4-5c6907ac4b28@github.com> Message-ID: On Wed, 13 Aug 2025 14:23:37 GMT, Manuel H?ssig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) to the `vscode-project-*` targets. > > Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision: > > Prevent organizing imports It's hard to say exactly if these changes are what is needed, but they look sane, and if you have verified that it works then I'm okay with it. Thanks for improving the IDE support! ------------- Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26759#pullrequestreview-3120966144 From ihse at openjdk.org Thu Aug 14 15:15:15 2025 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Thu, 14 Aug 2025 15:15:15 GMT Subject: RFR: 8365048: idea.sh script does not correctly detect/handle git worktrees In-Reply-To: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> References: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> Message-ID: On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote: > Allows files or directories called .git to indicate likely use of Git for VCS in IntelliJ. > Tested locally in a worktree and normal repository. It produces: > > > > > > > in both cases, as expected. LGTM, if you fix the typo in the comment. ------------- Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26777#pullrequestreview-3120977831 From duke at openjdk.org Thu Aug 14 15:15:17 2025 From: duke at openjdk.org (David Beaumont) Date: Thu, 14 Aug 2025 15:15:17 GMT Subject: RFR: 8365048: idea.sh script does not correctly detect/handle git worktrees In-Reply-To: References: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> Message-ID: On Thu, 14 Aug 2025 14:54:43 GMT, Aleksey Shipilev wrote: >> Allows files or directories called .git to indicate likely use of Git for VCS in IntelliJ. >> Tested locally in a worktree and normal repository. It produces: >> >> >> >> >> >> >> in both cases, as expected. > > bin/idea.sh line 128: > >> 126: fi >> 127: >> 128: # Git workstrees use a '.git' file rather than directory, so test both. > > Suggestion: > > # Git worktrees use a '.git' file rather than directory, so test both. > > > Right? *doh* - thanks ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26777#discussion_r2276919398 From duke at openjdk.org Thu Aug 14 15:21:29 2025 From: duke at openjdk.org (David Beaumont) Date: Thu, 14 Aug 2025 15:21:29 GMT Subject: RFR: 8365048: idea.sh script does not correctly detect/handle git worktrees [v2] In-Reply-To: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> References: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> Message-ID: > Allows files or directories called .git to indicate likely use of Git for VCS in IntelliJ. > Tested locally in a worktree and normal repository. It produces: > > > > > > > in both cases, as expected. David Beaumont has updated the pull request incrementally with one additional commit since the last revision: Fix typo ------------- Changes: - all: https://git.openjdk.org/jdk/pull/26777/files - new: https://git.openjdk.org/jdk/pull/26777/files/582a0143..307574fa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=26777&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26777&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/26777.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26777/head:pull/26777 PR: https://git.openjdk.org/jdk/pull/26777 From jlahoda at openjdk.org Thu Aug 14 15:29:10 2025 From: jlahoda at openjdk.org (Jan Lahoda) Date: Thu, 14 Aug 2025 15:29:10 GMT Subject: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension In-Reply-To: References: <99y0kw0loER23cXnLl2k88BEVY7XorBViF6SGADgNRY=.09ee46af-2a6b-4c95-8d26-f76117bb1f7f@github.com> Message-ID: On Wed, 13 Aug 2025 14:24:28 GMT, Manuel H?ssig wrote: > > I would suggest to drop: `"jdk.advanced.disable.nbjavac": true,` > > Can you elaborate on the surprising results? When developing the JDK we will most probably use features not supported by the `nbjavac`. In general, it can be anything. From relatively minor problems like not working code completion in some corner case, to a complete failure of the Java editor features. When nbjavac is disabled, the javac in the JDK on which the extension runs needs to be "close enough" to the version of javac on which nbjavac is based (I believe it is currently ~JDK 24). And depending on the differences between the version against which the extension is built and the real javac in JDK, the there may be unobservable, minor or major negative effects. If the runtime JDK is too old, there's a warning. But if it is newer, then it is expected the user knows what they are doing. And I am not sure if everyone using this task will know how to interpret potential failures, given they didn't knowingly select the option. (It is true that JDK 24 and JDK 25 seem to be close enough, so that there are no major effects, and maybe not even minor effects. That may or may not be the case with any upcoming JDK 26 version.) ------------- PR Comment: https://git.openjdk.org/jdk/pull/26759#issuecomment-3188868986 From shade at openjdk.org Thu Aug 14 15:45:14 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 14 Aug 2025 15:45:14 GMT Subject: RFR: 8365048: idea.sh script does not correctly detect/handle git worktrees [v2] In-Reply-To: References: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> Message-ID: On Thu, 14 Aug 2025 15:21:29 GMT, David Beaumont wrote: >> Allows files or directories called .git to indicate likely use of Git for VCS in IntelliJ. >> Tested locally in a worktree and normal repository. It produces: >> >> >> >> >> >> >> in both cases, as expected. > > David Beaumont has updated the pull request incrementally with one additional commit since the last revision: > > Fix typo Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/26777#pullrequestreview-3121091987 From duke at openjdk.org Thu Aug 14 16:56:19 2025 From: duke at openjdk.org (duke) Date: Thu, 14 Aug 2025 16:56:19 GMT Subject: RFR: 8365048: idea.sh script does not correctly detect/handle git worktrees [v2] In-Reply-To: References: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> Message-ID: On Thu, 14 Aug 2025 15:21:29 GMT, David Beaumont wrote: >> Allows files or directories called .git to indicate likely use of Git for VCS in IntelliJ. >> Tested locally in a worktree and normal repository. It produces: >> >> >> >> >> >> >> in both cases, as expected. > > David Beaumont has updated the pull request incrementally with one additional commit since the last revision: > > Fix typo @david-beaumont Your change (at version 307574fa815477b3efe05c231956f516b80d53b9) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26777#issuecomment-3189176682 From duke at openjdk.org Thu Aug 14 17:05:19 2025 From: duke at openjdk.org (David Beaumont) Date: Thu, 14 Aug 2025 17:05:19 GMT Subject: Integrated: 8365048: idea.sh script does not correctly detect/handle git worktrees In-Reply-To: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> References: <0uUPK262bGaFrjW9a9R8J2pA_3kGi4pA7Nnn9FLFZ8Y=.aa46d4a5-11dd-4322-a1fa-483413e95e83@github.com> Message-ID: On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote: > Allows files or directories called .git to indicate likely use of Git for VCS in IntelliJ. > Tested locally in a worktree and normal repository. It produces: > > > > > > > in both cases, as expected. This pull request has now been integrated. Changeset: ba231052 Author: David Beaumont Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk/commit/ba231052319676ece5105253b58efa4e906feab4 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8365048: idea.sh script does not correctly detect/handle git worktrees Reviewed-by: shade, vyazici, erikj, mcimadamore, ihse ------------- PR: https://git.openjdk.org/jdk/pull/26777 From mhaessig at openjdk.org Fri Aug 15 06:36:46 2025 From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=) Date: Fri, 15 Aug 2025 06:36:46 GMT Subject: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v3] In-Reply-To: References: Message-ID: > This PR adds a basic configuration for the [Oracle Java VSCode extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) to the `vscode-project-*` targets. Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision: Enable nbjavac ------------- Changes: - all: https://git.openjdk.org/jdk/pull/26759/files - new: https://git.openjdk.org/jdk/pull/26759/files/277a590d..bfa9d40c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=26759&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26759&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/26759.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26759/head:pull/26759 PR: https://git.openjdk.org/jdk/pull/26759 From mhaessig at openjdk.org Fri Aug 15 06:36:47 2025 From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=) Date: Fri, 15 Aug 2025 06:36:47 GMT Subject: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v2] In-Reply-To: <_HedHy5F966CKB-J_xRbvt_gLfCk9BIlNvk5H5WpwHc=.2b9e787f-64be-4cb5-9ce4-5c6907ac4b28@github.com> References: <_HedHy5F966CKB-J_xRbvt_gLfCk9BIlNvk5H5WpwHc=.2b9e787f-64be-4cb5-9ce4-5c6907ac4b28@github.com> Message-ID: On Wed, 13 Aug 2025 14:23:37 GMT, Manuel H?ssig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) to the `vscode-project-*` targets. > > Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision: > > Prevent organizing imports I was not aware that it had to be "close" to nbjavac. Then enabling nbjavac makes much more sense. Thank you for explaining this. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26759#issuecomment-3190762251 From ihse at openjdk.org Fri Aug 15 08:43:12 2025 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Fri, 15 Aug 2025 08:43:12 GMT Subject: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v3] In-Reply-To: References: Message-ID: On Fri, 15 Aug 2025 06:36:46 GMT, Manuel H?ssig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) to the `vscode-project-*` targets. > > Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision: > > Enable nbjavac Marked as reviewed by ihse (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/26759#pullrequestreview-3123262333 From jlahoda at openjdk.org Fri Aug 15 08:43:12 2025 From: jlahoda at openjdk.org (Jan Lahoda) Date: Fri, 15 Aug 2025 08:43:12 GMT Subject: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v3] In-Reply-To: References: Message-ID: On Fri, 15 Aug 2025 06:36:46 GMT, Manuel H?ssig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) to the `vscode-project-*` targets. > > Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision: > > Enable nbjavac Thanks, @mhaessig! ------------- Marked as reviewed by jlahoda (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26759#pullrequestreview-3123264543 From mhaessig at openjdk.org Fri Aug 15 08:58:16 2025 From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=) Date: Fri, 15 Aug 2025 08:58:16 GMT Subject: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v3] In-Reply-To: References: Message-ID: On Fri, 15 Aug 2025 06:36:46 GMT, Manuel H?ssig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) to the `vscode-project-*` targets. > > Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision: > > Enable nbjavac Thank you for your reviews! ------------- PR Comment: https://git.openjdk.org/jdk/pull/26759#issuecomment-3190987969 From mhaessig at openjdk.org Fri Aug 15 08:58:17 2025 From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=) Date: Fri, 15 Aug 2025 08:58:17 GMT Subject: Integrated: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension In-Reply-To: References: Message-ID: On Wed, 13 Aug 2025 13:22:21 GMT, Manuel H?ssig wrote: > This PR adds a basic configuration for the [Oracle Java VSCode extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) to the `vscode-project-*` targets. This pull request has now been integrated. Changeset: fa2eb616 Author: Manuel H?ssig URL: https://git.openjdk.org/jdk/commit/fa2eb616482250dff6a3b667798aec37114005a9 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod 8365491: VSCode IDE: add basic configuration for the Oracle Java extension Reviewed-by: ihse, jlahoda ------------- PR: https://git.openjdk.org/jdk/pull/26759