From duke at openjdk.org  Thu Mar 27 14:39:45 2025
From: duke at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Thu, 27 Mar 2025 14:39:45 GMT
Subject: RFR: 8353063: make/ide/vscode: Invalid Configuration Values
Message-ID: <lRYCRvBqwAj3KOpd_XuTZoK7fUQ5nLheCeEUbc_8jZU=.348fba8b-5d97-41dc-9b94-a1154e2f7b3b@github.com>

The indexer setting templates used by the `vscode-project-*` `make` targets contain invalid configuration values. For example, `C_Cpp.formatting": "Disabled"`is invalid because VSCode (or rather the extension) expects the value to be non-capitalized. This PR fixes these invalid configuration options.

 I tested the changes by generating VSCode workspaces and checking whether VSCode complains about invalid values.

-------------

Commit messages:
 - make/ide/vscode: Fix invalid configuration values

Changes: https://git.openjdk.org/jdk/pull/24280/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24280&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8353063
  Stats: 12 lines in 3 files changed: 0 ins; 0 del; 12 mod
  Patch: https://git.openjdk.org/jdk/pull/24280.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24280/head:pull/24280

PR: https://git.openjdk.org/jdk/pull/24280

From erikj at openjdk.org  Thu Mar 27 18:19:20 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Thu, 27 Mar 2025 18:19:20 GMT
Subject: RFR: 8353063: make/ide/vscode: Invalid Configuration Values
In-Reply-To: <lRYCRvBqwAj3KOpd_XuTZoK7fUQ5nLheCeEUbc_8jZU=.348fba8b-5d97-41dc-9b94-a1154e2f7b3b@github.com>
References: <lRYCRvBqwAj3KOpd_XuTZoK7fUQ5nLheCeEUbc_8jZU=.348fba8b-5d97-41dc-9b94-a1154e2f7b3b@github.com>
Message-ID: <njAwUAtpCpsQpNXINjGfIysHHsLuODSZNn8sz4QYAiI=.ecf4bce0-7e75-4e5d-b664-937ead4bd7e3@github.com>

On Thu, 27 Mar 2025 14:33:30 GMT, Manuel H?ssig <duke at openjdk.org> wrote:

> The indexer setting templates used by the `vscode-project-*` `make` targets contain invalid configuration values. For example, `C_Cpp.formatting": "Disabled"`is invalid because VSCode (or rather the extension) expects the value to be non-capitalized. This PR fixes these invalid configuration options.
> 
>  I tested the changes by generating VSCode workspaces and checking whether VSCode complains about invalid values.

Marked as reviewed by erikj (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24280#pullrequestreview-2723016729

From thartmann at openjdk.org  Fri Mar 28 09:01:27 2025
From: thartmann at openjdk.org (Tobias Hartmann)
Date: Fri, 28 Mar 2025 09:01:27 GMT
Subject: RFR: 8353063: make/ide/vscode: Invalid Configuration Values
In-Reply-To: <lRYCRvBqwAj3KOpd_XuTZoK7fUQ5nLheCeEUbc_8jZU=.348fba8b-5d97-41dc-9b94-a1154e2f7b3b@github.com>
References: <lRYCRvBqwAj3KOpd_XuTZoK7fUQ5nLheCeEUbc_8jZU=.348fba8b-5d97-41dc-9b94-a1154e2f7b3b@github.com>
Message-ID: <5wyvxK1Z-ifXroyHmzj8C1PiRyMzmBVzcMZuAZ4mnOQ=.b35dcd2d-d0fc-48a3-ab4a-387c942b5fd3@github.com>

On Thu, 27 Mar 2025 14:33:30 GMT, Manuel H?ssig <duke at openjdk.org> wrote:

> The indexer setting templates used by the `vscode-project-*` `make` targets contain invalid configuration values. For example, `C_Cpp.formatting": "Disabled"`is invalid because VSCode (or rather the extension) expects the value to be non-capitalized. This PR fixes these invalid configuration options.
> 
>  I tested the changes by generating VSCode workspaces and checking whether VSCode complains about invalid values.

Marked as reviewed by thartmann (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24280#pullrequestreview-2724722384

From duke at openjdk.org  Fri Mar 28 09:01:27 2025
From: duke at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Fri, 28 Mar 2025 09:01:27 GMT
Subject: Integrated: 8353063: make/ide/vscode: Invalid Configuration Values
In-Reply-To: <lRYCRvBqwAj3KOpd_XuTZoK7fUQ5nLheCeEUbc_8jZU=.348fba8b-5d97-41dc-9b94-a1154e2f7b3b@github.com>
References: <lRYCRvBqwAj3KOpd_XuTZoK7fUQ5nLheCeEUbc_8jZU=.348fba8b-5d97-41dc-9b94-a1154e2f7b3b@github.com>
Message-ID: <j217X6jRQhYTrXscZfEdmQMVsnMoTJEk4UYaMDQVmxU=.6224db8b-5819-4146-bd8d-316cb5034af0@github.com>

On Thu, 27 Mar 2025 14:33:30 GMT, Manuel H?ssig <duke at openjdk.org> wrote:

> The indexer setting templates used by the `vscode-project-*` `make` targets contain invalid configuration values. For example, `C_Cpp.formatting": "Disabled"`is invalid because VSCode (or rather the extension) expects the value to be non-capitalized. This PR fixes these invalid configuration options.
> 
>  I tested the changes by generating VSCode workspaces and checking whether VSCode complains about invalid values.

This pull request has now been integrated.

Changeset: 3e9a7a4a
Author:    Manuel H?ssig <manuel.hassig at oracle.com>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3e9a7a4aed168422473c941ff5626d0d65aaadfa
Stats:     12 lines in 3 files changed: 0 ins; 0 del; 12 mod

8353063: make/ide/vscode: Invalid Configuration Values

Reviewed-by: erikj, thartmann

-------------

PR: https://git.openjdk.org/jdk/pull/24280