From krk at openjdk.org  Fri Nov  7 13:44:17 2025
From: krk at openjdk.org (Kerem Kat)
Date: Fri, 7 Nov 2025 13:44:17 GMT
Subject: RFR: 8371425: Include folder names in vscode workspace virtual folders
Message-ID: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>

Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from `make vscode-project`.

<img width="400" height="353" alt="image" src="https://github.com/user-attachments/assets/5202aae9-19ff-472e-b966-46419c921370" />

-------------

Commit messages:
 - 8371425: Include folder names in vscode workspace virtual folders

Changes: https://git.openjdk.org/jdk/pull/28194/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28194&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8371425
  Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/28194.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28194/head:pull/28194

PR: https://git.openjdk.org/jdk/pull/28194

From erikj at openjdk.org  Fri Nov  7 13:57:03 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 7 Nov 2025 13:57:03 GMT
Subject: RFR: 8371425: Include folder names in vscode workspace virtual
 folders
In-Reply-To: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>
References: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>
Message-ID: <vga8znwYn-SITTTLvPAMChCMJPPe6Lq-eC28aIprTE0=.bc39bcf0-8fcf-4158-85dd-a25d62c76edc@github.com>

On Fri, 7 Nov 2025 13:37:57 GMT, Kerem Kat <krk at openjdk.org> wrote:

> Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from `make vscode-project`.
> 
> <img width="400" height="353" alt="image" src="https://github.com/user-attachments/assets/5202aae9-19ff-472e-b966-46419c921370" />

I think this change makes sense, but it would be good to get input from other VS Code users.

make/ide/vscode/hotspot/CreateVSCodeProject.gmk line 88:

> 86: 	        $(call RelativePath,$(OUTPUTDIR),$(TOPDIR)))))!g' \
> 87: 		-e 's!{{TOPDIR_BASE}}!$(notdir $(TOPDIR))!g' \
> 88: 		-e 's!{{OUTPUT_BASE}}!$(notdir $(OUTPUTDIR))!g' \

These lines aren't lining up with the rest. Please see https://openjdk.org/groups/build/doc/code-conventions.html for details on build system code conventions.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28194#pullrequestreview-3434077079
PR Review Comment: https://git.openjdk.org/jdk/pull/28194#discussion_r2503668068

From krk at openjdk.org  Fri Nov  7 14:08:34 2025
From: krk at openjdk.org (Kerem Kat)
Date: Fri, 7 Nov 2025 14:08:34 GMT
Subject: RFR: 8371425: Include folder names in vscode workspace virtual
 folders [v2]
In-Reply-To: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>
References: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>
Message-ID: <0fa5D6sGt9QbOw-lXmpakkb6tLzVKMIhKpnBeyMO570=.e3d229be-6f19-42db-bf1c-cd8821731d84@github.com>

> Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from `make vscode-project`.
> 
> <img width="400" height="353" alt="image" src="https://github.com/user-attachments/assets/5202aae9-19ff-472e-b966-46419c921370" />

Kerem Kat has updated the pull request incrementally with one additional commit since the last revision:

  fix space

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28194/files
  - new: https://git.openjdk.org/jdk/pull/28194/files/f0145f45..9f39f939

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28194&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28194&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/28194.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28194/head:pull/28194

PR: https://git.openjdk.org/jdk/pull/28194

From erikj at openjdk.org  Fri Nov  7 14:15:08 2025
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 7 Nov 2025 14:15:08 GMT
Subject: RFR: 8371425: Include folder names in vscode workspace virtual
 folders [v2]
In-Reply-To: <0fa5D6sGt9QbOw-lXmpakkb6tLzVKMIhKpnBeyMO570=.e3d229be-6f19-42db-bf1c-cd8821731d84@github.com>
References: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>
 <0fa5D6sGt9QbOw-lXmpakkb6tLzVKMIhKpnBeyMO570=.e3d229be-6f19-42db-bf1c-cd8821731d84@github.com>
Message-ID: <kpBeQuTc01430AWxWHs6XgP5o0bX2Tl5oq2zpdTI1T4=.87ea374b-3447-49dc-8972-9412fc1268e3@github.com>

On Fri, 7 Nov 2025 14:08:34 GMT, Kerem Kat <krk at openjdk.org> wrote:

>> Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from `make vscode-project`.
>> 
>> <img width="400" height="353" alt="image" src="https://github.com/user-attachments/assets/5202aae9-19ff-472e-b966-46419c921370" />
>
> Kerem Kat has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix space

-------------

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28194#pullrequestreview-3434194031

From jvernee at openjdk.org  Sat Nov  8 01:26:02 2025
From: jvernee at openjdk.org (Jorn Vernee)
Date: Sat, 8 Nov 2025 01:26:02 GMT
Subject: RFR: 8371425: Include folder names in vscode workspace virtual
 folders [v2]
In-Reply-To: <0fa5D6sGt9QbOw-lXmpakkb6tLzVKMIhKpnBeyMO570=.e3d229be-6f19-42db-bf1c-cd8821731d84@github.com>
References: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>
 <0fa5D6sGt9QbOw-lXmpakkb6tLzVKMIhKpnBeyMO570=.e3d229be-6f19-42db-bf1c-cd8821731d84@github.com>
Message-ID: <YqPiAFN0fxT1abB5VZ__f6RVIF5NGFJ3zeJaiUWGUws=.aebd7466-dd7f-49d8-b6c5-07bbd5fd2f40@github.com>

On Fri, 7 Nov 2025 14:08:34 GMT, Kerem Kat <krk at openjdk.org> wrote:

>> Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from `make vscode-project`.
>> 
>> <img width="400" height="353" alt="image" src="https://github.com/user-attachments/assets/5202aae9-19ff-472e-b966-46419c921370" />
>
> Kerem Kat has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix space

Marked as reviewed by jvernee (Reviewer).

As a VS Code user I welcome this change. The current folder names are fairly nondescript.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28194#pullrequestreview-3437007688
PR Comment: https://git.openjdk.org/jdk/pull/28194#issuecomment-3505550126

From krk at openjdk.org  Mon Nov 10 11:02:03 2025
From: krk at openjdk.org (Kerem Kat)
Date: Mon, 10 Nov 2025 11:02:03 GMT
Subject: RFR: 8371425: Include folder names in vscode workspace virtual
 folders [v2]
In-Reply-To: <0fa5D6sGt9QbOw-lXmpakkb6tLzVKMIhKpnBeyMO570=.e3d229be-6f19-42db-bf1c-cd8821731d84@github.com>
References: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>
 <0fa5D6sGt9QbOw-lXmpakkb6tLzVKMIhKpnBeyMO570=.e3d229be-6f19-42db-bf1c-cd8821731d84@github.com>
Message-ID: <b6g5fb92IwWhqGldrxA6jTesaTjAlndl36Ktm__fglo=.21891174-d6e3-427c-b733-ff76d90cad51@github.com>

On Fri, 7 Nov 2025 14:08:34 GMT, Kerem Kat <krk at openjdk.org> wrote:

>> Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from `make vscode-project`.
>> 
>> <img width="400" height="353" alt="image" src="https://github.com/user-attachments/assets/5202aae9-19ff-472e-b966-46419c921370" />
>
> Kerem Kat has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix space

Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28194#issuecomment-3510867247

From duke at openjdk.org  Mon Nov 10 11:02:03 2025
From: duke at openjdk.org (duke)
Date: Mon, 10 Nov 2025 11:02:03 GMT
Subject: RFR: 8371425: Include folder names in vscode workspace virtual
 folders [v2]
In-Reply-To: <0fa5D6sGt9QbOw-lXmpakkb6tLzVKMIhKpnBeyMO570=.e3d229be-6f19-42db-bf1c-cd8821731d84@github.com>
References: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>
 <0fa5D6sGt9QbOw-lXmpakkb6tLzVKMIhKpnBeyMO570=.e3d229be-6f19-42db-bf1c-cd8821731d84@github.com>
Message-ID: <Ba-7wkX533XNLqjVKy8Djr8r9feFj8YNzFJ-Grk6A-Q=.256d2747-d090-4e4c-92c2-bd241ba7d6b3@github.com>

On Fri, 7 Nov 2025 14:08:34 GMT, Kerem Kat <krk at openjdk.org> wrote:

>> Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from `make vscode-project`.
>> 
>> <img width="400" height="353" alt="image" src="https://github.com/user-attachments/assets/5202aae9-19ff-472e-b966-46419c921370" />
>
> Kerem Kat has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix space

@krk 
Your change (at version 9f39f939e45a33e1f575e046e551e4060bdde109) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28194#issuecomment-3510871279

From shade at openjdk.org  Mon Nov 10 11:36:40 2025
From: shade at openjdk.org (Aleksey Shipilev)
Date: Mon, 10 Nov 2025 11:36:40 GMT
Subject: RFR: 8371425: Include folder names in vscode workspace virtual
 folders [v2]
In-Reply-To: <0fa5D6sGt9QbOw-lXmpakkb6tLzVKMIhKpnBeyMO570=.e3d229be-6f19-42db-bf1c-cd8821731d84@github.com>
References: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>
 <0fa5D6sGt9QbOw-lXmpakkb6tLzVKMIhKpnBeyMO570=.e3d229be-6f19-42db-bf1c-cd8821731d84@github.com>
Message-ID: <KwbcAHatCgSCB_iETjhBsSa0oa_31-0TvtAncxmOJFM=.bee8bf1e-2cc8-48f3-bff2-418103162bda@github.com>

On Fri, 7 Nov 2025 14:08:34 GMT, Kerem Kat <krk at openjdk.org> wrote:

>> Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from `make vscode-project`.
>> 
>> <img width="400" height="353" alt="image" src="https://github.com/user-attachments/assets/5202aae9-19ff-472e-b966-46419c921370" />
>
> Kerem Kat has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix space

Looks reasonable, thanks.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28194#pullrequestreview-3442667229

From krk at openjdk.org  Mon Nov 10 11:36:41 2025
From: krk at openjdk.org (Kerem Kat)
Date: Mon, 10 Nov 2025 11:36:41 GMT
Subject: Integrated: 8371425: Include folder names in vscode workspace virtual
 folders
In-Reply-To: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>
References: <0sJzgar4e3ohyX0lw-p9nNB0OIbLhuZ9j38VEHwWaio=.d9237d8c-4df1-460a-90f8-4bceeda14a3c@github.com>
Message-ID: <6PlIW4NUW_IoFIpHbkJZzLvxvZABA4s5_AY_ZtQVozg=.a1ce23c0-c16d-497e-b6e4-60d28a211bfd@github.com>

On Fri, 7 Nov 2025 13:37:57 GMT, Kerem Kat <krk at openjdk.org> wrote:

> Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from `make vscode-project`.
> 
> <img width="400" height="353" alt="image" src="https://github.com/user-attachments/assets/5202aae9-19ff-472e-b966-46419c921370" />

This pull request has now been integrated.

Changeset: 98f40e45
Author:    Kerem Kat <krk at openjdk.org>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/98f40e4575538d91f509c85d9d657a8973f464be
Stats:     4 lines in 2 files changed: 2 ins; 0 del; 2 mod

8371425: Include folder names in vscode workspace virtual folders

Reviewed-by: erikj, jvernee, shade

-------------

PR: https://git.openjdk.org/jdk/pull/28194