From duke at openjdk.org  Mon Jan 19 17:29:35 2026
From: duke at openjdk.org (David Beaumont)
Date: Mon, 19 Jan 2026 17:29:35 GMT
Subject: RFR: 8375649: idea.sh script adds source paths in a single, enormous, 
 line to jdk.iml.
Message-ID: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>

Allow replacement string to contain embedded newlines to split entries.
This turns output like:


    <content url="file:///home/david/dev/test/jdk">
      <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" /> ... another 10k chars on the end of this line ...


into:

    <content url="file:///home/david/dev/test/jdk">
      <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" />
      <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" />
      <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" />
      ... one entry per line ...

-------------

Commit messages:
 - 8375649: idea.sh script adds source paths in a single, enormous, line to jdk.iml

Changes: https://git.openjdk.org/jdk/pull/29305/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29305&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8375649
  Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/29305.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/29305/head:pull/29305

PR: https://git.openjdk.org/jdk/pull/29305

From liach at openjdk.org  Mon Jan 19 17:43:34 2026
From: liach at openjdk.org (Chen Liang)
Date: Mon, 19 Jan 2026 17:43:34 GMT
Subject: RFR: 8375649: idea.sh script adds source paths in a single,
 enormous, line to jdk.iml
In-Reply-To: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>
References: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>
Message-ID: <LLK-4WVIdrg6GyEMfxWzWNdz6zRdUgONhbdA9dYbhzw=.8efd0c14-0279-4201-818e-c87f34d404bb@github.com>

On Mon, 19 Jan 2026 17:23:10 GMT, David Beaumont <duke at openjdk.org> wrote:

> Allow replacement string to contain embedded newlines to split entries.
> This turns output like:
> 
> 
>     <content url="file:///home/david/dev/test/jdk">
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" /> ... another 10k chars on the end of this line ...
> 
> 
> into:
> 
>     <content url="file:///home/david/dev/test/jdk">
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" />
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" />
>       <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" />
>       ... one entry per line ...

Should we just leave the newline in SOURCE_POSTFIX?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29305#issuecomment-3769511305

From duke at openjdk.org  Mon Jan 19 20:08:56 2026
From: duke at openjdk.org (David Beaumont)
Date: Mon, 19 Jan 2026 20:08:56 GMT
Subject: RFR: 8375649: idea.sh script adds source paths in a single,
 enormous, line to jdk.iml
In-Reply-To: <LLK-4WVIdrg6GyEMfxWzWNdz6zRdUgONhbdA9dYbhzw=.8efd0c14-0279-4201-818e-c87f34d404bb@github.com>
References: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>
 <LLK-4WVIdrg6GyEMfxWzWNdz6zRdUgONhbdA9dYbhzw=.8efd0c14-0279-4201-818e-c87f34d404bb@github.com>
Message-ID: <V9X4yy4lRAqtJ8G9qPj2-IJxFGKbeAVouCUeMfcO4lA=.a3400511-f72f-4ba0-9ada-9212186f1e4d@github.com>

On Mon, 19 Jan 2026 17:39:58 GMT, Chen Liang <liach at openjdk.org> wrote:

> Should we just leave the newline in SOURCE_POSTFIX?

You end up with an extra blank line in the output if you do that, unless you mess with the template file as well.
The postfix is output +1 times more than the intermediate separator (fence posts).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29305#issuecomment-3769946094

From erikj at openjdk.org  Tue Jan 20 19:13:56 2026
From: erikj at openjdk.org (Erik Joelsson)
Date: Tue, 20 Jan 2026 19:13:56 GMT
Subject: RFR: 8375649: idea.sh script adds source paths in a single,
 enormous, line to jdk.iml
In-Reply-To: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>
References: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>
Message-ID: <x--aXSqHWCoWzHy8qDqhtaT0YrnaKeG2_VDl0Gt5QrA=.07046d01-7348-4d9a-b6d2-b2caa337cea1@github.com>

On Mon, 19 Jan 2026 17:23:10 GMT, David Beaumont <duke at openjdk.org> wrote:

> Allow replacement string to contain embedded newlines to split entries.
> This turns output like:
> 
> 
>     <content url="file:///home/david/dev/test/jdk">
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" /> ... another 10k chars on the end of this line ...
> 
> 
> into:
> 
>     <content url="file:///home/david/dev/test/jdk">
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" />
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" />
>       <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" />
>       ... one entry per line ...

Marked as reviewed by erikj (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/29305#pullrequestreview-3683874366

From liach at openjdk.org  Wed Jan 21 16:35:14 2026
From: liach at openjdk.org (Chen Liang)
Date: Wed, 21 Jan 2026 16:35:14 GMT
Subject: RFR: 8375649: idea.sh script adds source paths in a single,
 enormous, line to jdk.iml
In-Reply-To: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>
References: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>
Message-ID: <obBA-bkUl226hsclXIwOl3WDE8tAw60CtHqY9Q4z-Zw=.01e167ca-e34c-4cff-94fa-7c8859faba6c@github.com>

On Mon, 19 Jan 2026 17:23:10 GMT, David Beaumont <duke at openjdk.org> wrote:

> Allow replacement string to contain embedded newlines to split entries.
> This turns output like:
> 
> 
>     <content url="file:///home/david/dev/test/jdk">
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" /> ... another 10k chars on the end of this line ...
> 
> 
> into:
> 
>     <content url="file:///home/david/dev/test/jdk">
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" />
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" />
>       <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" />
>       ... one entry per line ...

In addition, I see extra spaces presumably for indent after the `\n` - are we sure the number of spaces is correct? Is there a reason we don't need this indent for the 1st line?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29305#issuecomment-3779447248

From duke at openjdk.org  Thu Jan 22 10:49:55 2026
From: duke at openjdk.org (David Beaumont)
Date: Thu, 22 Jan 2026 10:49:55 GMT
Subject: RFR: 8375649: idea.sh script adds source paths in a single,
 enormous, line to jdk.iml
In-Reply-To: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>
References: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>
Message-ID: <CxdLpDNkx1mALPrhFcK4vSp1VDU57APFJizRpM-Gfrw=.a5cc174e-1b4d-4d83-a75a-ef96944ce764@github.com>

On Mon, 19 Jan 2026 17:23:10 GMT, David Beaumont <duke at openjdk.org> wrote:

> Allow replacement string to contain embedded newlines to split entries.
> This turns output like:
> 
> 
>     <content url="file:///home/david/dev/test/jdk">
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" /> ... another 10k chars on the end of this line ...
> 
> 
> into:
> 
>     <content url="file:///home/david/dev/test/jdk">
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" />
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" />
>       <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" />
>       ... one entry per line ...

The spaces are correct (6) and the first line's indent is in the template file itself.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29305#issuecomment-3783728479

From liach at openjdk.org  Thu Jan 22 23:22:23 2026
From: liach at openjdk.org (Chen Liang)
Date: Thu, 22 Jan 2026 23:22:23 GMT
Subject: RFR: 8375649: idea.sh script adds source paths in a single,
 enormous, line to jdk.iml
In-Reply-To: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>
References: <8VKFvGh68jUTy_zfGyXsDUS9qu-vxOQ0bbWEnkMrcXU=.a0ad4c14-4181-4752-9780-cdcef5f8a1a2@github.com>
Message-ID: <l2Mn_1u17CwX9sPSO_TjsiC3c0zbAb2G1SaemHwIPH0=.beed3437-9959-44fe-aa1b-2a0b8dada761@github.com>

On Mon, 19 Jan 2026 17:23:10 GMT, David Beaumont <duke at openjdk.org> wrote:

> Allow replacement string to contain embedded newlines to split entries.
> This turns output like:
> 
> 
>     <content url="file:///home/david/dev/test/jdk">
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" /> <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" /> ... another 10k chars on the end of this line ...
> 
> 
> into:
> 
>     <content url="file:///home/david/dev/test/jdk">
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/linux/classes" isTestSource="false" />
>       <sourceFolder url="file:///home/david/dev/test/jdk/open/src/java.base/unix/classes" isTestSource="false" />
>       <sourceFolder url="file:///home/david/dev/test/jdk/closed/src/java.base/share/classes" isTestSource="false" />
>       ... one entry per line ...

Sure, I think someone who revisit that template will notice this bash and update here too :)

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29305#pullrequestreview-3695031056