Review Request : 7198272 - RFE : Javadoc Accessibility : Generate WAI-ARIA compliant HTML

[Jonathan Gibbons]

On 11/05/2012 08:06 AM, jayashree viswanathan wrote:
> Hi Jon ,
>
> Can you please review the changeset for the bug 7198272 ?
>
> The Changeset and example page are available in the below link .
>
> http://cr.openjdk.java.net/~jviswana/7198272/
>
> Thanks a lot !
>
> Regards,
> Jayashree V
>


Jayashree,

My initial reaction is that there are no tests for such a lot of lines 
being changed.

I know you don't have access (yet) to the OpenJDK bug system, but the 
general rules for fixing bugs still apply [1], especially section 6, "Is 
it possible to write a test to detect the bug?"

Note that we are beginning to use code coverage tools to detect that 
lines modified in a changeset are executed by the corresponding tests.

-- Jon

[1] http://openjdk.java.net/guide/changePlanning.html#bug