docencoding not available to stylesheet

[Jonathan Gibbons]

Note that you open the writer twice, once unmodified on like 369,
then again in the lines you added.   I suggest you either change
line 369 to an uninitialized declaration, or merge 369-374 into a
declaration whose initialization involved a conditional expression.

But, note that there may be big changes in this area coming soon,
with work to support JEP 106 [1].which will involve rewriting all code
that currently uses File, FileInputStream etc, to use JavaFileObject.

-- Jon

[1] http://openjdk.java.net/jeps/106



On 10/03/2012 02:25 AM, jayashree viswanathan wrote:
> Hi Jon ,
>
> Got a chance to look at the webrev ?
>
> Thanks !
>
> Regards,
> Jayashree V
>
> On 17-09-2012 8:57 PM, Jonathan Gibbons wrote:
>> OK, I will take a look at your latest webrev.
>>
>> -- Jon
>>
>> On 09/16/2012 11:54 PM, jayashree viswanathan wrote:
>>> Hi Jon ,
>>>
>>> Thanks a lot for looking in and passing your review comments .
>>>
>>> I have made the changes Please find the webrev at 
>>> http://cr.openjdk.java.net/~luchsh/7006270_3/
>>>
>>> Regards,
>>> Jayashree Viswanathan
>>>
>>> On 13-09-2012 10:55 PM, Jonathan Gibbons wrote:
>>>> The basic fix looks OK, I'd recommend a couple of white-space 
>>>> tweaks, such as a space between ")" and "{" on line 370, and after 
>>>> "," on line 373.
>>>>
>>>> In the tests, I suggest blank lines before/after the IBM copyright 
>>>> on both files, and remove the space before the comment on line 23 
>>>> in the Test.java file.
>>>>
>>>> Are you claiming the copyright on all three files is 2011, not 2012?
>>>>
>>>> -- Jon
>>>>
>>>> On 08/31/2012 02:50 AM, jayashree viswanathan wrote:
>>>>> *Problem statement : *Stylesheet.css is not getting encoded like 
>>>>> the other generated html files while using -docencoding
>>>>>
>>>>> *Recreation step : *
>>>>> javadoc -docencoding "use non-ascii encoding" HelloWorld.java
>>>>> say ,
>>>>> jdk1.8.0\bin\javadoc.exe -docencoding Cp930 -d docencoding3 
>>>>> HelloWorld.java
>>>>>
>>>>> *Explanation :*
>>>>> The stylesheet.css is not getting generated in the proper encoding 
>>>>> as in the code the configuration.docencoding is not getting passed 
>>>>> to the output stream .
>>>>> while this scenario works in JDK 6 [as confirmed in Java 6u14] , 
>>>>> below changeset seems to have regressed this when adding new 
>>>>> copyFile method.
>>>>>
>>>>> Changeset:
>>>>> 792 (ffbf2b2a8611) 7006270: Several javadoc regression tests are 
>>>>> failing on windows
>>>>>
>>>>> Please find the webrev patch with changes and jtreg test .
>>>>>
>>>>> http://cr.openjdk.java.net/~luchsh/ojdk-660/
>>>>>
>>>>> Thanks and Regards,
>>>>> Jayashree V
>>>>
>>>
>>
>