docencoding not available to stylesheet

jayashree viswanathan jviswana at linux.vnet.ibm.com
Sun Sep 16 23:54:59 PDT 2012


Hi Jon ,

Thanks a lot for looking in and passing your review comments .

I have made the changes Please find the webrev at 
http://cr.openjdk.java.net/~luchsh/7006270_3/

Regards,
Jayashree Viswanathan

On 13-09-2012 10:55 PM, Jonathan Gibbons wrote:
> The basic fix looks OK, I'd recommend a couple of white-space tweaks, 
> such as a space between ")" and "{" on line 370, and after "," on line 
> 373.
>
> In the tests, I suggest blank lines before/after the IBM copyright on 
> both files, and remove the space before the comment on line 23 in the 
> Test.java file.
>
> Are you claiming the copyright on all three files is 2011, not 2012?
>
> -- Jon
>
> On 08/31/2012 02:50 AM, jayashree viswanathan wrote:
>> *Problem statement : *Stylesheet.css is not getting encoded like the 
>> other generated html files while using -docencoding
>>
>> *Recreation step : *
>> javadoc -docencoding "use non-ascii encoding" HelloWorld.java
>> say ,
>> jdk1.8.0\bin\javadoc.exe -docencoding Cp930 -d docencoding3 
>> HelloWorld.java
>>
>> *Explanation :*
>> The stylesheet.css is not getting generated in the proper encoding as 
>> in the code the configuration.docencoding is not getting passed to 
>> the output stream .
>> while this scenario works in JDK 6 [as confirmed in Java 6u14] , 
>> below changeset seems to have regressed this when adding new copyFile 
>> method.
>>
>> Changeset:
>> 792 (ffbf2b2a8611) 7006270: Several javadoc regression tests are 
>> failing on windows
>>
>> Please find the webrev patch with changes and jtreg test .
>>
>> http://cr.openjdk.java.net/~luchsh/ojdk-660/
>>
>> Thanks and Regards,
>> Jayashree V
>



More information about the javadoc-dev mailing list