RFR: 8157102: Avoid exceptional control flow in Configuration.getText

Claes Redestad claes.redestad at oracle.com
Tue May 17 11:06:11 UTC 2016


On 2016-05-17 02:24, Jonathan Gibbons wrote:
> OK by me.

Thanks Jon!

>
> We might at some point want to do additional cleanup of the names (the 
> current names are archaic and do not accurately reflect their intent) 
> and we might want to redice the overloads in jdk.javadoc, but for the 
> issue being addressed, the proposed change is good.

I admit to not knowing the javadoc code well enough to come up with 
better names, so I'll shy away from attempting any further cleanups and 
push the reviewed changeset.

/Claes

>
> -- Jon
>
> On 05/16/2016 04:47 PM, Claes Redestad wrote:
>> Hi,
>>
>> please review this patch to avoid using exceptional control flow in 
>> .../doclets/internal/toolkit/Configuration.java
>>
>> Webrev: http://cr.openjdk.java.net/~redestad/8157102/webrev.01/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8157102
>>
>> This improves javadoc performance across a range of workloads.
>>
>> Thanks!
>>
>> /Claes
>



More information about the javadoc-dev mailing list