RFR: 8189843: Missing "id" attributes in table rows

[Kumar Srinivasan]

Hi Jon,

Your changes for the fix in itself if ok.

However, I was looking at this:

public booleanisProperty(String name) {
     returnconfiguration.javafx&& name.endsWith("Property");
}

I wonder if we should have a more robust check.

Kumar

> Please review a simple fix to fix the fix for JDK-8182257 
> <https://bugs.openjdk.java.net/browse/JDK-8182257>.
>
> The original problem was the appearance of duplicate uses of an "id". 
> The original fix was flawed because it got rid of both instances of 
> each duplicated id. This fix better disables the use of ids in the 
> property summary table, while retaining them in the method table.
>
> The primary purpose of this changeset is to introduce the new tests. 
> The source code will soon be further improved with the introduction of 
> a new Table builder class.
>
> In this changeset, the fix is to pass down a parameter indicating the 
> "kind" of the summary table, such that ids are suppressed in property 
> summary tables.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8182257
> Webrev: http://cr.openjdk.java.net/~jjg/8189843/webrev.00/
>
> -- Jon
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/javadoc-dev/attachments/20171025/bbfda4f2/attachment.html>