RFR: 8190003: Special characters in group names should be escaped

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed Oct 25 23:51:01 UTC 2017


Agreed it would be worth the new test.

-- Jon

On 10/25/2017 04:49 PM, Bhavesh Patel wrote:
> Looks good. The fix I pushed today for JDK-8183037 actually fixes this 
> issue so when you try to merge these, the source changes and the 
> TestModule.java changes might not be needed. But it would be good to 
> push the TestGroupName.java which tests the group name.
>
> Regards,
> Bhavesh.
>
> On 10/25/2017 2:43 PM, Jonathan Gibbons wrote:
>> Please review this simple fix to better handle the "group name" 
>> supplied in a -group option.
>> The name is currently just wrapped in a RawHtml node; it should be 
>> wrapped in a StringContent node.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8190003
>> Webrev: http://cr.openjdk.java.net/~jjg/8190003/webrev.00/
>>
>> -- Jon
>



More information about the javadoc-dev mailing list