RFR : 8203792 : Remove "compatibility" features from Head.java

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Aug 14 04:48:31 UTC 2018


Looks good.

-Sundar

On 14/08/18, 10:07 AM, Priya Lakshmi Muthuswamy wrote:
> Thanks Jon for the review.
> updated webrev : 
> http://cr.openjdk.java.net/~pmuthuswamy/8203792/webrev.01/
> I have removed the date from the comparison.
>
> Regards,
> Priya
>
> On 8/14/2018 5:43 AM, Jonathan Gibbons wrote:
>> On 8/2/18 4:31 AM, Priya Lakshmi Muthuswamy wrote:
>>
>>> Hi,
>>>
>>> Kindly review the fix for 
>>> https://bugs.openjdk.java.net/browse/JDK-8203792
>>> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8203792/webrev.00/
>>>
>>> Thanks,
>>> Priya
>> In the new test, the use of LocalDate.now() will lead to occasional 
>> spurious test
>> failures, when now() isn't the same as it was when javadoc wrote the 
>> file.
>>
>> I don't have a good suggestion, other than to exclude the exact date 
>> from the
>> comparison. Anything more sophisticated would involve reading the 
>> file to
>> find that line, and find the date on the line, and verify the value 
>> looks
>> "reasonable". In between, there would be the ability to do regex 
>> matching
>> on the file contents, but we didn't get around to 
>> designing/supporting that yet.
>>
>> -- Jon
>


More information about the javadoc-dev mailing list