RFR : 8209052: Low contrast in docs/api/constant-values.html

Priya Lakshmi Muthuswamy priya.lakshmi.muthuswamy at oracle.com
Thu Aug 16 04:04:25 UTC 2018


Hi Jon,

For hover, yes I see color variation.
My proposal :
Since its just for hover and also as we need to provide contrast color 
other than black/blue, I am suggesting white

Normal:


hover:


webrev : http://cr.openjdk.java.net/~pmuthuswamy/8209052/webrev.01/

Thanks,
Priya
On 8/15/2018 3:26 AM, Jonathan Gibbons wrote:
> Priya,
>
> Even superficial playing with the JDK API confirms that javadoc uses a 
> different color for hovering over links.
> I think the same should apply to these summary caption links as well.
>
> -- Jon
>
> On 08/13/2018 04:58 PM, Jonathan Gibbons wrote:
>>
>> I'm surprised that you propose to set all of these styles to the same 
>> color:
>> +.constantsSummary caption a:link, .constantsSummary caption a:hover, 
>> .constantsSummary caption a:active,
>> +.constantsSummary caption a:visited,
>> Doesn't that mean we won't be able to tell the difference between 
>> non-visited and visited links?
>> Also, if you specify styles for all "a:link a:hover a:active 
>> a:visited", what's the point of specifying
>> those cases separately: are there any others?  Couldn't you just 
>> collapse those 4 to just "a"?
>> Not that I'm suggesting that: I think it's better to have some 
>> stylistic variation when you hover
>> over links or have visited them.
>>
>> -- Jon
>>
>> On 8/7/18 6:34 AM, Priya Lakshmi Muthuswamy wrote:
>>> Hi,
>>>
>>> Kindly review fix for https://bugs.openjdk.java.net/browse/JDK-8209052
>>> webrev : http://cr.openjdk.java.net/~pmuthuswamy/8209052/webrev.00/
>>>
>>>
>>>
>>> Thanks,
>>> Priya
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/javadoc-dev/attachments/20180816/ed3325b8/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bnkpnahmcofedaai.png
Type: image/png
Size: 6594 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/javadoc-dev/attachments/20180816/ed3325b8/bnkpnahmcofedaai-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mkobkeajdijbohmn.png
Type: image/png
Size: 6830 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/javadoc-dev/attachments/20180816/ed3325b8/mkobkeajdijbohmn-0001.png>


More information about the javadoc-dev mailing list