RFR: 8214856 : Errors with JSZip in web console after upgrade to 3.1.5

[Hannes Wallnoefer]

Hi Priya,

This is not related directly to your change, but why is the 
JSUtils.getBinaryContent call nested in a $.get()? Is this just to 
handle errors and check if the zip file is available? It seems like we 
fetch the zip file twice when we could just test the error argument in 
the JSUtils.getBinaryContent  callback as shown here:

https://stuk.github.io/jszip/documentation/howto/read_zip.html

A minor formatting related issue: the indentation of the closing 
braces/parentheses looks a bit random.

Otherwise +1.

Hannes

Am 05.12.18 um 12:28 schrieb Priya Lakshmi Muthuswamy:
> Hi,
>
> Kindly review the fix for 
> https://bugs.openjdk.java.net/browse/JDK-8214856
> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8214856/webrev.00/
>
> In JSZip 3.x few api's have changed. Made the changes according to the 
> JSZip upgrade 
> guidelines(https://stuk.github.io/jszip/documentation/upgrade_guide.html).
>
> Thanks,
> Priya
>
>