RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal

[Jan Lahoda]

Hi Martin,

Does your JDK 10 build have the following fix?
http://hg.openjdk.java.net/jdk/jdk10/rev/107413b070b9

I tried and the build indeed fails when using JDK 10 without this fix as 
a bootstrap, but does not (seem to) fail when using JDK 10 with this fix.

Jan

> From: *Martin Buchholz* <martinrb at google.com <mailto:martinrb at google.com>>
> Date: Sat, Feb 10, 2018 at 7:36 AM
> Subject: Re: RFR: 8194651: javadoc: mark the com.sun.javadoc API for removal
> To: Jonathan Gibbons <jonathan.gibbons at oracle.com
> <mailto:jonathan.gibbons at oracle.com>>
> Cc: javadoc-dev <javadoc-dev at openjdk.java.net
> <mailto:javadoc-dev at openjdk.java.net>>
>
>
> I can confirm that it is this commit:
>
> changeset:   48840:5e2d2067da48  tip
> user:        ksrini
> date:        2018-02-09 13:58 -0800
> 8194651: javadoc: mark the com.sun.javadoc API for removal
> Reviewed-by: jjg
>
> that causes a build failure when rebuilding from scratch.
>
> I bisected my configure flags - it's the boot jdk
>
> bash ./configure --with-boot-jdk=/home/martin/jdk/jdk10
> fails while
> bash ./configure --with-boot-jdk=/home/martin/jdk/jdk9
> succeeds.
>
> Y'all are probably still using jdk9 as bootstrap.
>
> But as you all know, it's been the rule since time immemorial to use JDK
> N-1 to bootstrap JDK N.
>
>
>
> On Fri, Feb 9, 2018 at 4:22 PM, Jonathan Gibbons
> <jonathan.gibbons at oracle.com <mailto:jonathan.gibbons at oracle.com>> wrote:
>
>     Martin,
>
>     I'm not hearing any CI alarm bells ringing here, and I've just
>     completed a clean build of the latest bits in jdk/jdk repo.
>
>     There was a related javac fix that went back a few days ago, from
>     Jan Lahoda. Is it possible that either you didn't pick up that fix,
>     or that you have a locally modified copy of javadoc that needs to be
>     updated?
>
>     -- Jon
>
>
>     On 02/09/2018 04:06 PM, Martin Buchholz wrote:
>>     This seems to break the build
>>
>>     * For target
>>     buildtools_interim_langtools_modules_jdk.javadoc.interim__the.BUILD_jdk.javadoc.interim_batch:
>>     /home/martin/ws/jdk/src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SourcePositionImpl.java:31:
>>     warning: [removal] SourcePosition in com.sun.javadoc has been
>>     deprecated and marked for removal
>>     import com.sun.javadoc.SourcePosition;
>>                           ^
>>     error: warnings found and -Werror specified
>>     1 error
>>     1 warning
>>
>>
>>     On Fri, Feb 9, 2018 at 10:51 AM, Jonathan Gibbons
>>     <jonathan.gibbons at oracle.com <mailto:jonathan.gibbons at oracle.com>>
>>     wrote:
>>
>>         OK
>>
>>         -- Jon
>>
>>
>>
>>         On 1/23/18 2:02 PM, Kumar Srinivasan wrote:
>>
>>             Hi,
>>
>>             Please review fix for 8194651,
>>             https://bugs.openjdk.java.net/browse/JDK-8194651
>>             <https://bugs.openjdk.java.net/browse/JDK-8194651>
>>             Webrev:
>>             http://cr.openjdk.java.net/~ksrini/8194651/webrev.01/
>>             <http://cr.openjdk.java.net/%7Eksrini/8194651/webrev.01/>
>>
>>             Please note this is blocked by: JDK-8194764
>>
>>             Thanks
>>             Kumar
>>
>>
>>
>
>
>