RFR: JDK-8194955: Warn when default HTML version is used

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Fri Jan 12 15:01:03 UTC 2018


Hi Jon,

Generally the changes looks good to me.

One observation though, otherwise ok.

TestHtmlWarning.java:
I think that test should either create discrete directories for its output
or the test should delete all of its output, upon completion.
Running output comparators may yield false positives, as the execution
sequence of  sub-tests is not deterministic.

Kumar

*
*
On 1/11/2018 6:21 PM, Jonathan Gibbons wrote:
> Please review a simple fix to generate a warning when the user does not
> explicitly specify whether to use HTML 4.01 or HTML5. The default is
> (still) HTML 4.01, but is planned to be changed in an upcoming release,
> such as JDK 11.
>
> Users should ensure that they specify the version of HTML used in
> their doc comments, and which will be used for the generated output.
>
> The change to the tool is very simple.  A new test is added that is 
> specific
> to this feature. A small number of other tests that are sensitive to 
> the number
> of warnings generated have been updated to avoid generating the warning.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8194955
> Webrev: http://cr.openjdk.java.net/~jjg/8194955/webrev.00/index.html
>
> -- Jon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/javadoc-dev/attachments/20180112/5ed0c96c/attachment.html>


More information about the javadoc-dev mailing list