RFR: 8207190: JDK 11 javadoc generates bad code example

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Mon Jul 16 11:31:19 UTC 2018


Looks good

-Sundar

On 16/07/18, 3:50 PM, Priya Lakshmi Muthuswamy wrote:
> Thanks Sundar.
> Updated webrev : 
> http://cr.openjdk.java.net/~pmuthuswamy/8207190/webrev.01/
>
> Regards,
> Priya
>
> On 7/16/2018 2:24 PM, Sundararajan Athijegannathan wrote:
>> In MethodWriterImpl.getSignature method: "pre" variable could be 
>> declared to be of static type HtmlTree so that you can avoid the cast 
>> in the very next line - or perhaps you could just use "var" for the 
>> declaration.
>>
>> -Sundar
>>
>> On 16/07/18, 1:53 PM, Priya Lakshmi Muthuswamy wrote:
>>> Hi,
>>>
>>> Kindly the fix for https://bugs.openjdk.java.net/browse/JDK-8207190
>>> webrev : http://cr.openjdk.java.net/~pmuthuswamy/8207190/webrev.00/
>>>
>>> This issue was caused as part of the fix for JDK-8187288 (bad (no) 
>>> wrapping for modifier and type column)
>>> When the method has lots of modifiers and arguments, the method 
>>> signature gets very long doesn't fit within the page.
>>> Instead of changing the white-space property in the pre tag of 
>>> details section, changing it only for the method signature.
>>>
>>> Thanks,
>>> Priya
>


More information about the javadoc-dev mailing list