RFR: 8176453: Javadoc search: there are issues with generics in parameters

[Jonathan Gibbons]

While parameterized types typically just contain < and >, the bounds may 
sometimes include &, so I tend to agree with Sundar that if you need to 
escape < > you probably need to escape & as well.

Even if we can't automate tests (yet?) I think it would be good for you 
to set up test cases for manual tests that allow us to check the 
behavior on the OS and browser of our choice.  Simply asking us to test 
this is not enough.

If you can find test cases that leverage the latest JDK API, then you 
could point at that. Otherwise you could construct test cases and post 
them near the webrev on your account as cr.ojn.  Sometimes I will just 
build the latest JDK API and post that on cr.ojn.

-- Jon


On 07/30/2018 07:19 AM, Sundararajan Athijegannathan wrote:
> Don't you also need |".|replace(/&/g,'&')|"?
>
> PS. Isn't there a standard way to escape HTML in JS?
>
>
> ||-Sundar|
> ||
> On 27/07/18, 7:51 PM, Hannes Wallnöfer wrote:
>> Please review and test this patch to escape < and > characters in search results to HTML < and > entities.
>>
>> Issue:https://bugs.openjdk.java.net/browse/JDK-8176453
>> Webrev:http://cr.openjdk.java.net/~hannesw/8176453/webrev.00/
>>
>> This fixes rendering of search results for search terms containing generics such as „map<str“.
>>
>> Thanks,
>> Hannes
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/javadoc-dev/attachments/20180730/f512f222/attachment.html>