RFR: JDK-8204303: Add redirect for overview-summary.html

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Wed Jun 6 03:42:24 UTC 2018


Looks good.

Minor: "private DocPath target;" could be final in IndexRedirectWriter

-Sundar

On 05/06/18, 10:46 PM, Jonathan Gibbons wrote:
> The recent change to update javadoc to not generate frames by default 
> means that the overview-summary.html file is no longer generated: the 
> content that was previously in that file is now in the top-level 
> index.html file.
>
> This means that any saved bookmarks to the overview-summary.html file 
> are invalid.
>
> The fix is to generate a dummy overview-summary.html that simply 
> redirects to the top-level index.html file. The file is only generated 
> when it would otherwise have been generated in frames mode. The file 
> may eventually be removed in an unspecified future release, after 
> suitable explicit warnings have been made.
>
> The change leverages the existing code in IndexRedirectWriter.java, by 
> generalizing it to create redirect files from any file to any other 
> file in the doc bundle.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8204303
> Webrev: http://cr.openjdk.java.net/~jjg/8204303/webrev.00/index.html
>
> -- Jon
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/javadoc-dev/attachments/20180606/76ed15bd/attachment.html>


More information about the javadoc-dev mailing list