RFR: 8200432: javadoc fails with ClassCastException on {@link byte[]}

[Jonathan Gibbons]

I'm not wildly enthusiastic about this, because while it prevents the 
CCE, it seems to be generally going in the wrong direction. We need to 
be looking at supporting more signatures in {@link}, not restricting the 
set of supported signatures.  While it may seem silly to write {@link 
String[]} it does make sense to want to write {@link List<String>}.  In 
other words, we should accept type signatures that contain possible 
multiple names and other punctuation, just as we can write {@link 
Object#equals(Other} and have it do the right thing.

I also note the use of a regular expression that is complicated enough 
for Sundar to suggest that you use a comment. I would refer you to 
http://regex.info/blog/2006-09-15/247

-- Jon


On 11/14/2018 06:43 PM, Sundararajan Athijegannathan wrote:
> Updated webrev looks good!
>
> -Sundar
>
> On 14/11/18, 8:25 PM, Hannes Wallnöfer wrote:
>> Thanks, Sundar.
>>
>> I uploaded a new webrev with a comment:
>>
>> http://cr.openjdk.java.net/~hannesw/8200432/webrev.01/
>>
>> Hannes
>>
>>> Am 13.11.2018 um 16:32 schrieb Sundararajan 
>>> Athijegannathan<sundararajan.athijegannathan at oracle.com>:
>>>
>>> Looks good.
>>>
>>> Minor nit: There could be a source comment for this pattern in 
>>> Checker.java
>>> +    private final static Pattern arrayPattern = 
>>> Pattern.compile("^[^\\(]+\\[]");
>>>
>>> -Sundar
>>>
>>> On 13/11/18, 6:52 PM, Hannes Wallnöfer wrote:
>>>> Please review:
>>>>
>>>> Issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-8200432
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~hannesw/8200432/webrev.00/
>>>>
>>>>
>>>> Thanks,
>>>> Hannes
>>>>