RFR: JDK-8214139: Remove wrapper methods from {Base,Html}Configuration

Priya Lakshmi Muthuswamy priya.lakshmi.muthuswamy at oracle.com
Wed Nov 21 11:29:17 UTC 2018


+1

-Priya
(not a "R"eviewer)

On 11/21/2018 3:49 AM, Jonathan Gibbons wrote:
>
> Please review a conceptually simple cleanup for the doclet code.
>
> The change is:
>
>   * replace all uses of all overloads of Configuration.getText with
>     the underlying implementation of Resources.getText
>   * replace all uses of all overloads of Configuration.getContent with
>     the underlying implementation of Contents.getContent
>   * remove all overloads of Configuration.getText
>   * remove all overloads of Configuration.getContent
>
> The change is mostly mechanical, via an IDE, with some minor manual 
> fixup. The most notable manual change is to defer initializing Extern 
> so that we can cache Configuration.getResources.
>
> The changes are all very localized, so it may be easy to read the 
> overall patch, or the Udiffs in the webrev than the side-by-side diffs.
>
> noreg-cleanup, so no tests. All the tests still pass, and "make docs" 
> is the same before and after.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8214139
> Webrev: http://cr.openjdk.java.net/~jjg/8214139/webrev.00/
>
> -- Jon
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/javadoc-dev/attachments/20181121/9cbccf7b/attachment.html>


More information about the javadoc-dev mailing list