RFR [14] 8234746: Improve indexing of system properties

[Pavel Rappo]

> On 25 Nov 2019, at 18:54, Hannes Wallnöfer <hannes.wallnoefer at oracle.com> wrote:
> 
> Hi Pavel,
> 
> Looks good to me, but two very minor enhancement suggestions:

I have changed the fix a bit, you can see the new version here:

    http://cr.openjdk.java.net/~prappo/8234746/webrev.01/

> First, It’s not a big deal but the TestSystemPropertyTaglet.testSystemProperytWithinATag test could be quite easily expanded to cover this new behaviour (there’s a checkOrder("index-all.html“ ...) in another test that should be quite similar to what you need).

Thanks for catching this, Hannes! Actually, there was a defect in my method of testing that first change.
Once I fixed it, I immediately saw a bunch of tests failing, which comes as no surprise. 

> I also noticed that there are two unused variable declarations in close vicinity to the code you added in TagletWriterImpl.java:
> 
> line 429: DocPaths docPaths = configuration.docPaths;
> line 433: TypeElement te = utils.getEnclosingTypeElement(e);
> 
> Would be nice to clean those up while you’re at it.

Done.

> Hannes
> 
> 
>> Am 25.11.2019 um 18:19 schrieb Pavel Rappo <pavel.rappo at oracle.com>:
>> 
>> Hello,
>> 
>> Please review the following change for https://bugs.openjdk.java.net/browse/JDK-8234746:
>> 
>>  http://cr.openjdk.java.net/~prappo/8234746/webrev.00/
>> 
>> Before:
>> 
>> javax.rmi.ssl.client.enabledCipherSuites - Search tag in javax.rmi.ssl.SslRMIClientSocketFactory
>> javax.rmi.ssl.client.enabledCipherSuites - Search tag in javax.rmi.ssl.SslRMIClientSocketFactory
>> ...
>> file.separator - Search tag in java.lang.System
>> 
>> After:
>> 
>> javax.rmi.ssl.client.enabledCipherSuites - Search tag in javax.rmi.ssl.SslRMIClientSocketFactory
>> javax.rmi.ssl.client.enabledCipherSuites - Search tag in javax.rmi.ssl.SslRMIClientSocketFactory.createSocket
>> ...
>> file.separator - Search tag in java.lang.System.getProperties
>> 
>> Thanks,
>> -Pavel
>> 
>