RFR: :tier1 XS testfix: 8218944: Fix failed for JDK-8218936

[Jonathan Gibbons]

cc: Jesper

On 2/13/19 5:58 PM, Jonathan Gibbons wrote:
> Sigh, the fix for JDK-8218936 broke a nearby test.
>
> It's a test to check links, but which was checking that a specific 
> error message about an invalid tag was present. This looks like 
> another side-effect of the removal for HTML4 support.
>
> The fix is to remove the check and update the test for the exit code.
>
> With this fix, all javadoc tests pass.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8218944
>
> -- Jon
>
>
> $ hg diff
> diff -r 2d5023bad20a 
> test/langtools/jdk/javadoc/doclet/testLinkOption/TestLinkOption.java
> --- 
> a/test/langtools/jdk/javadoc/doclet/testLinkOption/TestLinkOption.java 
> Wed Feb 13 17:18:56 2019 -0800
> +++ 
> b/test/langtools/jdk/javadoc/doclet/testLinkOption/TestLinkOption.java 
> Wed Feb 13 17:49:39 2019 -0800
> @@ -69,9 +69,7 @@
>                  "-linkoffline", url, testSrc + "/jdk",
>                  "-package",
>                  "pkg", "mylib.lang");
> -        checkExit(Exit.ERROR);
> -        checkOutput(Output.OUT, true,
> -                "tag not supported in the generated HTML version: tt");
> +        checkExit(Exit.OK);
>
>          checkOutput("pkg/C.html", true,
>                  "<a href=\"" + url + 
> "java/lang/String.html?is-external=true\" "
>