RFR: 8219497 Unused parameter in HtmlDocletWriter::printHtmlDocument

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Feb 21 01:17:58 UTC 2019


Please review a noreg-cleanup patch to remove an unused parameter from 
HtmlDocletWriter::printHtmlDocument

In the review for 8218998 [1], it was noted that there was an unused 
parameter for HtmlDocletWriter::printHtmlDocument. The parameter is a 
left-over from previous refactorings to simplify the old 
HtmlDocletWriter / HtmlDocWriter ? HtmlWriter hierarchy. The 
functionality is now handled within HtmlDocletWriter::getBody.

Note: If we were not about to remove support for frames, it might have 
been appropriate to verify that the page title was set correctly on all 
kinds of pages. I suspect that that may not have been the case. Given 
that we intend to remove support for frames, we should probably do the 
opposite and remove support for setting the window title as part of the 
work for removing frames.

-- Jon

JBS: https://bugs.openjdk.java.net/browse/JDK-8219497
Webrev: http://cr.openjdk.java.net/~jjg/8219497/webrev.00/
[1] 
https://mail.openjdk.java.net/pipermail/javadoc-dev/2019-February/000865.html



More information about the javadoc-dev mailing list