RFR: 8215584 : Remove support for the "old" doclet API in com/sun/javadoc

[Jonathan Gibbons]

OK.

-- Jon


On 02/20/2019 11:58 PM, Priya Lakshmi Muthuswamy wrote:
> Hi,
>
> I have updated the error message.
> upgraded webrev : webrev : 
> http://cr.openjdk.java.net/~pmuthuswamy/8215584/webrev.01/
>
> Thanks,
> Priya
>
> On 2/21/2019 3:11 AM, Jonathan Gibbons wrote:
>> Priya,
>>
>> Previously, when specifying the class for a doclet on the 
>> command-line, there were three possibilities.
>>
>> 1. The class was a modern new doclet
>>
>> 2. The class was an old doclet.  In this case a warning was given.
>>
>> 3. The class was not a doclet. In this case an error was eventually 
>> given, coming from the old Start class
>>
>> You have changed it in a way that conflates both 2 and 3.  Yes, you 
>> have changed the "main.legacy_api" message, but you have done so in a 
>> way that presumes that the user was trying to specify an old-style 
>> doclet class, which may not have been the case if the user made some 
>> other mistake.
>>
>> I think you should change the name of the resource to something like 
>> "main.not_a_doclet" and provide text like
>>
>> main.not_a_doclet=\
>>     Class {0} is not a valid doclet class.\n\
>>     Note: As of JDK 13, the com.sun.javadoc API is no longer supported.
>>
>> The second line (the Note:) is optional; the message would be OK 
>> without it, but if you provide it, it should be removed after a 
>> couple more releases, such as in JDK 15. You could a JBS issue to 
>> remove the line in JDK 15.
>>
>> -- Jon
>>
>> On 02/11/2019 09:44 PM, Priya Lakshmi Muthuswamy wrote:
>>> Hi,
>>>
>>> Kindly review the changes for removal of old doclet API in 
>>> com/sun/javadoc
>>>
>>> webrev : http://cr.openjdk.java.net/~pmuthuswamy/8215584/webrev.00/
>>> JBS : https://bugs.openjdk.java.net/browse/JDK-8215584
>>> CSR: https://bugs.openjdk.java.net/browse/JDK-8215587
>>>
>>> Thanks,
>>> Priya
>>>
>>