RFR (S): 8217773: Test langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java fails after JDK-8217034

[Langer, Christoph]

Hi Jon,

> Thanks again for reporting the problem. It went unnoticed here because it is
> not common to run tests with proxy access through the corporate firewall,
> and this test quietly skips one of its subtests when it cannot access an
> external resource. I was able to reproduce your results by running the test
> with proxies set up.

Ah, that explains it. We're obviously having an environment with outbound internet access in our CI infrastructure where the test failed. And it reproduced on my desktop, too, since it also has connectivity.

> There are two possible fixes to the problem. One is to disable the "missing
> file" check, and the other to to change the name of the target in the link to a
> nearby file that does exist.  Here are the two patches,


> Of the two, I prefer the second on principle, because having worked to
> enable automatic link checking as much as possible, I don't like disabling it
> anywhere. The one wrinkle here is that the change impacts another test in
> the same directory, but that one is easy to fix up, and to then enable the link
> checking in that part of that test.  That additional fix is included in the
> webrev.

I agree.


> http://cr.openjdk.java.net/~jjg/8217773/webrev.00/

Looks good. I tested this fix in both, the CI and my desktop. Reviewed.

Thanks & Best regards
Christoph