RFR: 8228393: Add an indicator for external links in javadoc

Hannes Wallnöfer hannes.wallnoefer at oracle.com
Tue Jul 30 10:50:53 UTC 2019


The XML structure is actually ok as the empty element is a <path .../> element inside the outer <svg>...</svg> element.

But that was indeed hard to read due to the  very long line. I uploaded a new webrev with wrapped lines:

http://cr.openjdk.java.net/~hannesw/8228393/webrev.01/

Hannes



> Am 29.07.2019 um 18:01 schrieb Jonathan Gibbons <jonathan.gibbons at oracle.com>: 
> 
> The XML for the SVG looks questionable since you have both a self-closing opening tag `<svg .../>` and a separate closing tag `</svg>`
> 
> Is it possible to wrap the lines?
> 
> -- Jon
> 
> On 7/25/19 10:07 AM, Hannes Wallnöfer wrote:
>> Please review:
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8228393
>> Webrev: http://cr.openjdk.java.net/~hannesw/8228393/webrev.00/
>> 
>> The external-link.svg is just added just for future editing as the CSS-inlined bits can’t be easily modified.
>> 
>> This is the smaller superscript version as shown in these examples:
>> 
>> http://cr.openjdk.java.net/~hannesw/8228393/demo/v3/IDN.html
>> http://cr.openjdk.java.net/~hannesw/8228393/demo/v3/SignatureMethod.html
>> http://cr.openjdk.java.net/~hannesw/8228393/demo/v3/package-use.html
>> 
>> Thanks,
>> Hannes



More information about the javadoc-dev mailing list