RFR: JDK-8223364 : Bad placement of anchor relative to header

[Hannes Wallnöfer]

I updated Priya’s patch to apply on top of current code (there were a few conflicts in tests because of signature changes and a few missing imports in main code). 

I also had to adapt the style for the new member signature DIV a bit in the stylesheet. When I did the member signature change, I slightly reduced the top margin to make good for the excessive space. Now the margin is back to 14px for top and bottom and 0 for the sides, which is exactly what PRE uses by default. I tested this in Firefox, Chrome, and Safari, the spacing is always the same as Priya’s version that still uses PRE for member signatures.

Webrev: http://cr.openjdk.java.net/~hannesw/8223364/webrev.00/
New API: http://cr.openjdk.java.net/~hannesw/8223364/api/

Priya’s API for comparison: http://cr.openjdk.java.net/~pmuthuswamy/8223364/8223364/review.01/api/

Thanks,
Hannes


> Am 30.05.2019 um 02:39 schrieb Jonathan Gibbons <jonathan.gibbons at oracle.com>:
> 
> OK,
> 
> It would be better if the placement were consistent, but this is a step in the right direction.
> 
> Looking at the use of empty comments, it seems fundamentally flawed, which is part of the white-space issue you were seeing, but that's a separate issue that we can handle separately.
> 
> This is OK to push.
> 
> -- Jon
> 
> 
> On 05/27/2019 04:04 PM, Jonathan Gibbons wrote:
>> Ah, OK, I missed that in the webrev; I'll take another look.
>> 
>> -- Jon
>> 
>> On 5/26/19 9:24 PM, Priya Lakshmi Muthuswamy wrote:
>>> Hi Jon,
>>> 
>>> The extra blank space was appearing if we place anchor before the the heading.
>>> This issue mainly occurs in field/method/constructor... detail section.
>>> 
>>> It is addressed by placing anchor within the header element.
>>> Example of field details(separatorChar) in File.html :
>>> <section class="detail">
>>> <h3><a id="separatorChar">separatorChar</a></h3>
>>> 
>>> In the summary section, blank space issue is not there, so have placed anchor before the heading.
>>> 
>>> File.html structure:
>>> http://cr.openjdk.java.net/~pmuthuswamy/8223364/8223364/review.01/File.html 
>>> 
>>> Thanks,
>>> Priya
>>> 
>>> On 5/24/2019 9:49 PM, Jonathan Gibbons wrote:
>>>> Hi Priya,
>>>> 
>>>> Previously, you were concerned about extra blank space appearing above the heading.
>>>> Can you point to what you have done to address that issue?
>>>> 
>>>> -- Jon
>>>> 
>>>> On 5/24/19 5:41 AM, Priya Lakshmi Muthuswamy wrote:
>>>>> Hi,
>>>>> 
>>>>> Kindly review the fix for https://bugs.openjdk.java.net/browse/JDK-8223364
>>>>> 
>>>>> webrev : http://cr.openjdk.java.net/~pmuthuswamy/8223364/8223364/review.01/webrev.00/
>>>>> api : http://cr.openjdk.java.net/~pmuthuswamy/8223364/8223364/review.01/api/
>>>>> 
>>>>> Thanks,
>>>>> Priya
>>>>> 
>