RFR: 8219060 -linksource broken with modules

[Jonathan Gibbons]

OK.

I didn't mean for you to post a new webrev, but since you did, I looked 
at it. :-)

Looks good to me.

-- Jon


On 05/10/2019 09:56 AM, Hannes Wallnöfer wrote:
> Thanks for the review, Jon.
>
> Here’s a new webrev with removed capitals and the test split in two methods.
>
> http://cr.openjdk.java.net/~hannesw/8219060/webrev.01/
>
> Hannes
>
>
>
>> Am 10.05.2019 um 02:47 schrieb Jonathan Gibbons <jonathan.gibbons at oracle.com>:
>>
>>
>>
>> On 04/30/2019 06:21 AM, Hannes Wallnöfer wrote:
>>> Please review:
>>>
>>> Issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8219060
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~hannesw/8219060/webrev.00/
>>>
>>>
>>> Thanks,
>>> Hannes
>>>
>> Mostly OK ... some style comments to fix before pushing
>>
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java.sdiff.html
>>   171      * Convert the documented Packages contained in the given Module to an HTML representation.
>>   172      *
>>   173      * @param mdl the Module to convert.
>> Don't use capitals for "Packages, Module" and "Module" (2x)
>>
>>
>>
>> test/langtools/jdk/javadoc/doclet/testModules/TestModules.java.sdiff.html
>>
>> The style is one invocation of javajoc, and related checks, per @Test method, unless there is a strong dependency
>> between the invocations.  So, I suggest splitting testLinkSource into two methods.
>>
>> -- Jon
>>