RFR: 8223378: CSS solution for navbar problem with <'a> elements is not ideal

[Jonathan Gibbons]

I've started going through this.

It's a bit confusing that the new class 'BodyContent' is not (and should 
not be) a subtype of Content.  It goes against the general naming scheme 
of <adjective><noun> for an <adjective> subtype of a <noun>.  
BodyBuilder might be slightly better, but I'm open to other suggestions 
as well, including plain "Body", which follows the convention of "Table" 
for the table builder for a <table> element.

I also note that while you have declared the class to support 
fluent-usage (i.e. its methods return "this"), you don't use that 
ability when using the class.

-- Jon

On 11/5/19 6:49 AM, Hannes Wallnöfer wrote:
> I found a few problems with the first webrev. First, the generated documentation didn’t render correctly on some versions of Internet Explorer, because I had left away some markup/css that is not required in current browsers.
>
> Second, I had omitted some *Writers that still outputted the old markup, namely ConstantsSummaryWriter, SerializedFormWriter, AllPackagesIndexWriter and AllClassesIndexWriter.
>
> The new webrev below takes care of these issues.
>
> New webrev: cr.openjdk.java.net/~hannesw/8223378/webrev.02/
> New docs: http://cr.openjdk.java.net/~hannesw/8223378/api.02/
>
> Hannes
>
>
>> Am 31.10.2019 um 15:40 schrieb Hannes Wallnöfer <hannes.wallnoefer at oracle.com>:
>>
>> Please review:
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8223378
>> Webrev: http://cr.openjdk.java.net/~hannesw/8223378/webrev.01/
>> API docs: http://cr.openjdk.java.net/~hannesw/8223378/api.01/
>>
>> This implements the CSS Flexible Box Layout Module based page structure for the fixed header.
>> I added a new PageContent builder class to simplify generation of the new layout structure across all the writer classes. In the process I also cleaned up some code a bit (getting rid of unused fields and parameters, removing obsolete javascript etc).
>>
>> Thanks,
>> Hannes