RFR [14] 8234746: Improve indexing of system properties

[Hannes Wallnöfer]

Hi Pavel,

Looks good to me, but two very minor enhancement suggestions:

First, It’s not a big deal but the TestSystemPropertyTaglet.testSystemProperytWithinATag test could be quite easily expanded to cover this new behaviour (there’s a checkOrder("index-all.html“ ...) in another test that should be quite similar to what you need).

I also noticed that there are two unused variable declarations in close vicinity to the code you added in TagletWriterImpl.java:

line 429: DocPaths docPaths = configuration.docPaths;
line 433: TypeElement te = utils.getEnclosingTypeElement(e);

Would be nice to clean those up while you’re at it.

Hannes


> Am 25.11.2019 um 18:19 schrieb Pavel Rappo <pavel.rappo at oracle.com>:
> 
> Hello,
> 
> Please review the following change for https://bugs.openjdk.java.net/browse/JDK-8234746:
> 
>   http://cr.openjdk.java.net/~prappo/8234746/webrev.00/
> 
> Before:
> 
> javax.rmi.ssl.client.enabledCipherSuites - Search tag in javax.rmi.ssl.SslRMIClientSocketFactory
> javax.rmi.ssl.client.enabledCipherSuites - Search tag in javax.rmi.ssl.SslRMIClientSocketFactory
> ...
> file.separator - Search tag in java.lang.System
> 
> After:
> 
> javax.rmi.ssl.client.enabledCipherSuites - Search tag in javax.rmi.ssl.SslRMIClientSocketFactory
> javax.rmi.ssl.client.enabledCipherSuites - Search tag in javax.rmi.ssl.SslRMIClientSocketFactory.createSocket
> ...
> file.separator - Search tag in java.lang.System.getProperties
> 
> Thanks,
> -Pavel
>